From patchwork Thu Feb 12 15:12:37 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 26139 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D255AC32EA for ; Thu, 12 Feb 2026 15:12:47 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 572D361FBF; Thu, 12 Feb 2026 16:12:47 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="cPOrMGY2"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id EA7A0621CC for ; Thu, 12 Feb 2026 16:12:43 +0100 (CET) Received: from killaraus.ideasonboard.com (2001-14ba-703d-e500--2a1.rev.dnainternet.fi [IPv6:2001:14ba:703d:e500::2a1]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id DBA2D492 for ; Thu, 12 Feb 2026 16:11:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1770909116; bh=l+01Hbanx+4e9pwhpj6nDti2Vnjhyi23IyAa1Ba30No=; h=From:To:Subject:Date:In-Reply-To:References:From; b=cPOrMGY2mMHrxsA74LIJF7g/ZrF9r0sBXhXCqwlXhOUxaJxxz6Q6aOk2RDj2wjNGA aF4Fn+PmkerTPJB3okD0DjhxT0u3lxpm5CP1YmwOaj5NXJ9zxRpDGES2DTHgmVsAa0 rgS3vONQFdXdz2PXAsYH8RiwpNZF/g0ReuZCyRFY= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Subject: [PATCH v2 3/4] libcamera: Use `it` variable name for iterators only Date: Thu, 12 Feb 2026 17:12:37 +0200 Message-ID: <20260212151238.3736234-4-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260212151238.3736234-1-laurent.pinchart@ideasonboard.com> References: <20260212151238.3736234-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Using the name `it` for a variable that is not an iterator is confusing. Give the variable a more explanatory name. Signed-off-by: Laurent Pinchart --- include/libcamera/internal/ipa_data_serializer.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/libcamera/internal/ipa_data_serializer.h b/include/libcamera/internal/ipa_data_serializer.h index 61bada52f691..0dda76d5b1d1 100644 --- a/include/libcamera/internal/ipa_data_serializer.h +++ b/include/libcamera/internal/ipa_data_serializer.h @@ -114,12 +114,12 @@ public: appendPOD(dataVec, vecLen); /* Serialize the members. */ - for (auto const &it : data) { + for (const auto &value : data) { std::vector dvec; std::vector fvec; std::tie(dvec, fvec) = - IPADataSerializer::serialize(it, cs); + IPADataSerializer::serialize(value, cs); appendPOD(dataVec, dvec.size()); appendPOD(dataVec, fvec.size());