From patchwork Wed Feb 11 17:00:36 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 26133 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 06C80BD78E for ; Wed, 11 Feb 2026 17:00:47 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id CF4F1621BD; Wed, 11 Feb 2026 18:00:46 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="iJeZOSUG"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="f2zF24DQ"; dkim-atps=neutral Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 248AE620C9 for ; Wed, 11 Feb 2026 18:00:45 +0100 (CET) Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61B96kmb3259680 for ; Wed, 11 Feb 2026 17:00:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=4F/ABCUgGqqyRoOW2aPvMIYTQKJ5G9FDZgT odHMLqjo=; b=iJeZOSUGZsAAGrSuBTpKoLgVJ43SRQttiIV99WybkN9JsonORMt LR1sConBGBTfhtYFyH9vJn6PbNA1nn0BRK43blnCaUgrP0YMc1x1F1gBAKShX7Fs x24kZ+ocf5IOnmpxtCB/91+P7nstFtMVY+KO1dHXeieTnvaNqnLsjl0EzRu2Tc6z /neAGQ/dvkbae8UNMB+NvXj717QHJr0AH8XEmC7/JvOkagYvksBbl9ReodTnBqQM W6ppfvI5vOWdS3oI6kAkWFtvSYWNlDLAm7t/hVi1H/7qPjxYbiH1LcqqldVfDFQu i+Plxsu6c9WvWWMHA7x/OYj8IMzQOQn/Bhw== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c88wqm21k-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 11 Feb 2026 17:00:43 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8c70fadd9a3so2071661685a.0 for ; Wed, 11 Feb 2026 09:00:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770829243; x=1771434043; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=4F/ABCUgGqqyRoOW2aPvMIYTQKJ5G9FDZgTodHMLqjo=; b=f2zF24DQ7qSmv5Hb0sXXQsKgTGrVK2OlrSQE47kUwGSg2/cTZBNtJCaTeUlTP8/f2r beshKr2u6T58Yk9neMiiUufMPAI9wxK/DhDNqOdZU7bu2qLaGs3ftyN2wbIrSDJRUMpB M9pO8+KwHa1ygZG+E/TpBBegUoKkOgt+kVh3RE2/vdcS4KpelGyesBWivWRgOpJeFaJY AbyBy7aKc211qiOhn1Ru+gL5yPSl9saEvF/p7Lm7tbvrGlu6ndyfU33zzROZkZHzg2YJ aGrFlWNWaCHLgLcFYWmKkYmyq3DXnXzj2fqCdWyue0XDBGZhcGg8RLm143I7eRpH5vxQ 3gVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770829243; x=1771434043; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4F/ABCUgGqqyRoOW2aPvMIYTQKJ5G9FDZgTodHMLqjo=; b=GTIg7xp/c+8e5axWqzmXrWYnR3OHMISXSpdcISJKW7lBqa7MEBV9Ifnyu87G7W1Kie USgjZfQxxjheVXCfidH6wEtA8H3cU0Q0Z0ChlINg/gpZpyGQ/ROn2nBXonlQAk47N310 RN7B8vVb1XdeZnnCwWFak30lIWPH1hSFSc1YBuSFm4APulqPSnyP4iXIX8clBcxiKNnn Jk7Pofj7MsSZtXWAfuHDJabyqJ5tKiEewOIBw5Tmr+8SsLZtFi79Xha+qvq2U2JmuewD QfCblz9g9FIgHrwJXXfKFvb/w6kgC24LbO33ILlpynt6Dyw0bD4oXX3jHo3xeFevl/jf cofw== X-Gm-Message-State: AOJu0Yz+zMT88ndqKiGT/tHowaH3TcPzCOCDEHHIqLCRq63Qm9fVkzzu /XqnkzBQs7wkVYO/8QeBl9WpT9HaUR7Gv0K9CM1eAh/DHxKqNmEdfuVgTyErcGtEvXKlTw/MlBY i3U31zvj3fTeSKmydITU2foomLz7y6xalOil/zSMzhkef5ceUfuxOVunnr0QnfvWsP5vuu029Qh wx9h+aoqPX X-Gm-Gg: AZuq6aJxrULy6pV9U+GOQvL6+OUi+pxG9t1Ierg3qrUsy/zHBg+QWnFuAlW9PFhbrSH MwpvIHONFH4buRLri7t9aWVR651tnUvae3KKN09fwQ1kDQl2ttKzuvTGqxTtgGMDVRnGyBm9pxk WOnP4FCZsKUBJYbnbqk0FDjV4+vgBeEo/kMahyBFGlJp4+XNat/S7JSyk9ZCY1CqQ+AKV/vLbVD qtvfZMHatbgl4BaSVY/mas2aB+RAHKTf/fN6socNIhavYrDR8Hq7jEstQr6bTpIlnlDdy2wuXCk q81mvCPhSaYyXQH73cUIcvXtVSeSaOmeiCpAFS/EKXB72LoFCb9zkPZtwqcHFeYZX8hV4LkUIim T7cu14d8IFcxaelH7kzlXU8C4jROyaHiL4xwHkJZ6mmTduYba/OqsYDx5qCZ/oTwXL9vfdnHBqN bosReB1CMDdRLyrLuKC85f+bsDM6R/swUrWrMy X-Received: by 2002:a05:620a:1909:b0:8c9:fb69:e708 with SMTP id af79cd13be357-8cb27fb6220mr430118885a.25.1770829240281; Wed, 11 Feb 2026 09:00:40 -0800 (PST) X-Received: by 2002:a05:620a:1909:b0:8c9:fb69:e708 with SMTP id af79cd13be357-8cb27fb6220mr430102385a.25.1770829239284; Wed, 11 Feb 2026 09:00:39 -0800 (PST) Received: from shalem (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-65a3cebf697sm867606a12.10.2026.02.11.09.00.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Feb 2026 09:00:38 -0800 (PST) From: Hans de Goede To: libcamera-devel@lists.libcamera.org, Milan Zamazal Cc: Hans de Goede Subject: [PATCH 1/2] software_isp: benchmark: Add missing _ postfix to measure data member Date: Wed, 11 Feb 2026 18:00:36 +0100 Message-ID: <20260211170037.131630-1-johannes.goede@oss.qualcomm.com> X-Mailer: git-send-email 2.52.0 MIME-Version: 1.0 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjExMDEzMSBTYWx0ZWRfX2O7877Znnzvu fDGnAJ6HAsSp6ct+2Se1U2EVxGcMyWS4iG5ZL/5IV4a9y9jj8duZvA9grxtZXouRgisuFbQeC/T pDppO7Y2YzMFK9d4PBUYmwOqGXqoWIu/P8L/Gq8w83/gs93dwXTSgZzR/pjaCp1noQl0yUHja1P tXflNT95szTfrE88SQusxV/NWnYLPDWs6HpUisYKwWW+T4PZLmLXj9E0cUTk2v0VkEy8AOwNNQ6 gMu+QSZi4+frLhc4E8vHd6N77XaHPbQ6+t+YC+zGUM2CDyZe8/LatTo8qQwtU+P8pP/cTf67XWk Hr2k1xAdeXnHtgeJPC5a2r1Q+3nogTTyhBAmm8QRuWwR4UO/3YrjKRG82hRz7LUiM9MbnMiCxSA lIDLS0mRf4bMXkyCS6bSUYzavUx3UkIIRjmP8gLL+Ndg6V5VYUN6edqO/95Bcs7oMezazaW0RLd DGaEI+6w/Wl5IH5184Q== X-Proofpoint-GUID: nHsF-mP1ua-DjTRBrcLBFpsPRr5uu7uA X-Authority-Analysis: v=2.4 cv=W7Q1lBWk c=1 sm=1 tr=0 ts=698cb5bb cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=2M7dtBtliclCZGfxGjwA:9 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-ORIG-GUID: nHsF-mP1ua-DjTRBrcLBFpsPRr5uu7uA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293, Aquarius:18.0.1121, Hydra:6.1.51, FMLib:17.12.100.49 definitions=2026-02-11_02,2026-02-11_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 suspectscore=0 adultscore=0 malwarescore=0 impostorscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602110131 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" All class data members should have a _ postifx, add the missing _ postfix to the Benchmark::measure_ data member. Signed-off-by: Hans de Goede --- include/libcamera/internal/software_isp/benchmark.h | 2 +- src/libcamera/software_isp/benchmark.cpp | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/libcamera/internal/software_isp/benchmark.h b/include/libcamera/internal/software_isp/benchmark.h index 0680d6cd..46bdb86d 100644 --- a/include/libcamera/internal/software_isp/benchmark.h +++ b/include/libcamera/internal/software_isp/benchmark.h @@ -28,7 +28,7 @@ public: private: timespec frameStartTime_; - bool measure; + bool measure_; /* Skip 30 frames for things to stabilize then measure 30 frames */ unsigned int encounteredFrames_ = 0; int64_t frameProcessTime_ = 0; diff --git a/src/libcamera/software_isp/benchmark.cpp b/src/libcamera/software_isp/benchmark.cpp index 1a00ae56..4ffb6773 100644 --- a/src/libcamera/software_isp/benchmark.cpp +++ b/src/libcamera/software_isp/benchmark.cpp @@ -54,11 +54,11 @@ static inline int64_t timeDiff(timespec &after, timespec &before) */ void Benchmark::startFrame(void) { - measure = framesToMeasure_ > 0 && - encounteredFrames_ < skipBeforeMeasure_ + framesToMeasure_ && - ++encounteredFrames_ > skipBeforeMeasure_; + measure_ = framesToMeasure_ > 0 && + encounteredFrames_ < skipBeforeMeasure_ + framesToMeasure_ && + ++encounteredFrames_ > skipBeforeMeasure_; - if (measure) { + if (measure_) { frameStartTime_ = {}; clock_gettime(CLOCK_MONOTONIC_RAW, &frameStartTime_); } @@ -75,7 +75,7 @@ void Benchmark::startFrame(void) */ void Benchmark::finishFrame(void) { - if (measure) { + if (measure_) { timespec frameEndTime = {}; clock_gettime(CLOCK_MONOTONIC_RAW, &frameEndTime); frameProcessTime_ += timeDiff(frameEndTime, frameStartTime_);