From patchwork Wed Feb 4 22:42:58 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 26094 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id E6429C32EA for ; Wed, 4 Feb 2026 22:43:06 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 1380B62052; Wed, 4 Feb 2026 23:43:05 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="VmFptq0Y"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B48C361FBF for ; Wed, 4 Feb 2026 23:43:00 +0100 (CET) Received: from [192.168.0.240] (ams.linuxembedded.co.uk [209.38.108.23]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 603781337; Wed, 4 Feb 2026 23:42:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1770244938; bh=gUjwGqFZam4HOUtVthtCwpm8yQSR4F1eQiUIUaiuX8E=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=VmFptq0YsBlXd+eaguJW9Mrr/k8LOyKiVeg9nsxR95wH+w1svHS10/0dMeYiJdfWg vXg//eUBR+OY8KbjgBjnemLgG5jjm6wvxSL+HYRY/+hrcgLAXQ/PTK5BvVNuLOiaSI D/iqC2xLRW1ZnZ85TMipySvkERqQ4q/hzLghBoN8= From: Kieran Bingham Date: Wed, 04 Feb 2026 22:42:58 +0000 Subject: [PATCH v2 3/3] libcamera: software_isp: Fix LIBCAMERA_SOFTISP_MODE log print MIME-Version: 1.0 Message-Id: <20260204-kbingham-fixups-v2-3-c341cced1fad@ideasonboard.com> References: <20260204-kbingham-fixups-v2-0-c341cced1fad@ideasonboard.com> In-Reply-To: <20260204-kbingham-fixups-v2-0-c341cced1fad@ideasonboard.com> To: libcamera-devel@lists.libcamera.org Cc: Kieran Bingham X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1770244979; l=1244; i=kieran.bingham@ideasonboard.com; s=20260204; h=from:subject:message-id; bh=gUjwGqFZam4HOUtVthtCwpm8yQSR4F1eQiUIUaiuX8E=; b=Mp/Pld+1Qjvx1/6JZweQ5ibufFECleq7XSuSGcUCZVXF697G15gvdzUsFDCgNQKVB9mLzCBNV nEIwTbu2BtlB6ti04ECcMcgxWE2NxRgSCiEOMTZdUIJxn+TjrUW3UqP X-Developer-Key: i=kieran.bingham@ideasonboard.com; a=ed25519; pk=IOxS2C6nWHNjLfkDR71Iesk904i6wJDfEERqV7hDBdY= X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" When an invalid parameter is specified to LIBCAMERA_SOFTISP_MODE, the error log has a typo. Fix the typo and reflow the line while here. Signed-off-by: Kieran Bingham --- src/libcamera/software_isp/software_isp.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp index a83986b787b75ac1cd9073b32f2b937e9efb6cf0..3eb9cf97dea66cb68f2277a8274003e28418d830 100644 --- a/src/libcamera/software_isp/software_isp.cpp +++ b/src/libcamera/software_isp/software_isp.cpp @@ -108,8 +108,10 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor, std::optional softISPMode = configuration.envOption("LIBCAMERA_SOFTISP_MODE", { "software_isp", "mode" }); if (softISPMode) { if (softISPMode != "gpu" && softISPMode != "cpu") { - LOG(SoftwareIsp, Error) << "LIBCAMERA_SOFISP_MODE " << softISPMode.value() << " invalid " - << "must be \"cpu\" or \"gpu\""; + LOG(SoftwareIsp, Error) + << "LIBCAMERA_SOFTISP_MODE " + << softISPMode.value() << " invalid " + << "must be \"cpu\" or \"gpu\""; return; } }