From patchwork Wed Feb 4 20:37:24 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Faizel K B X-Patchwork-Id: 26088 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B0945BD78E for ; Wed, 4 Feb 2026 20:38:12 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5D2986204C; Wed, 4 Feb 2026 21:38:12 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="W3xctmxA"; dkim-atps=neutral Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id EA27361FBF for ; Wed, 4 Feb 2026 21:38:10 +0100 (CET) Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-2a929763b57so210105ad.3 for ; Wed, 04 Feb 2026 12:38:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770237489; x=1770842289; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4RAohPMInpYRdZFPRVpri9RKwD42GbQUWynv/gE4tBc=; b=W3xctmxAMKKWXEtpM0q90zaifzGlH7inUmPsGGMbkF7zzaWrgx28PpPlzg2xMe30w3 p7qt+EN+/oVJsTTP3x2oaMnuW3M+oV3gMPtoSvsFPb1ukL6iiH5WGuj40fgj/+yHd4C3 GaHifV3VRAGcSHiVAb15WXmKq1W9XNVzJCbveFG2NX9iSwK7hFn+gYv4Wv/jCSQBEUMx /ceNvgVQUlJWMcDuzvVkTCUAAeG2wQzYhQ/+R5ftA5p01N/GM4nhRkyVcEVGXoO6HulL 0c182D0JCTcZjk+A/oL1lfO2QBKc8OsSD0+SkjkqK8OAbUlEy8c0ZA14pKOtllYHrqjo e/+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770237489; x=1770842289; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4RAohPMInpYRdZFPRVpri9RKwD42GbQUWynv/gE4tBc=; b=jrRtDAhOrdWECpT/s9HWj8Px413lmlQuO4kk+Nvv8edZxC9BLo5mphJWSAxq38PI+5 YBa3UiLF7aG0iJ3oqWQ1BPPjtjEt4Tzw4blo0iJHWynW0OQAknsTS0L7ARIV4/JWwMM2 lHRIBqdZFFipqxTrxsAme70+z0/OFMGSYk3He9UjvMk0XA4U4Ts7/LnPgtPlm9qYkFdY eYZooeQlu7Pvkl/xjk7BACQ38/idPlmWhjcMgnpa6HckmWxdETR38btZJd3tyEoAGsxY WFVYMTc5Ffjn4xOYDJyIT3uZAPsQ7aXp0f+JSe9xPwcxf/xT9u7+auzQwbLWemGJ/Amt e/Rw== X-Forwarded-Encrypted: i=1; AJvYcCUY79dZUcPrltfNQtZGGaOyU6tx10TeFyN7VEjKLGwg6gkDUHZBXuatMrTS5nMLjiZdSOnE3eopzR8m1Yg0asM=@lists.libcamera.org X-Gm-Message-State: AOJu0YxCvQC/U+0s46MlQyw+qarijkhotFuNhH4JpdZgIviTJzgivbOq 7mXDzjlq+U6dzk6u1r3Z6fh4mu3RhEezcKSd8uxeYbK4KcQgcKobnPz4 X-Gm-Gg: AZuq6aJiD1eYseUaoggxggrILNew5ZhbDsoY4WCUoGGIPPZLlEAARK1vHZFc0ixF0T7 uzkieLn9OQYzhSsPySaHclRllBYqNoWAlzZpvtJckE2OpKF5dB8gp2QXimiDTt5nPmwPsHQqwVl GFtuofYBB1+7usWP9oTThQNRp1o1CTGyMdPl9UnB4IzCOl0yZrpjx062gp0wtxNlalLoU/A6MFg lwCrSqGPJrKbaX8tUBKX4iohUS21y3BsP1Smibz73DacwSpLx1oCShG7ZwEqfeWH0Nyx6uPoOFj P2PSfV2y4JYwKew50kaowLDyX8cvtoOaFcv6rbnyCi0SiTe3qu2nnTh6z/Cs0z8ruAqYyugbV5l 3Osoniygk0DCl20/A6PahXvJ6pZVkERRl8tb/sVuIqhg72/wMg32IXuJ9G+rNmLKsFYOyVfyq61 8yAwPkZ5R/NWxqqbnClGjh+/MZVhh1yGq7q7VEXN24njqW X-Received: by 2002:a17:902:e806:b0:2a7:cbe3:a6e3 with SMTP id d9443c01a7336-2a935bd69a2mr25281315ad.2.1770237489266; Wed, 04 Feb 2026 12:38:09 -0800 (PST) Received: from FAIZEL-KB.. ([2001:569:5999:dc00:876b:c389:85e5:7957]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-2a933974884sm31136955ad.83.2026.02.04.12.38.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Feb 2026 12:38:08 -0800 (PST) From: Faizel K B To: Shuah Khan , Laurent Pinchart , Kieran Bingham , linux-media@vger.kernel.org Cc: Mauro Carvalho Chehab , libcamera-devel@lists.libcamera.org, Faizel K B Subject: [PATCH v3 1/3] media: vimc: sensor: Move vimc_sensor_device to common header Date: Wed, 4 Feb 2026 12:37:24 -0800 Message-ID: <20260204203726.1820226-2-faizel.kb@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260204203726.1820226-1-faizel.kb@gmail.com> References: <20260204203726.1820226-1-faizel.kb@gmail.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Move the vimc_sensor_device structure from vimc-sensor.c to vimc-common.h to make it accessible to the vimc-streamer component. Signed-off-by: Faizel K B --- drivers/media/test-drivers/vimc/vimc-common.h | 28 +++++++++++++++++++ drivers/media/test-drivers/vimc/vimc-sensor.c | 26 ----------------- 2 files changed, 28 insertions(+), 26 deletions(-) diff --git a/drivers/media/test-drivers/vimc/vimc-common.h b/drivers/media/test-drivers/vimc/vimc-common.h index 7a45a2117748..35789add6b4a 100644 --- a/drivers/media/test-drivers/vimc/vimc-common.h +++ b/drivers/media/test-drivers/vimc/vimc-common.h @@ -12,6 +12,8 @@ #include #include #include +#include +#include #define VIMC_PDEV_NAME "vimc" @@ -159,6 +161,32 @@ struct vimc_ent_config { const struct vimc_ent_type *type; }; +enum vimc_sensor_osd_mode { + VIMC_SENSOR_OSD_SHOW_ALL = 0, + VIMC_SENSOR_OSD_SHOW_COUNTERS = 1, + VIMC_SENSOR_OSD_SHOW_NONE = 2 +}; + +struct vimc_sensor_device { + struct vimc_ent_device ved; + struct v4l2_subdev sd; + struct tpg_data tpg; + struct v4l2_ctrl_handler hdl; + struct media_pad pad; + + u8 *frame; + + /* + * Virtual "hardware" configuration, filled when the stream starts or + * when controls are set. + */ + struct { + struct v4l2_area size; + enum vimc_sensor_osd_mode osd_value; + u64 start_stream_ts; + } hw; +}; + /** * vimc_is_source - returns true if the entity has only source pads * diff --git a/drivers/media/test-drivers/vimc/vimc-sensor.c b/drivers/media/test-drivers/vimc/vimc-sensor.c index 027767777763..2b07dc1f1278 100644 --- a/drivers/media/test-drivers/vimc/vimc-sensor.c +++ b/drivers/media/test-drivers/vimc/vimc-sensor.c @@ -14,32 +14,6 @@ #include "vimc-common.h" -enum vimc_sensor_osd_mode { - VIMC_SENSOR_OSD_SHOW_ALL = 0, - VIMC_SENSOR_OSD_SHOW_COUNTERS = 1, - VIMC_SENSOR_OSD_SHOW_NONE = 2 -}; - -struct vimc_sensor_device { - struct vimc_ent_device ved; - struct v4l2_subdev sd; - struct tpg_data tpg; - struct v4l2_ctrl_handler hdl; - struct media_pad pad; - - u8 *frame; - - /* - * Virtual "hardware" configuration, filled when the stream starts or - * when controls are set. - */ - struct { - struct v4l2_area size; - enum vimc_sensor_osd_mode osd_value; - u64 start_stream_ts; - } hw; -}; - static const struct v4l2_mbus_framefmt fmt_default = { .width = 640, .height = 480,