From patchwork Mon Feb 2 19:46:43 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Faizel K B X-Patchwork-Id: 26080 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 65F0CC3226 for ; Mon, 2 Feb 2026 19:47:08 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 146A762001; Mon, 2 Feb 2026 20:47:08 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="BtPJpIS4"; dkim-atps=neutral Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 012E861FF6 for ; Mon, 2 Feb 2026 20:47:06 +0100 (CET) Received: by mail-pg1-x529.google.com with SMTP id 41be03b00d2f7-c634be422b2so304822a12.1 for ; Mon, 02 Feb 2026 11:47:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770061624; x=1770666424; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4RAohPMInpYRdZFPRVpri9RKwD42GbQUWynv/gE4tBc=; b=BtPJpIS4NQpdTjtAo5Gj0WNmOsyuXcWvZis2wV2lmLoaAoPLz+e9iHVLlxPiWJbET2 bp1ik/KYZhNlUmPKw9jXOz+0lQTVjVTTEzxt15kJLJHRsJW+LHjZWJwRN3ZJHxD95we5 yKJSkveseYKPAxCbOufsTCeAL4PBpCHhr437R9It8tDbmJ4+zpMZtU7J/aMy/21wlkSH 8BMBksOymfC7WgBcynznwP21ewJHwiEsjUvkSrnTOpUgIhWpTaXfk/Zj5GwcL2lXnbZZ LSDAL6iXuyAyB3Jzh0BIyQSO3+/oIvVDeQNaEpyQ5poKX0NdJ9JWuLjUjNA0SfYbkIMp zbxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770061624; x=1770666424; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4RAohPMInpYRdZFPRVpri9RKwD42GbQUWynv/gE4tBc=; b=DuPbHi0OKdUKSvOTbt3K1FGe/S/Xpr2yrDBhiWVSVtdoaSJad6iiRBo+qw8x+5Qfi5 gdScYAfywRh5gxvwMJ57wbQtLZJNkybr40GYnLEGztTjbtoX5DGp2lMDRU/SvJz9/kfD ZIlhZWsKZyaJBGndYhVWwWMQXWDmWqExrc9I32UZW9kxmBb+JnbBMu1Cd8kWAfe+yRRn WltCMI+8D/7CBkqHSQY86LLG0xtrp3903sYwIW+pGTLWJUWfdVLx+j/KDp5pdrAb67Y4 4t8EXx+juBqHEUe7MFz+h1Q+74mvwmI+QErjH0mT55eixsGxs3QFSUnD+jmfjlH5mOSu 68yg== X-Forwarded-Encrypted: i=1; AJvYcCVAe2qeow5vTZ9YB/Rf0eVkBM01uOHhTGcC63wM1iOuf9N/E/4w2ep9DbKh1HWa5VTH5yxtRdlj18ZDpLbWuzI=@lists.libcamera.org X-Gm-Message-State: AOJu0YzGFl3iavpgFB8y2dC/zp2RKSvaOjDlcjhUiQqG6u7dBUfE52BF f6gPJ5ihjyV4zZcI7UDQpdvsnqB3k6V33VSphdnrg7418KKZan0bMYeb X-Gm-Gg: AZuq6aK9EsaIC3o7TYjbO+7aRKyY50Ji/cmlSjAgmpaMo2zVJJurq4DF2l4PVKwK/y9 zYQA84LU3a4iOTtnew+B9uSYyA06/n3e769RnS9RejjX0oU0wW9sSpEntMwiIu9smyPcsE3Egpu E7Qq6pCl79KTmMrAhOZnAZyVHXOuUNjaMIO36H9yHyyB6z8GNkfIiba9WCHTL3q0CoWA/xpX9hI v/5jUghcXqylWmhHdjfUMAXv95BbhP3ugHO0Yj2QXQszQ50x+HWToOdiwfZVzKkSwzvHLULlpxs qPQt4E4LeXkPoN7CkSU8FN65fty40n419hHQmpWe6E8SM5AZBywF82XvDGdUUrgZwtE4KG9wB21 ABC5a3fpTG0K/0rXjlK3PZhCfEHSNVYk9Bxvu9fuSCJqQ1AJ8LksltgC6EEffjwUyAS8bCalfpS wxXSd/Z3Z9oKVD+7WfCtv+xUTsIas+tJ8Fj587AYZu/v8= X-Received: by 2002:a05:6a00:3d4e:b0:808:434f:ba80 with SMTP id d2e1a72fcca58-823aa6ef828mr10305790b3a.3.1770061624631; Mon, 02 Feb 2026 11:47:04 -0800 (PST) Received: from FAIZEL-KB.. ([2001:569:5999:dc00:af0:4465:b482:1e01]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-82379b1bc68sm16667416b3a.2.2026.02.02.11.47.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 11:47:04 -0800 (PST) From: Faizel K B To: Shuah Khan , Laurent Pinchart , Kieran Bingham , linux-media@vger.kernel.org Cc: Mauro Carvalho Chehab , libcamera-devel@lists.libcamera.org, Faizel K B Subject: [PATCH v2 1/3] media: vimc: sensor: Move vimc_sensor_device to common header Date: Mon, 2 Feb 2026 11:46:43 -0800 Message-ID: <20260202194645.1287757-2-faizel.kb@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260202194645.1287757-1-faizel.kb@gmail.com> References: <20260202194645.1287757-1-faizel.kb@gmail.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Move the vimc_sensor_device structure from vimc-sensor.c to vimc-common.h to make it accessible to the vimc-streamer component. Signed-off-by: Faizel K B --- drivers/media/test-drivers/vimc/vimc-common.h | 28 +++++++++++++++++++ drivers/media/test-drivers/vimc/vimc-sensor.c | 26 ----------------- 2 files changed, 28 insertions(+), 26 deletions(-) diff --git a/drivers/media/test-drivers/vimc/vimc-common.h b/drivers/media/test-drivers/vimc/vimc-common.h index 7a45a2117748..35789add6b4a 100644 --- a/drivers/media/test-drivers/vimc/vimc-common.h +++ b/drivers/media/test-drivers/vimc/vimc-common.h @@ -12,6 +12,8 @@ #include #include #include +#include +#include #define VIMC_PDEV_NAME "vimc" @@ -159,6 +161,32 @@ struct vimc_ent_config { const struct vimc_ent_type *type; }; +enum vimc_sensor_osd_mode { + VIMC_SENSOR_OSD_SHOW_ALL = 0, + VIMC_SENSOR_OSD_SHOW_COUNTERS = 1, + VIMC_SENSOR_OSD_SHOW_NONE = 2 +}; + +struct vimc_sensor_device { + struct vimc_ent_device ved; + struct v4l2_subdev sd; + struct tpg_data tpg; + struct v4l2_ctrl_handler hdl; + struct media_pad pad; + + u8 *frame; + + /* + * Virtual "hardware" configuration, filled when the stream starts or + * when controls are set. + */ + struct { + struct v4l2_area size; + enum vimc_sensor_osd_mode osd_value; + u64 start_stream_ts; + } hw; +}; + /** * vimc_is_source - returns true if the entity has only source pads * diff --git a/drivers/media/test-drivers/vimc/vimc-sensor.c b/drivers/media/test-drivers/vimc/vimc-sensor.c index 027767777763..2b07dc1f1278 100644 --- a/drivers/media/test-drivers/vimc/vimc-sensor.c +++ b/drivers/media/test-drivers/vimc/vimc-sensor.c @@ -14,32 +14,6 @@ #include "vimc-common.h" -enum vimc_sensor_osd_mode { - VIMC_SENSOR_OSD_SHOW_ALL = 0, - VIMC_SENSOR_OSD_SHOW_COUNTERS = 1, - VIMC_SENSOR_OSD_SHOW_NONE = 2 -}; - -struct vimc_sensor_device { - struct vimc_ent_device ved; - struct v4l2_subdev sd; - struct tpg_data tpg; - struct v4l2_ctrl_handler hdl; - struct media_pad pad; - - u8 *frame; - - /* - * Virtual "hardware" configuration, filled when the stream starts or - * when controls are set. - */ - struct { - struct v4l2_area size; - enum vimc_sensor_osd_mode osd_value; - u64 start_stream_ts; - } hw; -}; - static const struct v4l2_mbus_framefmt fmt_default = { .width = 640, .height = 480,