From patchwork Wed Jan 28 16:26:49 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 26027 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 23D48C3200 for ; Wed, 28 Jan 2026 16:26:54 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 65D0E61FD0; Wed, 28 Jan 2026 17:26:53 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="LfZTvphp"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id BF7D061FC4 for ; Wed, 28 Jan 2026 17:26:51 +0100 (CET) Received: from killaraus.ideasonboard.com (2001-14ba-703d-e500--2a1.rev.dnainternet.fi [IPv6:2001:14ba:703d:e500::2a1]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 768F8E70 for ; Wed, 28 Jan 2026 17:26:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1769617574; bh=KL9Rxa/g40CTGkUb2NJ47B2Ahpmt6xszy4Zg3ycVDj8=; h=From:To:Subject:Date:From; b=LfZTvphpwYqLKhaLH0FGOqIsLlCVcG4EfpIOAJINrj063T+akktiUgi5PUHQdmgB7 3184RgY7rORb5jZ3xzb1q29ked8mKEJShiPfZeMwiNWVrAurCnkCMiycv5qdy4UEh8 B6rgPQDVlhLaZEFZuAN+Sy/tYPcFMZVBFN/p7KzM= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Subject: [PATCH] libcamera: yaml_parser: Fix uninitialized variable warning Date: Wed, 28 Jan 2026 18:26:49 +0200 Message-ID: <20260128162649.3263861-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.52.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" gcc 14.3.0, cross-compiling from amd64 to arm64, warns about a possibly uninitialized variable in YamlObject::Getter<>::get(): In file included from ../../include/libcamera/internal/yaml_parser.h:12, from ../../src/libcamera/yaml_parser.cpp:8: In constructor ‘constexpr std::_Optional_payload_base<_Tp>::_Storage<_Up, >::_Storage(std::in_place_t, _Args&& ...) [with _Args = {unsigned char}; _Up = unsigned char; bool = true; _Tp = unsigned char]’, inlined from ‘constexpr std::_Optional_payload_base<_Tp>::_Optional_payload_base(std::in_place_t, _Args&& ...) [with _Args = {unsigned char}; _Tp = unsigned char]’ at include/c++/14.3.0/optional:122:4, inlined from ‘constexpr std::_Optional_payload::_Optional_payload(std::in_place_t, _Args&& ...) [with _Args = {unsigned char}][inherited from std::_Optional_payload_base]’ at include/c++/14.3.0/optional:337:42, inlined from ‘constexpr std::_Optional_base<_Tp, true, true>::_Optional_base(std::in_place_t, _Args&& ...) [with _Args = {unsigned char}; typename std::enable_if, bool>::type = false; _Tp = unsigned char]’ at include/c++/14.3.0/optional:648:4, inlined from ‘constexpr std::optional<_Tp>::optional(_Up&&) [with _Up = unsigned char; typename std::enable_if<__and_v, typename std::remove_cv::type>::type> >, std::__not_::type>::type> >, std::is_constructible<_T1, _U1>, std::is_convertible<_Iter, _Iterator> >, bool>::type = true; _Tp = unsigned char]’ at include/c++/14.3.0/optional:747:47, inlined from ‘std::optional<_Tp> libcamera::YamlObject::Getter || is_same_v) || is_same_v) || is_same_v) || is_same_v) || is_same_v), void>::type>::get(const libcamera::YamlObject&) const [with T = unsigned char]’ at ../../src/libcamera/yaml_parser.cpp:172:10: include/c++/14.3.0/optional:210:15: error: ‘value’ may be used uninitialized [-Werror=maybe-uninitialized] 210 | : _M_value(std::forward<_Args>(__args)...) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../src/libcamera/yaml_parser.cpp: In member function ‘std::optional<_Tp> libcamera::YamlObject::Getter || is_same_v) || is_same_v) || is_same_v) || is_same_v) || is_same_v), void>::type>::get(const libcamera::YamlObject&) const [with T = unsigned char]’: ../../src/libcamera/yaml_parser.cpp:165:19: note: ‘value’ was declared here 165 | T value; | ^~~~~ This appears to be a false positive, as the std::from_chars() function should set value when it returns without an error. Commit bb1d216113bc ("libcamera: base: log: Fix uninitialized variable warning") fixed a similar warning with gcc 13.3.0. The warning is easy to work around by initializing the variable, and doing so shouldn't be too costly as the type T is restricted to being an integer. Fix the build by doing so. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham Reviewed-by: Barnabás Pőcze --- src/libcamera/yaml_parser.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 186e5cf9ac74cc495384c0af5a055c33a43d9ecc diff --git a/src/libcamera/yaml_parser.cpp b/src/libcamera/yaml_parser.cpp index a5e424615c26..e13b5faedd81 100644 --- a/src/libcamera/yaml_parser.cpp +++ b/src/libcamera/yaml_parser.cpp @@ -162,7 +162,7 @@ struct YamlObject::Getter