From patchwork Wed Jan 28 16:00:31 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Klug X-Patchwork-Id: 26025 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 034BAC3200 for ; Wed, 28 Jan 2026 16:01:07 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id B94AE61FDE; Wed, 28 Jan 2026 17:01:06 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="SnZvPjLj"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A9F9361FD3 for ; Wed, 28 Jan 2026 17:01:05 +0100 (CET) Received: from ideasonboard.com (unknown [IPv6:2a00:6020:448c:6c00:1a60:e70f:ec38:13a9]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id A735D27F9; Wed, 28 Jan 2026 17:00:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1769616028; bh=39NlPgCqW5Nob5gyChWODILLQLQ7MiOEgExqaUFdo7A=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=SnZvPjLjkdYUWNzSWNAcCj+J31YYfOMV4GO5Fg+iY0v/cNGaTZFISatJruuyzD9D3 FokFkX//76bmbqH3XmYrkVTZEaHul71pcBpKFsgTFxUTS5ezN11RQfxPfpli3ftKW4 gHUHU7JO9Gt9baJFkaovOgTxx5hSBG8F4YQ4Nx1Y= From: Stefan Klug Date: Wed, 28 Jan 2026 17:00:31 +0100 Subject: [PATCH v6 14/15] libcamera: control_ids: Introduce LensShadingCorrectionEnable MIME-Version: 1.0 Message-Id: <20260128-sklug-lsc-resampling-v2-dev-v6-14-af7d95f03d22@ideasonboard.com> References: <20260128-sklug-lsc-resampling-v2-dev-v6-0-af7d95f03d22@ideasonboard.com> In-Reply-To: <20260128-sklug-lsc-resampling-v2-dev-v6-0-af7d95f03d22@ideasonboard.com> To: libcamera-devel@lists.libcamera.org Cc: Stefan Klug , Jacopo Mondi , Kieran Bingham , Laurent Pinchart X-Mailer: b4 0.14.2 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Introduce a LensShadingCorrectionEnable control to enable and disable LSC. This is useful to assess the working and quality of the lens shading correction at runtime. While at it drop the reference to the tuning file in the description of the LensDewarpEnable control, as that information doesn't belong to the controls. Signed-off-by: Jacopo Mondi Signed-off-by: Stefan Klug Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- Changes in v6: - Improved the control description - Dropped the reference to the tuning file - Collected tags Changes in v5: - Readd this patch to have a separate patch for the control id - Dropped android specific changes Changes in v2: - Renamed LensShadingEnable to LensShadingCorrectionEnable - Fixed android code to properly handle the boolean value - Added "only if tuned" info sentence to the control description --- src/libcamera/control_ids_core.yaml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml index 8e99bd84825f6060dbc323be3f4b0cd6283e0942..f26a1b1b08bd1684cb76d75ecc32bdb9f8b0f6e5 100644 --- a/src/libcamera/control_ids_core.yaml +++ b/src/libcamera/control_ids_core.yaml @@ -1353,7 +1353,12 @@ controls: type: bool direction: inout description: | - Enable or disable lens dewarping. This control is only available if lens - dewarp parameters are configured in the tuning file. + Enable or disable lens dewarping. + + - LensShadingCorrectionEnable: + type: bool + direction: inout + description: | + Enable or disable the lens shading correction. ...