From patchwork Thu Jan 17 20:20:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 260 Return-Path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id EFC4060CA0 for ; Thu, 17 Jan 2019 21:20:49 +0100 (CET) Received: from localhost.localdomain (cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8E750558; Thu, 17 Jan 2019 21:20:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1547756449; bh=Ovaadbu20ctBxwhPphEykrE8yWk+xYxrxdgU8sbZ7rU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jm2BR1vhUq0n8Qs+eatHeOB4zThjIY4xI5WWmtZCiDD3xhFt4cc+4VaMl71FDCWG0 w3CzHKwSRezXoBXue2+ehRJZyWY7HWj/cTmnbNCehfoptdqMdaE323i9PMmcx1bZTY p0sXd/PCVQxs2rO12K+yUdUXgH9AKmPG7glFnYys= From: Kieran Bingham To: LibCamera Devel Date: Thu, 17 Jan 2019 20:20:42 +0000 Message-Id: <20190117202043.21420-5-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190117202043.21420-1-kieran.bingham@ideasonboard.com> References: <20190117202043.21420-1-kieran.bingham@ideasonboard.com> Subject: [libcamera-devel] [PATCH 4/5] libcamera: log: Fix coding style warnings X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2019 20:20:50 -0000 The checkstyle utility highlights some minor warnings against the logger implementation. Fix these up. Fixes: edbd2059d8a4 ("libcamera: Add initial logger") Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart Reviewed-by: Niklas Söderlund --- src/libcamera/include/log.h | 6 +++--- src/libcamera/log.cpp | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/libcamera/include/log.h b/src/libcamera/include/log.h index c1af3741ffee..cc3f9404a3d4 100644 --- a/src/libcamera/include/log.h +++ b/src/libcamera/include/log.h @@ -23,11 +23,11 @@ class LogMessage { public: LogMessage(const char *fileName, unsigned int line, - LogSeverity severity); - LogMessage(const LogMessage&) = delete; + LogSeverity severity); + LogMessage(const LogMessage &) = delete; ~LogMessage(); - std::ostream& stream() { return msgStream; } + std::ostream &stream() { return msgStream; } private: std::ostringstream msgStream; diff --git a/src/libcamera/log.cpp b/src/libcamera/log.cpp index 9b2ae1bac8c8..74cba383363d 100644 --- a/src/libcamera/log.cpp +++ b/src/libcamera/log.cpp @@ -66,7 +66,7 @@ namespace libcamera { static const char *log_severity_name(LogSeverity severity) { - static const char * const names[] = { + static const char *const names[] = { " DBG", " INFO", " WARN",