From patchwork Mon Jan 26 10:42:49 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rick ten Wolde X-Patchwork-Id: 25959 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 7F892C3200 for ; Mon, 26 Jan 2026 10:48:11 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id A981F61FD8; Mon, 26 Jan 2026 11:48:08 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Zkw4eQyb"; dkim-atps=neutral Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7874061A35 for ; Mon, 26 Jan 2026 11:43:03 +0100 (CET) Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-b87f00ec06aso696167566b.1 for ; Mon, 26 Jan 2026 02:43:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769424183; x=1770028983; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mgB6MrQvgMJiEZfORtJ9tLgqcmb2wkUK6G66JSN6xHI=; b=Zkw4eQyb6/gDvQVp3jzEIdfOTphTZSU2CQfgZeMfRNDAukKxtCeXNCocbfOwczlgla aP/vVb/TVv+K+Gdr35U+ZTajj5oNkWXCD/2cglf9Chkeim+9+l9L1RFNK2Jno1+8wSY/ YvJWIs5bSt05s0Cpei6K8VlYH9/4X9G8H+uitNmXf3j6lZIVNAVYBqz0HX48qs/89h6x sqN750KpCxY8ejh49TRuExasE6iv9Fh4j6my/y1pEYYJV/AHdtWq7M06KiyXw18eV9ge L5hBiX47QIBjMzIEqk+ib2GUyzzswUbzwj4ujj4LqUpT7idf0WRmZGIe8cyOtZyNBqjc 20JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769424183; x=1770028983; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=mgB6MrQvgMJiEZfORtJ9tLgqcmb2wkUK6G66JSN6xHI=; b=hspEaiDDJE928uHEYyoxtWfLbDxj+ZKVebzAKFd+4RzRGN12VkYPdYZiWlNZjmAVRF Ud4V+CaA9vC+DHMntIx9eQIlB3rlHRQRr+SYKoWi3h0Thq/KTT0wxctBCuPEZAqxMpKO 4FsSvIV7QV3ORba1SDTyuBZPhebAJYboFdL8K+OYPKnRbW2gcBzwehdQpNlF+vnrp0o6 UJimX4ShY6VJWQutJ2Tgmo4HIbbApLNCiI/22isW9lOFCaQxQV7iO2nnDTAfHo6+Opnw mbi9RUz8TzH8UKHzlG2m5Np2d6/xHdE4BtifUXiYki78WKeDzw7JVqxwR5J7TNTJvZum Nkvg== X-Gm-Message-State: AOJu0Yw7cr93L7JW17zhV5WwC3ngS0PzSXktfw5Qmq7p4gIBN5vtOrP5 RHdwL9UItLTIhcpZzPx3VFMk0kOTXVx5KXLUoeeJT6hSCv1pKxnLM3D+UozgnQ== X-Gm-Gg: AZuq6aKAlmYbyaR7Iz98HHlTpfFaAOzQl1SooWekUqz/F5/fH6jZdpB4YcA6OD1xDhK T87m6PqaqBxG5z/0lfaThMRERF1St7Y11JQHFBgrRmSP335pXxSvOWuuK45Nevxl2V/SQR3WVbP jfHU8Ff/oFi/WHehrWwGIi5M2T+MMtJ3ZUtsy9dD7cREdlMDSLaorz+hcT4LT7ClqhOLgYRIiFq SfW6tzr93SdRjk4V4ywt+/+ZtUC3nrocDw7/FuPDqOp9pMWzdLOMgwmVpvi6G1Pyl5B+N6V55G+ daxA7a+rd/bY676m1R1Cm93808+5hEeJj8EYW6SztGtB4aC7rAN0alSXvmcyd1bYpWozK+HV4h/ Pelw9JJHVu6rdmnHEHgCmTrd9TvJxkvfW3lnxv/FJhCBECWNjEGnSifE0z83gkYqBssdM83Tzrv L+UIm4jJM2oDK0h3oxlTaTMzaf5scMVKaEboBJWVyy1N+LQ954bjyUZToQxxUIvQb2ZwEJViz5i Q== X-Received: by 2002:a17:907:1b18:b0:b80:4103:537e with SMTP id a640c23a62f3a-b8d2e89cfe6mr286424366b.53.1769424182505; Mon, 26 Jan 2026 02:43:02 -0800 (PST) Received: from castortop.wolde.loc (195-240-110-192.fixed.kpn.net. [195.240.110.192]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b885b7661f7sm599220366b.54.2026.01.26.02.43.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jan 2026 02:43:02 -0800 (PST) From: Rick ten Wolde To: libcamera-devel@lists.libcamera.org Cc: xander.c.pronk@gmail.com, derekgielen@outlook.com, 22012540@student.hhs.nl, rick.w.ten.wolde@gmail.com, johannes.goede@oss.qualcomm.com, Rick ten Wolde Subject: [PATCH 1/7] libcamera: software_isp: egl: Add gl_scale_param to createTexture2D() Date: Mon, 26 Jan 2026 11:42:49 +0100 Message-ID: <20260126104256.119697-2-rick.w.ten.wolde@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260126104256.119697-1-rick.w.ten.wolde@gmail.com> References: <20260126104256.119697-1-rick.w.ten.wolde@gmail.com> MIME-Version: 1.0 X-Mailman-Approved-At: Mon, 26 Jan 2026 11:48:05 +0100 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Xander Pronk Add a gl_scale_param to createTexture2D() to allow overriding the currently hardcoded GL_NEAREST value. Co-authored-by: Rick ten Wolde Signed-off-by: Rick ten Wolde Signed-off-by: Xander Pronk --- include/libcamera/internal/egl.h | 2 +- src/libcamera/egl.cpp | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h index a9292112..9c0504fb 100644 --- a/include/libcamera/internal/egl.h +++ b/include/libcamera/internal/egl.h @@ -113,7 +113,7 @@ public: int createInputDMABufTexture2D(eGLImage &eglImage, int fd); int createOutputDMABufTexture2D(eGLImage &eglImage, int fd); void destroyDMABufTexture(eGLImage &eglImage); - void createTexture2D(eGLImage &eglImage, GLint format, uint32_t width, uint32_t height, void *data); + void createTexture2D(eGLImage &eglImage, GLint format, uint32_t width, uint32_t height, void *data, GLint gl_scale_param=GL_NEAREST); void pushEnv(std::vector &shaderEnv, const char *str); void makeCurrent(); diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp index 0544056b..3565bfd3 100644 --- a/src/libcamera/egl.cpp +++ b/src/libcamera/egl.cpp @@ -229,13 +229,14 @@ void eGL::destroyDMABufTexture(eGLImage &eglImage) * \param[in] width Texture width in pixels * \param[in] height Texture height in pixels * \param[in] data Pointer to pixel data, or nullptr for uninitialised texture + * \param[in] gl_scale_param GL texture filter setting * * Creates a 2D texture from a CPU-accessible memory buffer. The texture * is configured with nearest filtering and clamp-to-edge wrapping. This * is useful for uploading static data like lookup tables or uniform color * matrices to the GPU. */ -void eGL::createTexture2D(eGLImage &eglImage, GLint format, uint32_t width, uint32_t height, void *data) +void eGL::createTexture2D(eGLImage &eglImage, GLint format, uint32_t width, uint32_t height, void *data, GLint gl_scale_param) { ASSERT(tid_ == Thread::currentId()); @@ -246,8 +247,8 @@ void eGL::createTexture2D(eGLImage &eglImage, GLint format, uint32_t width, uint glTexImage2D(GL_TEXTURE_2D, 0, format, width, height, 0, format, GL_UNSIGNED_BYTE, data); // Nearest filtering - glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_NEAREST); - glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_NEAREST); + glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, gl_scale_param); + glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, gl_scale_param); // Wrap to edge to avoid edge artifacts glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP_TO_EDGE);