From patchwork Mon Jan 26 08:57:47 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 25957 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id B8FFAC328D for ; Mon, 26 Jan 2026 08:57:55 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7F8C661FC4; Mon, 26 Jan 2026 09:57:54 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="s+Xo2ZH1"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 925F961FBB for ; Mon, 26 Jan 2026 09:57:51 +0100 (CET) Received: from pb-laptop.local (185.221.142.123.nat.pool.zt.hu [185.221.142.123]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2289463F for ; Mon, 26 Jan 2026 09:57:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1769417836; bh=W4oVy3iCc+iAM/HHT00BybWKNhl4Llj46VS7s5yEMVo=; h=From:To:Subject:Date:In-Reply-To:References:From; b=s+Xo2ZH17kRFxZjdVh0HAbqfg7h7Ewzx+kv32cD5wElXpbQRLtjlII2gP5wEa1sLt joEoo7tz+uKShwdSelBj9zZ5fWwTceS3Vrzp0zj6MUxGhJk8iG9ujM3cH0lHoiLMOv Gmoxtcs3/pNzTAgsYWAn4QHnIYiTARi/QM7AlETU= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [libcamera-ci] [PATCH v2 2/2] Update virtme-ng to 1.40 Date: Mon, 26 Jan 2026 09:57:47 +0100 Message-ID: <20260126085747.36043-2-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260126085747.36043-1-barnabas.pocze@ideasonboard.com> References: <20260126085747.36043-1-barnabas.pocze@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This enables the removal of the exit code workaround since the exit code is now propagated to the host[0]. However, the single argument `--rwdir` does not work as it did in 1.18, and the `=` form must be used otherwise virtme-ng refuses to start[1]: error: cannot initialize inside the guest (path must be defined inside a valid overlay) And moreover, since virtme-ng now creates an overlay for `/tmp` by default[2], and some tests require a /tmp with `O_TMPFILE` support, `/tmp` needs to be mounted as tmpfs before running the tests. [0]: https://github.com/arighi/virtme-ng/pull/61 [1]: https://github.com/arighi/virtme-ng/issues/409 [2]: https://github.com/arighi/virtme-ng/pull/114 Signed-off-by: Barnabás Pőcze --- changes in v2: * move virtme-ng update to a separate commit * use `--rwdir x=x` instead of `--overlay-rwdir` * I created and referenced https://github.com/arighi/virtme-ng/issues/409 because I don't really understand why the 1.18 behaviour was changed v1: https://patchwork.libcamera.org/patch/25942/ --- .gitlab-ci/test-lc-compliance.sh | 6 ++---- .gitlab-ci/test-libcamera-qemu.sh | 11 +++++++---- gitlab-ci.yml | 2 +- 3 files changed, 10 insertions(+), 9 deletions(-) -- 2.52.0 diff --git a/.gitlab-ci/test-lc-compliance.sh b/.gitlab-ci/test-lc-compliance.sh index 6208723..a888cae 100755 --- a/.gitlab-ci/test-lc-compliance.sh +++ b/.gitlab-ci/test-lc-compliance.sh @@ -14,7 +14,7 @@ libcamera_compliance() { --verbose \ --skip-modules \ --force-9p \ - --rwdir "$PWD/build" \ + --rwdir "$PWD/build=$PWD/build" \ --run /opt/linux/bzImage \ --exec " \ set -x; \ @@ -25,12 +25,10 @@ libcamera_compliance() { UBSAN_OPTIONS=halt_on_error=1:abort_on_error=1:print_summary=1:print_stacktrace=1 \ GTEST_OUTPUT=xml:./build/lc-compliance-report.xml \ lc-compliance -c Virtual0; \ - echo \\\$? > ./build/.test-status; \ " - local status=$(cat build/.test-status) + local status=$? echo "Test result exit state: $status" - rm build/.test-status if [[ $status != 0 ]] ; then exit $status diff --git a/.gitlab-ci/test-libcamera-qemu.sh b/.gitlab-ci/test-libcamera-qemu.sh index f9de5ab..03d39d3 100755 --- a/.gitlab-ci/test-libcamera-qemu.sh +++ b/.gitlab-ci/test-libcamera-qemu.sh @@ -24,13 +24,16 @@ libcamera_unit_test() { echo "Running libcamera tests in a qemu VM" virtme-ng --verbose --skip-modules --force-9p \ - --rwdir "$PWD/build" \ + --rwdir "$PWD/build=$PWD/build" \ --run /opt/linux/bzImage \ - --exec "meson test -C build --no-rebuild --print-errorlogs; echo \\\$? > build/.test-status" + --exec " \ + set -ex; \ + mount -t tmpfs tmpfs /tmp/; \ + meson test -C build --no-rebuild --print-errorlogs; \ + " - local status=$(cat build/.test-status) + local status=$? echo "Test result exit state: $status" - rm build/.test-status if [[ $status != 0 ]] ; then exit $status diff --git a/gitlab-ci.yml b/gitlab-ci.yml index bd5df66..3f80cb8 100644 --- a/gitlab-ci.yml +++ b/gitlab-ci.yml @@ -34,7 +34,7 @@ variables: ca-certificates git VIRTME_GIT_URL: 'https://github.com/arighi/virtme-ng.git' - VIRTME_GIT_REF: 'v1.18' + VIRTME_GIT_REF: 'v1.40' # Jobs that test individual commits need more history to find the common # ancestor of the branch being tested and the default branch. Fetch up to 100