From patchwork Wed Jan 21 09:07:05 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 25902 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 88F1EBDCBF for ; Wed, 21 Jan 2026 09:06:31 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 4887C61FD3; Wed, 21 Jan 2026 10:06:30 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=igalia.com header.i=@igalia.com header.b="QKOm0lZI"; dkim-atps=neutral Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 0BB2B61FCF for ; Wed, 21 Jan 2026 10:06:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=rqYmOETbgScdIWiBErDSx0hw8farFh8j8WEQ0XQEQLc=; b=QKOm0lZI5diqCRbxAdO62oWTMr FPrzR6eeOaBD572VQpL3Ewts4THU6mo7GjNTz1nb5wcCGAsbGxatHtkMAkjf6ShyItjEmJNxIG2xx VApreIMvXauRvMz5PTGH1UW/jWIZTr46/PBm2oH8vvfATTzS9SFjd9ZWtWBI10XdQJcMEbxTHp0+A kr7BfCrfm/okkR8AGeac/Eng8wJWOQJpuwZbKbHjsRtEqH1b+2eqtRW/v66PpFeEmqq19EjVai3+G 78a0EvtB2Y0gu1TwxJEu8r2gbPAmJjCM/bdv/ZiY9srepAyjFVbxpMkpeMZ9HYfmrRV2MAFkXrVtv TDSHl1NQ==; Received: from [49.36.125.126] (helo=uajain) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1viUAT-007xDQ-0A; Wed, 21 Jan 2026 10:06:25 +0100 From: Umang Jain To: libcamera-devel@lists.libcamera.org Cc: Umang Jain Subject: [PATCH 3/3] pipeline: virtual: Rectify validation of colorspace Date: Wed, 21 Jan 2026 14:37:05 +0530 Message-ID: <20260121090705.274081-4-uajain@igalia.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260121090705.274081-1-uajain@igalia.com> References: <20260121090705.274081-1-uajain@igalia.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Now that each frame generator class supports the colorspace information using the colorspace() getter, use that to validate (or set) the colorspace of a particular stream configuration instead of a incorrect hard-coded one. Fixes: 5d2d005306ad ("pipeline: virtual: Provide and validate colorspace") Signed-off-by: Umang Jain Reviewed-by: Barnabás Pőcze --- src/libcamera/pipeline/virtual/virtual.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/libcamera/pipeline/virtual/virtual.cpp b/src/libcamera/pipeline/virtual/virtual.cpp index 40c35264..3d205a6c 100644 --- a/src/libcamera/pipeline/virtual/virtual.cpp +++ b/src/libcamera/pipeline/virtual/virtual.cpp @@ -185,7 +185,7 @@ CameraConfiguration::Status VirtualCameraConfiguration::validate() status = Adjusted; } - for (StreamConfiguration &cfg : config_) { + for (auto [i, cfg] : utils::enumerate(config_)) { bool adjusted = false; bool found = false; for (const auto &resolution : data_->config_.resolutions) { @@ -214,8 +214,9 @@ CameraConfiguration::Status VirtualCameraConfiguration::validate() adjusted = true; } - if (cfg.colorSpace != ColorSpace::Rec709) { - cfg.colorSpace = ColorSpace::Rec709; + const ColorSpace colorspace = data_->streamConfigs_[i].frameGenerator->colorspace(); + if (cfg.colorSpace != colorspace) { + cfg.colorSpace = colorspace; status = Adjusted; adjusted = true; } @@ -289,7 +290,6 @@ PipelineHandlerVirtual::generateConfiguration(Camera *camera, cfg.pixelFormat = pixelFormat; cfg.size = data->config_.maxResolutionSize; cfg.bufferCount = VirtualCameraConfiguration::kBufferCount; - cfg.colorSpace = ColorSpace::Rec709; config->addConfiguration(cfg); }