From patchwork Thu Jan 15 11:16:29 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= X-Patchwork-Id: 25814 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 78C33BDCBF for ; Thu, 15 Jan 2026 11:16:38 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 60F1B61FC6; Thu, 15 Jan 2026 12:16:36 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="A1H+zMzH"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 23ABA61FA3 for ; Thu, 15 Jan 2026 12:16:33 +0100 (CET) Received: from pb-laptop.local (185.221.143.114.nat.pool.zt.hu [185.221.143.114]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id AA13A766 for ; Thu, 15 Jan 2026 12:16:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1768475765; bh=YWISlLfLzrI0iP3LF4n9GCMmntpC4NRHoH7kPM9FUGI=; h=From:To:Subject:Date:In-Reply-To:References:From; b=A1H+zMzHdZE2IRRQ/gWPgNDDXp4In1gafATvE0sZUAJj4NUXq+vzvf1MaB+4yWvAC 1EZq8Wmkq0W9KwbQsUIL8+lYSDErolnpk0OiFCvCqSbrPJRsOAfEwtf9foNsjlKN5C N31ilOtC92w9Xt0qddOekuPoawMgfxKhHIo+etGw= From: =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= To: libcamera-devel@lists.libcamera.org Subject: [PATCH v1 2/3] ipa: rpi: Fix printing of `utils::Duration` Date: Thu, 15 Jan 2026 12:16:29 +0100 Message-ID: <20260115111630.1892890-2-barnabas.pocze@ideasonboard.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260115111630.1892890-1-barnabas.pocze@ideasonboard.com> References: <20260115111630.1892890-1-barnabas.pocze@ideasonboard.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" `utils::Duration` derives from `std::chrono::duration<...>`, but multiplying it yields an `std::chrono::duration<...>`, not `Duration`. chrono duration types only have `operator<<` in C++20 or later, so this usage should not compile. It only did so because the `operator<<` for `Duration` was in the `libcamera` namespace and `Duration` has an implicit constructor from any chrono duration type. This will cease to work when that operator is moved into the `utils` namespace for ADL purposes. So fix it by making the cast to `Duration` explicit. Signed-off-by: Barnabás Pőcze --- src/ipa/rpi/common/ipa_base.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp index 14aba4500..f95a0f838 100644 --- a/src/ipa/rpi/common/ipa_base.cpp +++ b/src/ipa/rpi/common/ipa_base.cpp @@ -602,7 +602,7 @@ void IpaBase::setMode(const IPACameraSensorInfo &sensorInfo) mode_.minLineLength = adjustedLineLength; } else { LOG(IPARPI, Error) - << "Sensor minimum line length of " << pixelTime * mode_.width + << "Sensor minimum line length of " << Duration(pixelTime * mode_.width) << " (" << 1us / pixelTime << " MPix/s)" << " is below the minimum allowable ISP limit of " << adjustedLineLength