From patchwork Mon Jan 12 10:37:39 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Robert Mader X-Patchwork-Id: 25718 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id ACAE4C323E for ; Mon, 12 Jan 2026 10:38:19 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 4BEE961FC4; Mon, 12 Jan 2026 11:38:19 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=collabora.com header.i=robert.mader@collabora.com header.b="Eprugc54"; dkim-atps=neutral Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 1E7B761FBE for ; Mon, 12 Jan 2026 11:38:16 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; t=1768214293; cv=none; d=zohomail.com; s=zohoarc; b=fd/Z/OEi7HzpJETXO2xo+TDzpKHceHJ5swDY7kV2dG+DMcHN65rxVHA8CD4zUO0TGlLzvcHII0fL+bjg5754t/Rh46PFizixJJ+6yn/wP3LxXhswlHs+tmJj9pTWUdyLudCBZUIJAPcWr2SGdCGH3aHvSYUV7B/IgqmkCUIdARU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768214293; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=M0yxTdv3AR3OUpRuELbtNefryxLkD/pC0IsO5BPWkLk=; b=EajBegscG+xNI2FXrkuPcbgN3Em68YCVcIbeSbMY0drJlN0sm+RupbYWZzNLfsh47nGlAf2Jk2s/c9jMPSHJqwCGgWmsrz6Iewjyh2X9OZ+DBhFJGUxKkkPpktVSNCQ9c0mxXOCRdFAv9gQlu5TsSCNEsPdAKEk+AGHCr7DVcQA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=robert.mader@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1768214293; s=zohomail; d=collabora.com; i=robert.mader@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To; bh=M0yxTdv3AR3OUpRuELbtNefryxLkD/pC0IsO5BPWkLk=; b=Eprugc54gtkm0RUFe7IOjLIigoUJR3avwxIOkYlrkKSublo/MonjVrG+3dyjnlwk LJ/c3CrbbcdiG4e61RwK9/9Bbtz781QXQEuShOhuF+37OGYhLOKgMCkl1D3EkcssB+z l7WTNudhJ0D3mSMrRbWS+HUOBQwTAm+8+RqOMk6s= Received: by mx.zohomail.com with SMTPS id 176821429312935.5066968926659; Mon, 12 Jan 2026 02:38:13 -0800 (PST) From: Robert Mader To: libcamera-devel@lists.libcamera.org Cc: Robert Mader Subject: [PATCH v2 3/4] egl: Remove duplicated logging of EGL version Date: Mon, 12 Jan 2026 11:37:39 +0100 Message-ID: <20260112103740.18360-4-robert.mader@collabora.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260112103740.18360-1-robert.mader@collabora.com> References: <20260112103740.18360-1-robert.mader@collabora.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The line below already prints it. Signed-off-by: Robert Mader Reviewed-by: Barnabás Pőcze Reviewed-by: Kieran Bingham Reviewed-by: Kieran Bingham Reviewed-by: Bryan O'Donoghue --- src/libcamera/egl.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp index fcaf7c58f..a88525279 100644 --- a/src/libcamera/egl.cpp +++ b/src/libcamera/egl.cpp @@ -285,8 +285,6 @@ int eGL::initEGLContext(GBM *gbmContext) EGLint numConfigs; EGLConfig config; - EGLint major; - EGLint minor; if (!eglBindAPI(EGL_OPENGL_ES_API)) { LOG(eGL, Error) << "API bind fail"; @@ -299,12 +297,11 @@ int eGL::initEGLContext(GBM *gbmContext) goto fail; } - if (eglInitialize(display_, &major, &minor) != EGL_TRUE) { + if (eglInitialize(display_, nullptr, nullptr) != EGL_TRUE) { LOG(eGL, Error) << "eglInitialize fail"; goto fail; } - LOG(eGL, Info) << "EGL: version " << major << "." << minor; LOG(eGL, Info) << "EGL: EGL_VERSION: " << eglQueryString(display_, EGL_VERSION); LOG(eGL, Info) << "EGL: EGL_VENDOR: " << eglQueryString(display_, EGL_VENDOR); LOG(eGL, Info) << "EGL: EGL_CLIENT_APIS: " << eglQueryString(display_, EGL_CLIENT_APIS);