From patchwork Mon Jan 12 10:37:38 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Mader X-Patchwork-Id: 25717 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 02266BE08B for ; Mon, 12 Jan 2026 10:38:18 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id B6EC861FC0; Mon, 12 Jan 2026 11:38:18 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=collabora.com header.i=robert.mader@collabora.com header.b="Y1kW852y"; dkim-atps=neutral Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 635A461FBE for ; Mon, 12 Jan 2026 11:38:16 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; t=1768214293; cv=none; d=zohomail.com; s=zohoarc; b=Jz0rnxXFabxJsO92Hnjll6ZioteBMDfQq4Ey7oWvU3H+6ZMU3nJrjxVg08EgBSRMekt0PmWQzUsyP/VDMObuiFCs3m6wiiICXiu3igPJWUoiYCt0JmNFJbFg22BxKV2TKue04VN0c5dhTopRus68De5BwaUWdyBqHIo4jehgAek= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768214293; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=j0dL+Sw7ngrHqKTsS1Igtoix9MzkwJDzje+T1BxJAmc=; b=DWsZrZrM8MCC/wy3qsuEy+z2r+Ccb5oLoxb1NdOb4rStwgQIrw8DvDhH0gG52Rh97kizCdInDXylNSDHmwa1OyldWCoJS9SVg/jfo4jaBxd7lujWvQtY2JQY44thhQm3uAOPH9d+KYG6nERqqBhZHNj9u4aBZrCm3IKaOg48NgM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=robert.mader@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1768214293; s=zohomail; d=collabora.com; i=robert.mader@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To; bh=j0dL+Sw7ngrHqKTsS1Igtoix9MzkwJDzje+T1BxJAmc=; b=Y1kW852ytbs3Djk/T69/DuS/mja7+Iy/3YLIhtoMo+wJ2M01qN6SqfXYDnZY8ZfF Bn1j3c9IeTmVzgbTNnn8pi6y71cXG/Q9V4K9aohhjL2ZQ6gEzqOTJahSHEba8OGzqqy oMjp1Acxajxilo87vi8aER7ICF0tOHslj+Xpxcgo= Received: by mx.zohomail.com with SMTPS id 1768214291086141.38652604087088; Mon, 12 Jan 2026 02:38:11 -0800 (PST) From: Robert Mader To: libcamera-devel@lists.libcamera.org Cc: Robert Mader , Hans de Goede Subject: [PATCH v2 2/4] egl: Remove bpp variable Date: Mon, 12 Jan 2026 11:37:38 +0100 Message-ID: <20260112103740.18360-3-robert.mader@collabora.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260112103740.18360-1-robert.mader@collabora.com> References: <20260112103740.18360-1-robert.mader@collabora.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" It's unused and, in one case, was set wrongly. Signed-off-by: Robert Mader Reviewed-by: Hans de Goede Reviewed-by: Kieran Bingham Reviewed-by: Bryan O'Donoghue --- include/libcamera/internal/egl.h | 6 ++---- src/libcamera/software_isp/debayer_egl.cpp | 4 ++-- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h index 7b810773c..21e2aa9df 100644 --- a/include/libcamera/internal/egl.h +++ b/include/libcamera/internal/egl.h @@ -49,14 +49,13 @@ public: * \brief Construct an eGLImage with explicit stride * \param[in] width Image width in pixels * \param[in] height Image height in pixels - * \param[in] bpp Bytes per pixel * \param[in] stride Row stride in bytes * \param[in] texture_unit OpenGL texture unit * \param[in] texture_unit_uniform_id Shader uniform ID */ - eGLImage(uint32_t width, uint32_t height, uint32_t bpp, uint32_t stride, GLenum texture_unit, uint32_t texture_unit_uniform_id) + eGLImage(uint32_t width, uint32_t height, uint32_t stride, GLenum texture_unit, uint32_t texture_unit_uniform_id) : width_(width), height_(height), stride_(stride), - framesize_(stride * height), bpp_(bpp), + framesize_(stride * height), texture_unit_uniform_id_(texture_unit_uniform_id), texture_unit_(texture_unit) { @@ -81,7 +80,6 @@ public: uint32_t stride_; /**< Row stride in bytes */ uint32_t offset_; /**< Buffer offset (reserved for future use) */ uint32_t framesize_; /**< Total frame size in bytes (stride * height) */ - uint32_t bpp_; /**< Bytes per pixel */ uint32_t texture_unit_uniform_id_; /**< Shader uniform id for texture unit */ GLenum texture_unit_; /**< Texture unit associated with this image eg (GL_TEXTURE0) */ GLuint texture_; /**< OpenGL texture object ID */ diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp index 1c13b72a5..9693d7252 100644 --- a/src/libcamera/software_isp/debayer_egl.cpp +++ b/src/libcamera/software_isp/debayer_egl.cpp @@ -597,10 +597,10 @@ int DebayerEGL::start() LOG(Debayer, Debug) << "Available fragment shader texture units " << maxTextureImageUnits; /* Raw bayer input as texture */ - eglImageBayerIn_ = std::make_unique(width_, height_, 32, inputConfig_.stride, GL_TEXTURE0, 0); + eglImageBayerIn_ = std::make_unique(width_, height_, inputConfig_.stride, GL_TEXTURE0, 0); /* Texture we will render to */ - eglImageBayerOut_ = std::make_unique(outputSize_.width, outputSize_.height, 31, outputConfig_.stride, GL_TEXTURE1, 1); + eglImageBayerOut_ = std::make_unique(outputSize_.width, outputSize_.height, outputConfig_.stride, GL_TEXTURE1, 1); if (initBayerShaders(inputPixelFormat_, outputPixelFormat_)) return -EINVAL;