From patchwork Mon Jan 12 10:37:37 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Robert Mader X-Patchwork-Id: 25716 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 8997BBE08B for ; Mon, 12 Jan 2026 10:38:15 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 3E39961F9F; Mon, 12 Jan 2026 11:38:15 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=collabora.com header.i=robert.mader@collabora.com header.b="bnDdxcYE"; dkim-atps=neutral Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 4605661FB9 for ; Mon, 12 Jan 2026 11:38:13 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; t=1768214289; cv=none; d=zohomail.com; s=zohoarc; b=YmOUmBlGGquCYLpFlggSFVzI3tJxfLcmse7Mwr3DwU9/tp9WfF1MBmggID/RnfxMb+7tvWre82jHTFgI+90SNN8krTh4g2EdIEFrs2L8ldsjJ9vWeKRE99ToN6N4YLyqiJK+O68PHZud3wqjZlmbfnKtqWeP1XglW/7d10UIETU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768214289; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=BwS+eZTULx2YfKTG/rTEgrLDyh8KbB652xIKkKPgweE=; b=VMMsP/ZoGO3JlFaafG9bJprJQRvYs2iTrXdDLWxFPzoMp7aEFljsybDe7n29uIZnocQXHris0bpGGdg1mNH5izCkmWVAByWYzCl1/PiGIjStJl9u2XrM4cUMX+Almsn7VFlYMd50664sgZmMbtH4EMNDBDm3HcQ+i30iTr/3dN8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=robert.mader@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1768214289; s=zohomail; d=collabora.com; i=robert.mader@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=BwS+eZTULx2YfKTG/rTEgrLDyh8KbB652xIKkKPgweE=; b=bnDdxcYEag1r0S3ka9UVWtpcKRVsJkB5FS6ktm43EXEks/ZHeiFskFq4Nrq94JsK SJ+VmSKcDdrRlFx2aN3McW2j0ba/kHNir7qhEs+lNTpuVACKFiZEGYqSrRBhWPIlY4W sd0LF6aKyURkov4thQ3D3eKwjqOWERDlWZ3HaoV4= Received: by mx.zohomail.com with SMTPS id 1768214288630581.9036033215984; Mon, 12 Jan 2026 02:38:08 -0800 (PST) From: Robert Mader To: libcamera-devel@lists.libcamera.org Cc: Robert Mader , Hans de Goede , =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= Subject: [PATCH v2 1/4] egl: Remove unused functions Date: Mon, 12 Jan 2026 11:37:37 +0100 Message-ID: <20260112103740.18360-2-robert.mader@collabora.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260112103740.18360-1-robert.mader@collabora.com> References: <20260112103740.18360-1-robert.mader@collabora.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" They are left-overs from older iterations of the GPU-ISP. Signed-off-by: Robert Mader Reviewed-by: Hans de Goede Reviewed-by: Barnabás Pőcze Reviewed-by: Bryan O'Donoghue --- include/libcamera/internal/egl.h | 10 ---------- src/libcamera/egl.cpp | 10 ---------- src/libcamera/software_isp/debayer_egl.cpp | 2 -- 3 files changed, 22 deletions(-) diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h index a92921123..7b810773c 100644 --- a/include/libcamera/internal/egl.h +++ b/include/libcamera/internal/egl.h @@ -64,15 +64,6 @@ public: glGenFramebuffers(1, &fbo_); } - /** - * \brief Construct an eGLImage with automatic stride calculation - */ - eGLImage(uint32_t width, uint32_t height, uint32_t bpp, GLenum texture_unit, uint32_t texture_unit_uniform_id) - : eGLImage(width, height, bpp, utils::alignUp(width * bpp / 8, 256), - texture_unit, texture_unit_uniform_id) - { - } - /** * \brief Destroy the eGLImage * @@ -108,7 +99,6 @@ public: ~eGL(); int initEGLContext(GBM *gbmContext); - void cleanUp(); int createInputDMABufTexture2D(eGLImage &eglImage, int fd); int createOutputDMABufTexture2D(eGLImage &eglImage, int fd); diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp index 0544056bd..fcaf7c58f 100644 --- a/src/libcamera/egl.cpp +++ b/src/libcamera/egl.cpp @@ -349,16 +349,6 @@ fail: return -ENODEV; } -/** - * \brief Clean up EGL resources - * - * Destroys the EGL sync object. Must be called from the same thread - * that created the EGL context. - */ -void eGL::cleanUp() -{ -} - /** * \brief Make the EGL context current for the calling thread * diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp index 8e0890323..1c13b72a5 100644 --- a/src/libcamera/software_isp/debayer_egl.cpp +++ b/src/libcamera/software_isp/debayer_egl.cpp @@ -615,8 +615,6 @@ void DebayerEGL::stop() if (programId_) glDeleteProgram(programId_); - - egl_.cleanUp(); } SizeRange DebayerEGL::sizes(PixelFormat inputFormat, const Size &inputSize)