From patchwork Sat Jan 10 17:09:24 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Mader X-Patchwork-Id: 25707 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 97B05BE08B for ; Sat, 10 Jan 2026 17:10:20 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 4EA6A61FA0; Sat, 10 Jan 2026 18:10:20 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=collabora.com header.i=robert.mader@collabora.com header.b="FMouCjkq"; dkim-atps=neutral Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E25D861A35 for ; Sat, 10 Jan 2026 18:10:18 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; t=1768065015; cv=none; d=zohomail.com; s=zohoarc; b=DpRfOWe6RzJofbBK7AgnEtZoyUW4u22s+GX27fY04afCy9hgK5H0Ce4c3xkg5qCuu/3vW1rb0vu/F7P3cX7ROa7xIrJthxZy7gnPGg+ZiBdBLoFBWeBNUshbxvIWjFFyhaiZHSkH/21jkwqJ2l6T4ZHwss0g6c5MZODbTj7xNUs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1768065015; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=bFFrq++5ofhqy9jPSw2PTaF8NtQ+WlvlI5/s/WvKYVw=; b=hHBiLut7Ok5k5o6p7V7RryuibA1vxIUgok5icLzGhHRP1NYSEShb4r+U5WMNhNNzWENl/thQsv782WzAqJNbbV06EgbcV+WO33gYFpl2ZQD7KGcdQDLeaWr75EVppO4MTwJRRoOrdoEXCqQNdCYVLIF4LhkUjc8NIAk6ER8dtP4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=robert.mader@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1768065015; s=zohomail; d=collabora.com; i=robert.mader@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To; bh=bFFrq++5ofhqy9jPSw2PTaF8NtQ+WlvlI5/s/WvKYVw=; b=FMouCjkqh4F0qFzr/jfzli+MJhP0UD46BdXexuVNr68Eh8kiNQWBVuEkh7n76YiG Z9V4mPOj/iMsWRasF56xBQXih5lh4rJGUPWMj29SUZVSmqRSm1Odsipk0kNIM6TLkRI RCdSrRzgdFNsMPw5BqhwIvqiGu4ssxpnb7j3iJxA= Received: by mx.zohomail.com with SMTPS id 1768065013843292.75368789859726; Sat, 10 Jan 2026 09:10:13 -0800 (PST) From: Robert Mader To: libcamera-devel@lists.libcamera.org Cc: Robert Mader Subject: [PATCH 1/4] egl: Remove unused functions Date: Sat, 10 Jan 2026 18:09:24 +0100 Message-ID: <20260110170927.79918-2-robert.mader@collabora.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260110170927.79918-1-robert.mader@collabora.com> References: <20260110170927.79918-1-robert.mader@collabora.com> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" They are left-overs from older iterations of the GPU-ISP. Signed-off-by: Robert Mader Reviewed-by: Hans de Goede --- include/libcamera/internal/egl.h | 10 ---------- src/libcamera/egl.cpp | 10 ---------- src/libcamera/software_isp/debayer_egl.cpp | 2 -- 3 files changed, 22 deletions(-) diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h index a92921123..7b810773c 100644 --- a/include/libcamera/internal/egl.h +++ b/include/libcamera/internal/egl.h @@ -64,15 +64,6 @@ public: glGenFramebuffers(1, &fbo_); } - /** - * \brief Construct an eGLImage with automatic stride calculation - */ - eGLImage(uint32_t width, uint32_t height, uint32_t bpp, GLenum texture_unit, uint32_t texture_unit_uniform_id) - : eGLImage(width, height, bpp, utils::alignUp(width * bpp / 8, 256), - texture_unit, texture_unit_uniform_id) - { - } - /** * \brief Destroy the eGLImage * @@ -108,7 +99,6 @@ public: ~eGL(); int initEGLContext(GBM *gbmContext); - void cleanUp(); int createInputDMABufTexture2D(eGLImage &eglImage, int fd); int createOutputDMABufTexture2D(eGLImage &eglImage, int fd); diff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp index 0544056bd..fcaf7c58f 100644 --- a/src/libcamera/egl.cpp +++ b/src/libcamera/egl.cpp @@ -349,16 +349,6 @@ fail: return -ENODEV; } -/** - * \brief Clean up EGL resources - * - * Destroys the EGL sync object. Must be called from the same thread - * that created the EGL context. - */ -void eGL::cleanUp() -{ -} - /** * \brief Make the EGL context current for the calling thread * diff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp index 8e0890323..1c13b72a5 100644 --- a/src/libcamera/software_isp/debayer_egl.cpp +++ b/src/libcamera/software_isp/debayer_egl.cpp @@ -615,8 +615,6 @@ void DebayerEGL::stop() if (programId_) glDeleteProgram(programId_); - - egl_.cleanUp(); } SizeRange DebayerEGL::sizes(PixelFormat inputFormat, const Size &inputSize)