From patchwork Tue Jan 6 17:00:51 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 25668 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 4B1AABDCC0 for ; Tue, 6 Jan 2026 17:01:26 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 055B962013; Tue, 6 Jan 2026 18:01:26 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="sB4nMzNA"; dkim-atps=neutral Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E64E762013 for ; Tue, 6 Jan 2026 18:01:23 +0100 (CET) Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-42fbad1fa90so973526f8f.0 for ; Tue, 06 Jan 2026 09:01:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767718883; x=1768323683; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BO0mMIWhB901RhyMhEcHbc+LWlQiOyKCJvDrt0v6kXI=; b=sB4nMzNAeDLfxT/7bOjvIVdLUWyad+hI2PeUQXzCzm9uLwhVNpuffVezei0IH021tE xxrUfY4r2toyQvJ7I5g14fjOui9BN2aecmmEcVRKfgXdl9JweSxylA/tKUFJBd/chEGw YMzsiNxGqbNeGgRcByPo6Zn6RW6YFrwu07D9nEg/+2L20hA6ITJE9qfgM4m7159dX4Hc fbs33LRNnmDVsS5TjTiKTsMeVhTNTh71gr8/A4u2e9UG7rXgz4I7+X2K9gPw6AhEd+99 Kt6C/jAZH04PZT0ijVJZbzOVyvswV1OkWnh2gwI/K2nhOShPiUi94y/XXKBNhTxrilzX ne5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767718883; x=1768323683; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BO0mMIWhB901RhyMhEcHbc+LWlQiOyKCJvDrt0v6kXI=; b=tE1M0Z5O4+Ucw6Ngt8yxkviVWZS/+M5TRtVvE2UZ9j9n4b+nd72LMZS0XYU/tZPOrq guJR5sjPZsbUzaoJBsLuZdMb6691QiOk30Fl0b70PAXFQO+h/S+x2HmwZdaX5ycV2fqf gEI3h6vXIhmqtjmbCh75idDzs+sMomJm6qCbNLs2u0Y4uwgB4cCuwjSEBH1+Gdafvc37 BijDOjJXu6o3W2j9pQCs3VluRi2wvrLs6TElLFGMmMwNeRjUog7j8yQbmy5Ss5uSnyp2 /nbWvUMcEc5FTJaAYGo3+vYFCEbP6yuE7S4ej5kYIcrktFj8afvVZGScrfcrdY8Ufm3q phdQ== X-Gm-Message-State: AOJu0Yz8hafGHuUcNhQSsgz0qR26LfZ5SbBPNXDx8Xk/8BX6eorl5hOg QBmk4g3uTznzeQeTEhFey8K+fRQkAaxZziYaDwbWgO2sWLAknRzVXOW0QcmG3DU6lQLN4608jZc toB0p7Fw= X-Gm-Gg: AY/fxX7Mi3jakGkXNwH9fiwPVpTknGtjjNI6ZqT5hDywXnM+b6CqX5Vs2HBko2LXkdi P92/iZ011HDN8Hs75HoQvHysd+SqSfvqaFaZvYYUWMP1TrqmlPwQxuf4Hi3u33Xz/cV/mKzZBpJ /N1ZqlYXR9Lin3Vl6vIphTqeLyWzegA4Jkr4/SwnPYDqtkw34bWA+rq/LuL016HX1M0FsZalTXy 92lcB/tHVjccgddsO6q1jWyY1KTqfUZ0y6dWANSApzU3sFzJgIsddw7qfGGRJ339qmYy2KloatR fJafG04LtUULEYQIvgLvzWKcS6F8KEbQmMOhl9pFj1qkW9aF184ImWy81zR5Ji6vYQzvPSJEwWo zVnZ1/zgn5tcQgTjFtnDaLnUANRFjt1aqgCIvWnLdkIpEb/Wsw4+1DuWxl7D+9xxtetd1AjTHWB 7GsTa+GFdKEHmuudwvhaoZ38Zp/VYzEakkx4zbkWImndhzlkjkYtsrSU4G1fR6zqTP+Mo= X-Google-Smtp-Source: AGHT+IGRqjz2VW5/U6E4U01qlwSqVp5kzylBAmebYkRcGvT3M2SzqvZMyd7qoVUCJNnfe0lSFzZxew== X-Received: by 2002:a05:6000:22c7:b0:432:586f:2ab2 with SMTP id ffacd0b85a97d-432bc9ccc24mr4398820f8f.4.1767718882931; Tue, 06 Jan 2026 09:01:22 -0800 (PST) Received: from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd0dadcfsm5515322f8f.3.2026.01.06.09.01.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jan 2026 09:01:22 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: pavel@ucw.cz, Bryan O'Donoghue , Kieran Bingham , Milan Zamazal Subject: [PATCH v11 16/24] libcamera: software_isp: debayer_cpu: Make getInputConfig and getOutputConfig static Date: Tue, 6 Jan 2026 17:00:51 +0000 Message-ID: <20260106170059.56193-17-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260106170059.56193-1-bryan.odonoghue@linaro.org> References: <20260106170059.56193-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Make getInputConfig and getOutputConfig static so as to allow for interrogation of the supported pixel formats prior to object instantiation. Do this so as to allow the higher level logic make an informed choice between CPU and GPU ISP based on which pixel formats are supported. Currently CPU ISP supports more diverse input and output schemes. Acked-by: Kieran Bingham Reviewed-by: Milan Zamazal Signed-off-by: Bryan O'Donoghue --- src/libcamera/software_isp/debayer_cpu.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libcamera/software_isp/debayer_cpu.h b/src/libcamera/software_isp/debayer_cpu.h index ecc4f9dd0..67df2b93a 100644 --- a/src/libcamera/software_isp/debayer_cpu.h +++ b/src/libcamera/software_isp/debayer_cpu.h @@ -97,8 +97,8 @@ private: template void debayer10P_RGRG_BGR888(uint8_t *dst, const uint8_t *src[]); - int getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config); - int getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config); + static int getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config); + static int getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config); int setupStandardBayerOrder(BayerFormat::Order order); int setDebayerFunctions(PixelFormat inputFormat, PixelFormat outputFormat,