From patchwork Tue Jan 6 17:00:48 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 25666 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 130ACC3213 for ; Tue, 6 Jan 2026 17:01:23 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C4B0061FFC; Tue, 6 Jan 2026 18:01:22 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="pekLfVdO"; dkim-atps=neutral Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C969762011 for ; Tue, 6 Jan 2026 18:01:19 +0100 (CET) Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-42b3d7c1321so696871f8f.3 for ; Tue, 06 Jan 2026 09:01:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767718879; x=1768323679; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qdq7BA4RV8ukinhniZlFu8ZUJ0DD8hbXSQeatSegKMQ=; b=pekLfVdOQuzhYRcpG5UUrscC3kzY2aOuymw7Pc3VG6u7/lQay8xo371puSyyY/2arG SiQqBJSL+KfhiIvbAC4Z3csoshNHledRs19Qi3qdNC2SawC3w1gypRuN1tQRGZljo00W Z8ejvp/tZ3jqHzDykS7GW3QSP1lLdjAsbwK/BP3YF84sAX1OP3MjgTjfmm00s/dsHNwE bqJyDGPo68t39VEHYXiV4eFeY3jh0zln5Db+WaIH6uDBnZBn6iIdT/s5Ard3I5bhxAPc QlLk+ppZe9zX//EVU52PLDEXypH2olIzUSG7MyR+jt/5xcIVrMRS1gqrDPl/X9khOFp8 EmEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767718879; x=1768323679; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qdq7BA4RV8ukinhniZlFu8ZUJ0DD8hbXSQeatSegKMQ=; b=rbQ4j+0oRh86LklxwZYU0NZe/KeKnmVsohKHJa0r9kz7JvH1rcpSmMhh7V9Cs9+xPr /R6s2k/uzvupvnpYZvaQFyovt2gyHzl35n6d4hTHRG1MZEiEt7nZt6GCZdPf85m5un9O P7fqz65xk6KIfOiHG0nvhdU3i6br0lQCobdXAvxmXT/bsPRBvzhPmzA62XWmzGDxwI4R hsaqki8dLsm+U1IV6qeGUY0p4BZZMpJiligHY110uDY/TqQo0c8i8lXJYqywn+/OPA0h GFyZ9ieg19z734DmkqCZ9RB5od8hNfPU/2enEcZmq2ifJMP35YCz8jQKGJuGu4ixn7VC PA7w== X-Gm-Message-State: AOJu0Ywm3jo9mrPozi4KPK5PVZugL2XriDMixyg1+4yA1ec76mzpJ0rV 1Qcy6biOzose8ialXrFdHz51RurX2eQDf0goBDWEnGH2futf0wVUr0AkB0IZaDvQCvtoYrJUEKu u+/l3gw0= X-Gm-Gg: AY/fxX6ypdCZKW0TVpAsOM5zNM0LPC2IZSjhCR7Zqzuqj1u8Vg0sEVcUCajPqPUiWOt DJPltf2Ks48bzqMuGLa66WWM766BdvDbkyRbGlamSYjzG9/9dieKsCHFMpHW1CSoqOr11GAyoyM 4gtB1H98hjd6J5g+B06W1eRTYWRahR4M0hNgb8cbvwg0BF6WaZoXna3N/2LS4xDhmGNMeizAxCE OZ6ffj7E1Rq9K7c0ugIEdROsaZigi9WZaP10qgIDof+mBluq0C7MEy5isA7L1+S7uP+2r6ASbyo 8xqvE0TwPEMTzBXhsnQabzSM0F6MHsZ+vVHQU9/iMU4nf7gMQ/GdSUfYLVIiibAy8ioFEcWm4DE VNKjkgzksN+mcVLZ2Ahnv4Pl/0NZ76O1Nx4T2NQpsJROr8LVyo2ffa/0pjMAl//Ie/vaExSAvTk Udz8O1dL1IQUp1b3s2RjwpKUBZ3NqGeWLwn6MrwP4i1rONtiw8y4IGDCe+1svOHxoxMYg= X-Google-Smtp-Source: AGHT+IGsb7x3KJ1KzZdw69Mk5GTsI+BcFvtIjMYRFmhEq+SC4R5I0KZ8J2T5MKLy10MQ1Ch5JVMWfw== X-Received: by 2002:a05:6000:2584:b0:430:f1d3:fa2 with SMTP id ffacd0b85a97d-432bc9cbee7mr4479936f8f.7.1767718879002; Tue, 06 Jan 2026 09:01:19 -0800 (PST) Received: from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd0dadcfsm5515322f8f.3.2026.01.06.09.01.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jan 2026 09:01:18 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: pavel@ucw.cz, Bryan O'Donoghue , Milan Zamazal Subject: [PATCH v11 13/24] libcamera: software_isp: Add member variables to track selected input/output pixelFormat Date: Tue, 6 Jan 2026 17:00:48 +0000 Message-ID: <20260106170059.56193-14-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260106170059.56193-1-bryan.odonoghue@linaro.org> References: <20260106170059.56193-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" In order to have Debayer::start() tell the eGL shader compilation routine what the input and output pixel format is, we need to have a copy of the selected format available. Add variables to the inputConfig and outputConfig structures to allow tracking of this data for later use. Reviewed-by: Milan Zamazal Signed-off-by: Bryan O'Donoghue --- src/libcamera/software_isp/debayer.cpp | 10 ++++++++++ src/libcamera/software_isp/debayer.h | 2 ++ 2 files changed, 12 insertions(+) diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp index 4cb5b4da4..b948efad1 100644 --- a/src/libcamera/software_isp/debayer.cpp +++ b/src/libcamera/software_isp/debayer.cpp @@ -290,6 +290,16 @@ Debayer::~Debayer() * output image buffer. Set during stream configuration. */ +/** + * \var Debayer::inputPixelFormat_ + * \brief The incoming pixel format + */ + +/** + * \var Debayer::outputPixelFormat_ + * \brief The output pixel format + */ + /** * \var Debayer::red_ * \brief Lookup table for red channel gain and correction values diff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h index b8287166e..d716ad080 100644 --- a/src/libcamera/software_isp/debayer.h +++ b/src/libcamera/software_isp/debayer.h @@ -75,6 +75,8 @@ public: DebayerInputConfig inputConfig_; DebayerOutputConfig outputConfig_; + PixelFormat inputPixelFormat_; + PixelFormat outputPixelFormat_; DebayerParams::LookupTable red_; DebayerParams::LookupTable green_; DebayerParams::LookupTable blue_;