From patchwork Tue Jan 6 17:00:44 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 25662 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id E3F09BDCC0 for ; Tue, 6 Jan 2026 17:01:18 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 9D4856200F; Tue, 6 Jan 2026 18:01:18 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="jHotMmce"; dkim-atps=neutral Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7D20C6200D for ; Tue, 6 Jan 2026 18:01:14 +0100 (CET) Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-4775ae77516so13072525e9.1 for ; Tue, 06 Jan 2026 09:01:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767718874; x=1768323674; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5qjoeAop1GzrvnIG7vvLvJkbwSmYKtE+YPe2MFgINpo=; b=jHotMmceuVQWtt2vCL4tt2JIeiZiunHPvS4OWghvc1sLpYQSvQf5vlxxWDCqpxEIno g7BjWfiFAnCM8H/Q5HO9yU5ibj3KD0XvC3fqxG9Tbn3SDd5zSg538zHDDJJSmbTecNcq YO/VUjnWpB6JGnZZzemvaVMJDyGE4azhBjE3eJfjCNqrneNlib+YWfOG8KMGqVKjYhIl 83yXN7DzojM//0pvhMr8posd46S6PByYYPcWm8195wWKu0iw/kKWHIpa3PIGIa/F24P4 YlrvVVEPojBsj8v/PDD+nAWAdC/QzN4OVeKBrvb645tw2jyaXXpGomDLMgKGiPX68N0h DN4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767718874; x=1768323674; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5qjoeAop1GzrvnIG7vvLvJkbwSmYKtE+YPe2MFgINpo=; b=rY/SxSWkPEGlysZ8TvFZXcEpA9XnKCU+QQumEymRd3pUXMlUs7lSSTS5+YtvxhVKpz 4vv4BcJ8HBizDiyPtlG+8Txztbqq4M5QcvQzDwyvuv3lVNc0ZWzoFgOJ9zfq5re0dby+ fssj9TSSLo+VDI5v8zCdeZvbrwkUKCGjPLFuFsyNDwUwgJaUr/udRc1Yow/ZBmsFq2os +v+dWyeTTXgKoQD5IWDLneabXpfYW0fC2Qkmwu7xTt/1tVLThTqhh4TGB/3FLgORjN70 YnsuEfgkA6B+JrVWDvFbjl1jCoCCWHnAxxXkMRXJtf3LvTefMAv+WUoWqQTgfNT+rTHZ IHjg== X-Gm-Message-State: AOJu0YwSvqYwV17RROP9IcwKAsLaYMHPp3VRgkRhAIAJuVnVMgTmcJFv QMnlqDBfkTePLisR0xkfq0kCnVbRHx72Gr/qCNwWTuJIYHeBjonUJxtCCbh8AL3rx33FIQphkkO 22oLy9Tk= X-Gm-Gg: AY/fxX5xxJlHY0cqeBcQw7YqO4gW6S2qxs35q4GojPOrIbvfwhXZJDAJrPcyYYAOxIH CYgdKdkxvObK2vPKBaGp6iO1sBoVChvbjWSYsIm59NXX14oJN2npB856RFWGcdksxG+DbA93BHu G0wMDAl3toWWqlXiR0lH4ZBAXj8Jbmstb2lWdBLPhIwlstdrsGqAkBG6CdnDvWLWDOSG+nl1MK+ XZjXPSuhoaDA+vWbSkE5Xs1ZnJp38G8LDYJgldCUT8T405DgTct+ZqvTbE33AC189C0VWHlyVFe L+3wVqi6g8D/0tg6Rhiq37/3fAhBdZhy6TxY0M5gxIxqbCwvjAChRl0tmdoKtSGJcCcegyLKQFm DrM22rp7sOywDN4JBfzocGT4+tWUZWIlpwCJ1R5pQ52wJCBPgSN4NmdY2EwRHrW1epXYqWa2YYz 22T8kkohfZBumZ5UA81ytJh5lnluU0TLBbjeF0GZh84TFKBuf03QQv7ta9mdTKZ3swmrY= X-Google-Smtp-Source: AGHT+IGk04wS6fiwL2wtMDFH/ztDpNqMqNc48Kz8v8UVM+7jXklUA4Va1pvciKOKJa64TPKDoZ1CLA== X-Received: by 2002:a05:600c:818f:b0:471:131f:85b7 with SMTP id 5b1f17b1804b1-47d7f076b6fmr41724875e9.15.1767718873182; Tue, 06 Jan 2026 09:01:13 -0800 (PST) Received: from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd0dadcfsm5515322f8f.3.2026.01.06.09.01.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jan 2026 09:01:12 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: pavel@ucw.cz, Bryan O'Donoghue , Milan Zamazal Subject: [PATCH v11 09/24] libcamera: shaders: Add support for black level compensation Date: Tue, 6 Jan 2026 17:00:44 +0000 Message-ID: <20260106170059.56193-10-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260106170059.56193-1-bryan.odonoghue@linaro.org> References: <20260106170059.56193-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Add the ability to apply a int blacklevel gain against the demosaiced data prior to application of colour correction data. Reviewed-by: Milan Zamazal Signed-off-by: Bryan O'Donoghue Reviewed-by: Kieran Bingham --- src/libcamera/shaders/bayer_1x_packed.frag | 3 +++ src/libcamera/shaders/bayer_unpacked.frag | 3 +++ 2 files changed, 6 insertions(+) diff --git a/src/libcamera/shaders/bayer_1x_packed.frag b/src/libcamera/shaders/bayer_1x_packed.frag index db8c2a0b3..7036fe278 100644 --- a/src/libcamera/shaders/bayer_1x_packed.frag +++ b/src/libcamera/shaders/bayer_1x_packed.frag @@ -66,6 +66,7 @@ uniform vec2 tex_bayer_first_red; uniform sampler2D tex_y; uniform mat3 ccm; +uniform vec3 blacklevel; void main(void) { @@ -213,6 +214,8 @@ void main(void) vec3(patterns.y, C, patterns.x) : vec3(patterns.wz, C)); + rgb = rgb - blacklevel; + /* * CCM is a 3x3 in the format * diff --git a/src/libcamera/shaders/bayer_unpacked.frag b/src/libcamera/shaders/bayer_unpacked.frag index 06d80f3dd..f0d8cd1e2 100644 --- a/src/libcamera/shaders/bayer_unpacked.frag +++ b/src/libcamera/shaders/bayer_unpacked.frag @@ -25,6 +25,7 @@ varying vec4 center; varying vec4 yCoord; varying vec4 xCoord; uniform mat3 ccm; +uniform vec3 blacklevel; void main(void) { vec3 rgb; @@ -108,6 +109,8 @@ void main(void) { vec3(PATTERN.w, C, PATTERN.z) : vec3(PATTERN.yx, C)); + rgb = rgb - blacklevel; + /* * CCM is a 3x3 in the format *