From patchwork Tue Jan 6 17:00:41 2026 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 25658 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 8178EBDCC0 for ; Tue, 6 Jan 2026 17:01:14 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 36D8C62001; Tue, 6 Jan 2026 18:01:14 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="HbyTje2Q"; dkim-atps=neutral Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id DEE6A61FD8 for ; Tue, 6 Jan 2026 18:01:10 +0100 (CET) Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-430f9ffd4e8so12048f8f.0 for ; Tue, 06 Jan 2026 09:01:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1767718870; x=1768323670; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FdyTcK0Xun67yTvAExHcO9DNNAcWNw/aYg3LzuhT/Zc=; b=HbyTje2Qt3bypbGQ+MKR2A1lhOly6h/tw6TNjaon0T1Fc49Krm1iP/Z5KaLE1pgrkK B14pVyBX5mW+PFHdwmxWb4XvyK7pil2R5Vra/90JCWXuIiZEd7druHP5bHe//WUov17v 5c+qF+RFBCWwV2us6QsxycJLR8hZujjFaFFWZgS3kqegbSWeMK6174S5IEYFa/LF31DP TTKY2tfA92tCMNEcZOK/R7wb5gGySWQB7/gxSFihzGmXutOz3rFLo/9zkBKVNOMB3bg9 HdZqACJGm79eEL7enmSoR//tjprr6wNb4BpOAGHn1Xq8UXybg/ws63avMj9nNhlTJi1j B5UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767718870; x=1768323670; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FdyTcK0Xun67yTvAExHcO9DNNAcWNw/aYg3LzuhT/Zc=; b=wEHli2nxpDRd2XCZsS3p38sQmYnH3oRkL/sqD9f/lGARFCJF7u1Y1k5DOo5gTkBL19 nG6PXe55p7KgWSuoFLFEn2uAdOUTMzJXsJaAd5Ov2ROYybWgjzczEHF/36soFEDMmL3G Th/sT5/6PCUeQCX09974HydbsLuWfa2iab5irQ6fdqKZRndrYqtQG4wWWyX/maYdkpuu 15V9aUsNMjzNEaF4UoApKx2Znr+HVuVX3Mx2R2X0a5y/tGPj+VDug064QMVTL222HZnT BxpJ4RpHTR+Wg7GnnA2w52IXU8OXZzTPN4F6pNGbjdDc8u8mV4OmoBCoLon/YgZrmxRj 6k2w== X-Gm-Message-State: AOJu0YxIlyjJXv2BoWA7umfb2V3HsIa8O1CuU0ABT5eLp4ROEhp5FRKc D3vpg5hraQCNfBsEKFK+yflRTTXxSXT2QPQnuGh83hTwB+kADTX4Zz0vc3H3jOyXzG2KkEk6iaR VO9N2huc= X-Gm-Gg: AY/fxX4HvvAEdPXFLdy3wGyxceDhdd0dv7slty3aPXIW76qJetG8FLJRI8CINhRmfds wh2rwGKvbh+bZ+l0FrbtVMR1zT/P49thuxp/Pq6TgqTh+/qc+oPKe/TqqSfojNqdjKZvwe/p3qf d2lIaeU+xnmo5L8HXK+ihQFvxMBQ6JRMCETTZYrZEPTwVbpAEUjKgsnVRPJR1gUFZeRc7Uz7d2H kG++6v3N9bCGkPoZOnDVhtJlGBctA5/z3ZRH9JItaVkht/QsHKFEdxtpLUgYoYiZ7iUJCuxLO9S r9nTaVFxbjg+KhCMbJc641Bmm9T7Jee+Txu4ygvu71sjGLIxrCeqBL1t55qNuln643Y07itdWpy xjpNAqDYTewo4e9Yolw95r2zzvoy+I++krfq9015dARSVvoWgoPRrcAVbe/T4AwDepkBty50PW2 2b19UsTxvWdQckNstvn0/VgOZrQ0CJERxlHWN3GrsBd84OQ/pr2VhAdz8q50OSks26j0I= X-Google-Smtp-Source: AGHT+IGA3h8/j0K6YrgdG79neI22XcE/kolLhlAEY4OCLvXgzRRCxOe+ckTu2IzZMdiNAgdisF2TEA== X-Received: by 2002:a05:6000:3107:b0:430:f593:aa34 with SMTP id ffacd0b85a97d-432bcfd3d38mr4146306f8f.17.1767718869930; Tue, 06 Jan 2026 09:01:09 -0800 (PST) Received: from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd0dadcfsm5515322f8f.3.2026.01.06.09.01.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jan 2026 09:01:09 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: pavel@ucw.cz, Bryan O'Donoghue , Kieran Bingham , Milan Zamazal Subject: [PATCH v11 06/24] libcamera: shaders: Use highp not mediump for float precision Date: Tue, 6 Jan 2026 17:00:41 +0000 Message-ID: <20260106170059.56193-7-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260106170059.56193-1-bryan.odonoghue@linaro.org> References: <20260106170059.56193-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" mediump gives 10 bits of mantissa as the resolution. At higher resolutions 10 bits of accuracy is insufficient - for example at a width of 1928 bytes we need log2(1928) = ~11 bit resolution. Switching to highp gives us 23 bits of mantissa giving a sample width precision of about 2^23 ~ 8,388,608. Acked-by: Kieran Bingham Reviewed-by: Milan Zamazal Signed-off-by: Bryan O'Donoghue --- src/libcamera/shaders/RGB.frag | 2 +- src/libcamera/shaders/YUV_2_planes.frag | 2 +- src/libcamera/shaders/YUV_3_planes.frag | 2 +- src/libcamera/shaders/YUV_packed.frag | 2 +- src/libcamera/shaders/bayer_1x_packed.frag | 2 +- src/libcamera/shaders/bayer_unpacked.frag | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/libcamera/shaders/RGB.frag b/src/libcamera/shaders/RGB.frag index 4c374ac98..724395894 100644 --- a/src/libcamera/shaders/RGB.frag +++ b/src/libcamera/shaders/RGB.frag @@ -6,7 +6,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif varying vec2 textureOut; diff --git a/src/libcamera/shaders/YUV_2_planes.frag b/src/libcamera/shaders/YUV_2_planes.frag index 1d5d12062..d286f1179 100644 --- a/src/libcamera/shaders/YUV_2_planes.frag +++ b/src/libcamera/shaders/YUV_2_planes.frag @@ -6,7 +6,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif varying vec2 textureOut; diff --git a/src/libcamera/shaders/YUV_3_planes.frag b/src/libcamera/shaders/YUV_3_planes.frag index 8f788e90a..8e3e0b4a5 100644 --- a/src/libcamera/shaders/YUV_3_planes.frag +++ b/src/libcamera/shaders/YUV_3_planes.frag @@ -6,7 +6,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif varying vec2 textureOut; diff --git a/src/libcamera/shaders/YUV_packed.frag b/src/libcamera/shaders/YUV_packed.frag index b9ef9d41b..3c9e3e397 100644 --- a/src/libcamera/shaders/YUV_packed.frag +++ b/src/libcamera/shaders/YUV_packed.frag @@ -6,7 +6,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif varying vec2 textureOut; diff --git a/src/libcamera/shaders/bayer_1x_packed.frag b/src/libcamera/shaders/bayer_1x_packed.frag index f53f55758..19b13ad08 100644 --- a/src/libcamera/shaders/bayer_1x_packed.frag +++ b/src/libcamera/shaders/bayer_1x_packed.frag @@ -20,7 +20,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif /* diff --git a/src/libcamera/shaders/bayer_unpacked.frag b/src/libcamera/shaders/bayer_unpacked.frag index 7e35ca88e..aa7a1b004 100644 --- a/src/libcamera/shaders/bayer_unpacked.frag +++ b/src/libcamera/shaders/bayer_unpacked.frag @@ -16,7 +16,7 @@ Copyright (C) 2021, Linaro //Pixel Shader #ifdef GL_ES -precision mediump float; +precision highp float; #endif /** Monochrome RGBA or GL_LUMINANCE Bayer encoded texture.*/