From patchwork Wed Dec 17 10:01:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 25599 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 20CC5C32F4 for ; Wed, 17 Dec 2025 10:02:32 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id BC7B561F49; Wed, 17 Dec 2025 11:02:31 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="S5/QDaUc"; dkim-atps=neutral Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3ADCA61D64 for ; Wed, 17 Dec 2025 11:02:15 +0100 (CET) Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-477ba2c1ca2so61367405e9.2 for ; Wed, 17 Dec 2025 02:02:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765965734; x=1766570534; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lSpaxpbZDestB7ujTLNf/WLvzRiE05FDL1njdNGYR9o=; b=S5/QDaUcbpGJS7i4DZN5WclItWkVB5/v7G9BlO8MTIswyvzFC5vLO1DxnKI3Rby9Sm AvWNvbQcSW+2dPCJ9U+jrWylCxfirwH1ewESZ1fFJjejau3YMDMeQS6zEWvAlagNCytm /rmeDI3ZyPjTu5qZTctyQRCseYpieFopd+OTd85lP4yYGIKbubO23JX/yFons9NKrXxR tNG0ebAnl7QIUV21O9iScOuO1XOWgE/Zh/J7wlYrbFc6/901oY8SF+W8w76UfQivkos1 WQlT4VvLTDEFu3FOF86ibVQDTN3n4jRrFsDGe2m+omHEW7lXndjI9kolCrDyDH8ppyoD 8GFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765965734; x=1766570534; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lSpaxpbZDestB7ujTLNf/WLvzRiE05FDL1njdNGYR9o=; b=WxID46TkmU2q6JqsJLYpdmmnLjxbCQujHC5V221FumYEkZ1Pmrd2lQfIsyftZAtTCo tYl3bSfPyKfme9iBnGWbRF3HfVBJXkocitiEZiTCRiUQjeXZtIen7ve22dvrkt2nfXuh A8uGhIi1C++baedXwoCZXQrJFsIXEH7dmr9TTf64KHKr1fJ4fY52hh9Us+vjc6b7otzM Z3VHVEDBL0eNdPNnIHIDlUqtUaonPmiyW45xWhBnIKqBZYTUYO/ke+wGu9AXApZVhmBF kOSHOjsKHOHla/rlEqICpTof/I1Ff+QW2s+FrQQaQKlvK40LEWXMITVvt1noMcTS49Qg cRVw== X-Gm-Message-State: AOJu0YwAQEA/jWwX3NtKde/ZF2vCBLxAooCTyPgXMEoN8Xjsuncv1K1l DrPw3fuPKif+Ou0f1f44puZDdYjwIjoP7Bf8nG4V3ijZH0cxhQnd9b04BycVjaA60ViVLHkD3LA GQjRp X-Gm-Gg: AY/fxX58MwZIRVzeQz5a+KyGOX0fxo48gZb6gmRpg5yKyuFVLnRqIMG3HGjaKG+hxMI MzJfVIcNDauCxQ4I1mNmqyd7wJoa4wB/Nx1VdEvy6WttUt2F0SOmh3/H5GS8uc4EZTvclzZ9S5j H64ui4D0o68tc/egynZDK+MwZVZXSDY1nXLDgQYuBP89g0iy0MRujyULuvLuqnljeWa4/Zgo1ts +2pOu28YhjfNLBMmftl7nWIbzs1D1r39+Wi0CPReqHG6NKpsvUCa4WVhSrp2b0B6HJTIXMEl4Ys ns+8FsZjsQ+2z2dCa2m5Ss1MC4hVDHlqYGETefRUFIgw8nFi17aY2w3ISxxoA3E8cpd82zuoxck udxpLNlD59NnQqh0XB1n1iICMP0jKq/rggZ4bDxb0Ji4CRnoq/v4/1myCmkinCkqZIKa3TDOyXu vG8HwQtbNwwd9a41uuyR22yC8tJwQp5jfOP6NDaUVHgKPXTxT1M9Rv0Gj+MP5VGxziCM9XxrOYX A3BhQ== X-Google-Smtp-Source: AGHT+IF+IaDexqClf/OVgH8iiVI+VxXMhKPwyS1lIagkV7fauMy7XH8Em9ASOTY261wOQd6SsnfFYg== X-Received: by 2002:a05:600c:4ecb:b0:477:7991:5d1e with SMTP id 5b1f17b1804b1-47a8f90c03bmr181039125e9.25.1765965734109; Wed, 17 Dec 2025 02:02:14 -0800 (PST) Received: from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47bdc1583fbsm32292585e9.0.2025.12.17.02.02.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 02:02:13 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: pavel@ucw.cz, Bryan O'Donoghue , Kieran Bingham Subject: [PATCH v9 26/26] libcamera: software_isp: Add a gpuisp todo list Date: Wed, 17 Dec 2025 10:01:38 +0000 Message-ID: <20251217100138.82525-27-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251217100138.82525-1-bryan.odonoghue@linaro.org> References: <20251217100138.82525-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" List the series of things to do in GPU ISP in perceived order of difficulty. Acked-by: Kieran Bingham Signed-off-by: Bryan O'Donoghue Reviewed-by: Milan Zamazal --- src/libcamera/software_isp/gpuisp-todo.txt | 40 ++++++++++++++++++++++ 1 file changed, 40 insertions(+) create mode 100644 src/libcamera/software_isp/gpuisp-todo.txt diff --git a/src/libcamera/software_isp/gpuisp-todo.txt b/src/libcamera/software_isp/gpuisp-todo.txt new file mode 100644 index 000000000..8930da120 --- /dev/null +++ b/src/libcamera/software_isp/gpuisp-todo.txt @@ -0,0 +1,40 @@ +List the TODOs in perceived order of ease. + + +Denoising: + - WIP + +Dead pixel correction: + - WIP + +Lense shading correction: + - WIP + +Use dma-buf handle to generate upload texture: + - eglCreateImageKHR can be used to generate the upload texture i.e. + to feed the bayer data into the GPU. + +processFrame() to run in its own thread: + - processFrame() runs in the context of the Debayer::process() + thread. Robert Mader suggested and it seems like a good + suggestion too to run processFrame() in its own thread. + +Multi-pass shaders: + - This needs some rewiring the idea is to have a list + of algorithms as is done in cpuisp iterating through the + list in a for() loop. + - The logic managing the loop has an initial input buffer + and the final output buffer. + - The higher level logic must then inform each of the + algorithms either to generate an internal working buffer + or pass the final output buffer to the last shader + in the list + - This will allow for multi-pass shaders with the final + algorithm presenting data not to its internal buffer + but to the final output buffer + +24 bit output support: + - Need to implement compute shader to do this. + +Lense flare correction: + - Not WIP still TBD