From patchwork Wed Dec 17 10:01:27 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 25588 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id BA769C32E7 for ; Wed, 17 Dec 2025 10:02:17 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 111AE61F4F; Wed, 17 Dec 2025 11:02:17 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="I+rdohQh"; dkim-atps=neutral Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id AB1AC61A37 for ; Wed, 17 Dec 2025 11:02:01 +0100 (CET) Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-47bdbc90dcaso5943375e9.1 for ; Wed, 17 Dec 2025 02:02:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765965721; x=1766570521; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BO0mMIWhB901RhyMhEcHbc+LWlQiOyKCJvDrt0v6kXI=; b=I+rdohQhnb48j5GwtDjHGq5C04i2iS+y5oGcPRnjdghDRLhNiWbL5zHQyWH/gMMhxp dRmFtaURy8dj6Qxg0km9H+kVlW9x6C3IADOglE8bXXXShryjM40/060wwc19sYOrFJ1/ +lk3jTSqnvzLIJEPtubQkvOeINXQvy1YIDkFLS+jsKdL6nvNbY8yRG2sRbb8mvvAJMvk 8fV61PB+DqtoAwlJDr7pIYQTAPH4oziRXemZzmGtGnllzzjC5hFWx6ej/zVxPYnKkCRX O7oVTxgpv5lsanLHJJJQybCce9RS07c397qGpVnlt+5d5nyqY0M7oxWLK3jIaDe2RIFT gWpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765965721; x=1766570521; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BO0mMIWhB901RhyMhEcHbc+LWlQiOyKCJvDrt0v6kXI=; b=A9Y3rwSpg1nM5OanpvMPPH+wJZdsamKpQVlBpiLn2P8+a0pq7bueXdkT+B9Rc0iBWA SFYZkFK6YPJ6fX4L6Qf+wY9g/3Ry6g9/SlNP+FdQ4Urvz7aNPMZysSnzNpwbyzlet4UO IpmcP8JuoiNjUphcBdcNJafasp2vMgkQ2F3e2iGAMqethnEGGC7KGh2Wy1hIwHxf4j9a TCB7fx6PEI5l+RSd/SAKXofECk8UuCyfqlBe36gX4qWX4bk7Uh4u5yMSlH8Dlj3lIkHW jPPerafqXlyUzt42CvEmMgCehtmJ5XbN5HhNy97IfVERJEXn/mGv0yOQVcL0dbRvYVtf vYCQ== X-Gm-Message-State: AOJu0Yx+LH8Wv5hgch4BdGEI7KExNOP/vOlDQaKXFl5ONNxDx1npLTny 3fBA4uGKCq10ZjZiE9NTcHnVf69M3nBnt0+zAXBJxhKu+dJ6QeW/UyvWiudm2YMVRaVaeRJVyvY OZpD/ X-Gm-Gg: AY/fxX5suHXjaaUhuw0UXAYsj17a7jXbyTFbmj9+w+hMJxP55sMKObjemGvX2b9tvPr +r10Iwol904gcthPdBW7GXNdPcOuGrImB8KgM77aRRldR3onmAZHZ43m4/tDsSYEX4kXY35cHOe R11vAq4iaFjcYqrsQLBqzSwGJCwusxvTvPZVtB0AYb0v20ACiUah3zoCE0XXeBqP2P4XEsUXkPY y5q83m4yu70yfuuiZYBNszkUWc0GxeQKKxqwLVEqbr6OitVdXwqF+yO2/Ei60Qz61OhthP8WoBb tuDIZYk7ZxlFOI43ZwTVpaDEhDZfBBENAr5MVFvE9EEUE07awsIiaLzjul+yk8AqtDH5yqCkEjI DUJQgbiKBuUlfYS4Ug/gNWtYj8Gy4svQMtSwoDUyqRx9XrBlfKyiocBggRCfxQ2Zro/IrIS0Rm+ tLzo6A97vGOytQakk7st4agYsD1ZHDpD3MAvCe+iqqvSeI9vR0GvxZAjk09Iqgl2+YCdM= X-Google-Smtp-Source: AGHT+IEuHVIjI3uI49LaFagDFH6IbZnPoRCd1fUpWHaX48z5VVUNeM7pDMgn2HPO5dhJ0Btva/ZifQ== X-Received: by 2002:a05:600c:8288:b0:477:a1a2:d829 with SMTP id 5b1f17b1804b1-47a8f8c0caamr165081045e9.13.1765965720968; Wed, 17 Dec 2025 02:02:00 -0800 (PST) Received: from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47bdc1583fbsm32292585e9.0.2025.12.17.02.02.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 02:02:00 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: pavel@ucw.cz, Bryan O'Donoghue , Kieran Bingham , Milan Zamazal Subject: [PATCH v9 15/26] libcamera: software_isp: debayer_cpu: Make getInputConfig and getOutputConfig static Date: Wed, 17 Dec 2025 10:01:27 +0000 Message-ID: <20251217100138.82525-16-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251217100138.82525-1-bryan.odonoghue@linaro.org> References: <20251217100138.82525-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Make getInputConfig and getOutputConfig static so as to allow for interrogation of the supported pixel formats prior to object instantiation. Do this so as to allow the higher level logic make an informed choice between CPU and GPU ISP based on which pixel formats are supported. Currently CPU ISP supports more diverse input and output schemes. Acked-by: Kieran Bingham Reviewed-by: Milan Zamazal Signed-off-by: Bryan O'Donoghue --- src/libcamera/software_isp/debayer_cpu.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libcamera/software_isp/debayer_cpu.h b/src/libcamera/software_isp/debayer_cpu.h index ecc4f9dd0..67df2b93a 100644 --- a/src/libcamera/software_isp/debayer_cpu.h +++ b/src/libcamera/software_isp/debayer_cpu.h @@ -97,8 +97,8 @@ private: template void debayer10P_RGRG_BGR888(uint8_t *dst, const uint8_t *src[]); - int getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config); - int getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config); + static int getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config); + static int getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config); int setupStandardBayerOrder(BayerFormat::Order order); int setDebayerFunctions(PixelFormat inputFormat, PixelFormat outputFormat,