From patchwork Wed Dec 17 10:01:24 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 25585 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 27B16C326C for ; Wed, 17 Dec 2025 10:02:12 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 6102661F2F; Wed, 17 Dec 2025 11:02:11 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="bhaxPWGX"; dkim-atps=neutral Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 1C08361A54 for ; Wed, 17 Dec 2025 11:01:57 +0100 (CET) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-477770019e4so51940615e9.3 for ; Wed, 17 Dec 2025 02:01:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765965716; x=1766570516; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AkHDdjGVPAipGQD5NCfZ9IhKGBJlwJpwDuA7iC3dtE0=; b=bhaxPWGXx51WS96SOb0NzKb1KgKjU+lqRz/zAYuisG3TCqqrfa/fGh2V8Hso+XyxvW 3HQ8DcZsCTKDEYVCmcd6G5Zqe6SLwMHjB35jz9trS3qnnzd8yon1Ze1+BKMc6nLW//i+ Z2n5mmya3byNNcaRb7oGwVNhEhDbqnfydlOVHAUHXbCbV3arE6Nj31ljAD8SoOr3J+Ky rHR9kNFAO2ZZhpUg4vSezXy2O/FukJa6HmEPXpPegQQJo9YMYlsuWAFAqyZwsKxHbBEs 52ZXHQFhdYyTuWNYvUKDiGQZHKBH6cLSk4VBxCAtRRkmDWUkq7Gxjut3KAInZqfQuWWP /VEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765965716; x=1766570516; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=AkHDdjGVPAipGQD5NCfZ9IhKGBJlwJpwDuA7iC3dtE0=; b=jkov0gSkBYam/kEmkGl3p2rP6jeh2EWJb7h9NmRaW8gT+i401IJG4CEsmP6qvBozdi PPn5z9qChCqZFL9VN4KTegRbU8xipBVktTlJ390VO19TCVVSxOVbc+cPQle/10PNWUMk UsIbxFNFf0MUf8tARh1IIG63S8tSTcm4X4LjkoHouhY+hqmYBoq0IAOzwZJvXRdLYwyO thGAE8+LkSl7HxmuSadInXRFdhJ0HmoQBJu5KUftwJcDWkJxHOTOhgFAaXOQre6Bc/Or 0St2Dj1U+9P2hbpOgnBbLTwTQvXSXSl02Jt/SbGutITbUoGqfQSt2HDfgt0zM8LeS2Zb 36Cg== X-Gm-Message-State: AOJu0YyDNfxwnnb/iNKCbg613KRlfIVgWYHh1Q6EHPe4a1hbx+izh1CV mO2EaATuUfTOiqNh8slHGY06SfVjdaNF6rvIPHKEVHjN+eyn6WETKKZbU3A1AxL9s3XPYPWW+4F IJ/w2 X-Gm-Gg: AY/fxX4BaODmVnJDmWqCi7/Ojd+5o1PkLB3IWJyeEX5b9kMuCoqbzVt4NJHZy211tKz hUxnaaR676QQDjEzD6sMyS6BtMr10W+RppDXswqcxQ4aiwDFUqLnnxcd2wAmJL76LZNS6rFAq5c xqtuiPFxVdZkp4DHxwWIoHBA/A46GAsBB0/DGCJt0xndWo5COt6Nbq/GPmDHr+s0fqP8zmXpvVA 6I8puZbA2jGaEqPpT5MkzHYmzpRE3egLd9pT6l5Ddyko0Np3IVQovG9y51ld9EhURJAEeKypLMj S756D5pz3cgTQWYdpMsJ3ii+A9vRj9WBtmUH+oq0657yjbJOiog8Cbo4kwugZc60ATL9Y2dksYS N+JTTR99j6GvUwLYKN6sT67hvi+V4e5v3MpcyczBOvUprHjEQ6WqEg979x/PvUiQb2AnA3RIgrc vZgOwDm8U9vbn5dKYRvYzD1rC1aTxBGSFIHr7uX5miDpzcKBqcMuU+OOLXXrWrNWZCR2I= X-Google-Smtp-Source: AGHT+IET7iFn7+qGYixQava9cJ1Oxff86MzCUZa5y3Azn07CzsyUquv6IUkCmGxOo95XRsyLySLe3g== X-Received: by 2002:a05:600c:6290:b0:477:76bf:e1fb with SMTP id 5b1f17b1804b1-47a8f8cdfd1mr230766945e9.16.1765965716350; Wed, 17 Dec 2025 02:01:56 -0800 (PST) Received: from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47bdc1583fbsm32292585e9.0.2025.12.17.02.01.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 02:01:55 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: pavel@ucw.cz, Bryan O'Donoghue , Milan Zamazal Subject: [PATCH v9 12/26] libcamera: software_isp: Add member variables to track selected input/output pixelFormat Date: Wed, 17 Dec 2025 10:01:24 +0000 Message-ID: <20251217100138.82525-13-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251217100138.82525-1-bryan.odonoghue@linaro.org> References: <20251217100138.82525-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" In order to have Debayer::start() tell the eGL shader compilation routine what the input and output pixel format is, we need to have a copy of the selected format available. Add variables to the inputConfig and outputConfig structures to allow tracking of this data for later use. Reviewed-by: Milan Zamazal Signed-off-by: Bryan O'Donoghue --- src/libcamera/software_isp/debayer.cpp | 10 ++++++++++ src/libcamera/software_isp/debayer.h | 2 ++ 2 files changed, 12 insertions(+) diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp index b33f818a7..4645b6a1b 100644 --- a/src/libcamera/software_isp/debayer.cpp +++ b/src/libcamera/software_isp/debayer.cpp @@ -290,6 +290,16 @@ Debayer::~Debayer() * output image buffer. Set during stream configuration. */ +/** + * \var Debayer::inputPixelFormat_ + * \brief The incoming pixel format + */ + +/** + * \var Debayer::outputPixelFormat_ + * \brief The output pixel format + */ + /** * \var Debayer::red_ * \brief Lookup table for red channel gain and correction values diff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h index b8287166e..d716ad080 100644 --- a/src/libcamera/software_isp/debayer.h +++ b/src/libcamera/software_isp/debayer.h @@ -75,6 +75,8 @@ public: DebayerInputConfig inputConfig_; DebayerOutputConfig outputConfig_; + PixelFormat inputPixelFormat_; + PixelFormat outputPixelFormat_; DebayerParams::LookupTable red_; DebayerParams::LookupTable green_; DebayerParams::LookupTable blue_;