From patchwork Wed Dec 17 10:01:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 25581 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id E2097C3274 for ; Wed, 17 Dec 2025 10:02:04 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 41B0A61A4E; Wed, 17 Dec 2025 11:02:04 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="NODkQbXl"; dkim-atps=neutral Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A552961A61 for ; Wed, 17 Dec 2025 11:01:52 +0100 (CET) Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-4775ae77516so65869655e9.1 for ; Wed, 17 Dec 2025 02:01:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765965712; x=1766570512; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5qjoeAop1GzrvnIG7vvLvJkbwSmYKtE+YPe2MFgINpo=; b=NODkQbXl1JrepZVGUlixpxv9hjhhmuYVS+CNKBUNaYGQyKtyw5L3HfAz5NP6uPQQwT QAPAhfhUU4czsdvzFA9dxwWLLJm05cIwzMmpP/3REBpxQrrAuBSdBJbRF7H44898luPx A9nM3iChDqg95wG5+XlzZ9N1YwmI5exa9kzg1tW19byH8ifnfsWJ9A2/If8gFkfW/y88 c5cccH68LsXpLzpNlorx2xyZai4rt3smkBAHLZQ/UbSkVCgnOeXapR/mox/gyUMuHsEr 0B4wZW3eMrJxPJB6dwLBMzH6LRbo9nkcfZpHdDQTS9W1iWleMWZmyKebt1EAq6zHr33E M/rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765965712; x=1766570512; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5qjoeAop1GzrvnIG7vvLvJkbwSmYKtE+YPe2MFgINpo=; b=NZFK/1ZAuFvuSnKjl74NrPeD6zZ371zGBJf2tKd95On2EAiS6Jq6ki4wP6KbGZOUvg jh5M7vZ7QzPwIuVM9UuHMEGBkELch7LSuKbXcV3gqOpZnDhcfTfFE0Nk77WsxssU4mS5 BlLdp/qu1EbCzx5kuPjo7LleVri1eNP8dUMltVQffrzgIOxcC/9CFPHRXN6J8k6Eb5OG LcK8ZUwDiUy8hQjv3Bp/uAHXP3G42BVVyoalCqGe1/s3uRb6AVENxSutMEMM7XDTxnVG PQyBi1Hyq1SoOKIrd56lNFu1Oy2sgkXtCcSeJVPUCF2E+m+Gjydip8CxPEb3oCgca7vC tgPw== X-Gm-Message-State: AOJu0YwRhukMq6aeyMhAZYTHfxzUS5Nyj1LINWx8U30ZgJ+utg+1MGrs 5FoWYRRdl/5Rk4pzj/ZdI4ECwMG15JWrir8TRR5IZWkKzX32fhMKN7Y4rLC5xHLKwqq+qRB8DaP wj+e6 X-Gm-Gg: AY/fxX4r2dKkbUz8+mT2Hp9bJkuXb9z5qQ1VaJhbT40c6gDWJPlZJR8I/Zcd/5l7xQK km0rErp32ULO92VoFYEbFFVGTJ4DXlwHOoDNVF1ea2WJiwNIegr8Vfj+AICVqThwQmDzM3E/gXu tAfqfevQYhZ/RVTNTDjFAAU4hNJnruIUWBy8hpm2DB34RcZR4u5rU2Ltco1WNUXS053ACRZ+Q3k VZGgWrGzNeO2Nx6VEASI7xjIHPpPf+u4PG/jqBxxPKO51BaFJIQek2ajiKLjac2sozitWTwR+Pv 7GdlV9mzd3k8FgXCWtXuv3nLkEeIf8MjCe4dbZDPeFK6pXh1WApfcM1z0/Wz/uFNK0kdXYjWc+z Rgk07dV9i62n7hImCJJ6PDDLmRq5zzJ4Ay5jbLo6US0aBhhO8+On3ASDvVnKZAdKJTmT6rBXy4Q PG/K8s4SrJMyo/exDgy2VzC4zXyJUMSuOm34g3Jvvfje229Wm5ZbTr5PhmZcAyEo4mZYM= X-Google-Smtp-Source: AGHT+IEbxmVj6iJaJeRujXAOmxO50UzzfHACot43NZJhcDF8OMis0J/Ok6txdUtyMYRYf4KNR2hh6Q== X-Received: by 2002:a05:600c:45cb:b0:477:9d54:58d7 with SMTP id 5b1f17b1804b1-47be01a441dmr3730945e9.29.1765965711717; Wed, 17 Dec 2025 02:01:51 -0800 (PST) Received: from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47bdc1583fbsm32292585e9.0.2025.12.17.02.01.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 02:01:51 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: pavel@ucw.cz, Bryan O'Donoghue , Milan Zamazal Subject: [PATCH v9 08/26] libcamera: shaders: Add support for black level compensation Date: Wed, 17 Dec 2025 10:01:20 +0000 Message-ID: <20251217100138.82525-9-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251217100138.82525-1-bryan.odonoghue@linaro.org> References: <20251217100138.82525-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Add the ability to apply a int blacklevel gain against the demosaiced data prior to application of colour correction data. Reviewed-by: Milan Zamazal Signed-off-by: Bryan O'Donoghue --- src/libcamera/shaders/bayer_1x_packed.frag | 3 +++ src/libcamera/shaders/bayer_unpacked.frag | 3 +++ 2 files changed, 6 insertions(+) diff --git a/src/libcamera/shaders/bayer_1x_packed.frag b/src/libcamera/shaders/bayer_1x_packed.frag index db8c2a0b3..7036fe278 100644 --- a/src/libcamera/shaders/bayer_1x_packed.frag +++ b/src/libcamera/shaders/bayer_1x_packed.frag @@ -66,6 +66,7 @@ uniform vec2 tex_bayer_first_red; uniform sampler2D tex_y; uniform mat3 ccm; +uniform vec3 blacklevel; void main(void) { @@ -213,6 +214,8 @@ void main(void) vec3(patterns.y, C, patterns.x) : vec3(patterns.wz, C)); + rgb = rgb - blacklevel; + /* * CCM is a 3x3 in the format * diff --git a/src/libcamera/shaders/bayer_unpacked.frag b/src/libcamera/shaders/bayer_unpacked.frag index 06d80f3dd..f0d8cd1e2 100644 --- a/src/libcamera/shaders/bayer_unpacked.frag +++ b/src/libcamera/shaders/bayer_unpacked.frag @@ -25,6 +25,7 @@ varying vec4 center; varying vec4 yCoord; varying vec4 xCoord; uniform mat3 ccm; +uniform vec3 blacklevel; void main(void) { vec3 rgb; @@ -108,6 +109,8 @@ void main(void) { vec3(PATTERN.w, C, PATTERN.z) : vec3(PATTERN.yx, C)); + rgb = rgb - blacklevel; + /* * CCM is a 3x3 in the format *