From patchwork Wed Dec 17 10:01:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 25578 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 99365C3257 for ; Wed, 17 Dec 2025 10:01:57 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 1A4B061A4E; Wed, 17 Dec 2025 11:01:57 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="VWDyT45H"; dkim-atps=neutral Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E457E61A3D for ; Wed, 17 Dec 2025 11:01:48 +0100 (CET) Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-477b5e0323bso2172825e9.0 for ; Wed, 17 Dec 2025 02:01:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765965708; x=1766570508; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FdyTcK0Xun67yTvAExHcO9DNNAcWNw/aYg3LzuhT/Zc=; b=VWDyT45HrpY5ZzxUwXtHCRQvGY1Ro49pxecPz8+QU+V4iZefnIrS7UnXHALWm0eDA0 oQsvisdYS79DjaZ6RP7BZBXuQrVwQJgRI07hKE22CYToMRUpgjfjEfqvQnaXJDH7jyis OHFj2Wp4FC+kAVDPu2lfmSv4X1HU7OV4awzGfGGuH2ml1iEvEGYx7lm8y7pw9Lq9JreR p//EhyfeQ3INRgOsGexcVKWBtfWe0hDOqi7IIns898vQPhmu2VAaqLgoHwzdkxdZQ2t4 KNaWUJvUvIxC9kC1DOl9ACgYEl+KA96Z6zOEcIeESxpLkYm+c2JzOLgVnfSuruYJdj1P FvNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765965708; x=1766570508; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FdyTcK0Xun67yTvAExHcO9DNNAcWNw/aYg3LzuhT/Zc=; b=gKMm7yFVBpbcHt6Lio0OR+xlWF0hTErDuu1veUuPRS6XtuLsVSKgMAyl5AEOd3Fyz/ /M6JKswmLVALfN3eztiyIi6VonZiKX9sqJwtp0SWbO88Xy1AkyywzlYehQ+5ZBkpZkGm N49v9KAUeiips9roUV0awX8ZesI+cKR8BCqTHJr3gNOftKx67DkJ/W/UHv0pfT10qfn9 j62LloQmPEWGlPJcaiGT0Dx22fgsv2qNNhv+hZu0I8CeIXBG6zeSZOpLEh+u8i9LJN47 21nui5lsCM2DoZDrwNOvAc7LkOlRSPd78P/0RGgEi6h6vGuTetDeBBnXIcf8L/H/LaTN TcFw== X-Gm-Message-State: AOJu0YyVF4pBAZdaENXflkjpSjkcusH//FlrIAvx1N0gQ364/Dc0NwmA bcmYJ6SLpl8n0sF42HewJmke6EBpKLxUnVptajALLzaJbE9E1jtVUAUykOYHc3GIDdPbTh6LU6x 37epD X-Gm-Gg: AY/fxX6GkXnSCuFgkkmH5XVQUWgcMYWKWx66xBE0cAAyK1NSLH4wBf9c5VtQ4ZSCHiu I3ljgkwicHA7Eo8aLSuSP9J1lZkvFb+ssbJ3ed2lUCRWT0yAYxp4f3ZdHwxu8+C3p7QwvyyYHkm TWhFdWpm7UXqcl7RoCKl729K9bHk43MqlMfLvlnDzdHrwYWdsHxDqxdBGwZYs7+/8uFqrcXg7UZ vSVeN2+QPEdibS43LHwwrakgOmVvn/Y5+nxzLLT1kmxcD7mRuVCLRWZDle+HZ7V7EL1zgG/bIuH DbI9dZpUl/ls3uaDIJpuI8tSCoRVP2Wj8yF7/FG/Z50Wg8qaCAi1o4M9b72E04/BKIFV9dsf2N4 53wsz5W7ubcmzkudJLnY9+jm1LsVyZDLtkBvjzghZ/mGXZULPry1A/2c8PJv59+pwWmOhGzrDh5 u5KZ3g0cb3g4gTj0kg1FSyhAxLGdwUrE762y788zU3oB+0eoOc9QmKZjlVxWJSV6s1H9g= X-Google-Smtp-Source: AGHT+IEGMus0Lj9mZ/7/h+by8HdYLmyjW1yaD+loaJEGH6yIYYLtUsHG9SoBNSjrzsqU8QqksFao0A== X-Received: by 2002:a05:600c:2218:b0:471:793:e795 with SMTP id 5b1f17b1804b1-47a89d2c84bmr145323825e9.0.1765965708090; Wed, 17 Dec 2025 02:01:48 -0800 (PST) Received: from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47bdc1583fbsm32292585e9.0.2025.12.17.02.01.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Dec 2025 02:01:47 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: pavel@ucw.cz, Bryan O'Donoghue , Kieran Bingham , Milan Zamazal Subject: [PATCH v9 05/26] libcamera: shaders: Use highp not mediump for float precision Date: Wed, 17 Dec 2025 10:01:17 +0000 Message-ID: <20251217100138.82525-6-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251217100138.82525-1-bryan.odonoghue@linaro.org> References: <20251217100138.82525-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" mediump gives 10 bits of mantissa as the resolution. At higher resolutions 10 bits of accuracy is insufficient - for example at a width of 1928 bytes we need log2(1928) = ~11 bit resolution. Switching to highp gives us 23 bits of mantissa giving a sample width precision of about 2^23 ~ 8,388,608. Acked-by: Kieran Bingham Reviewed-by: Milan Zamazal Signed-off-by: Bryan O'Donoghue --- src/libcamera/shaders/RGB.frag | 2 +- src/libcamera/shaders/YUV_2_planes.frag | 2 +- src/libcamera/shaders/YUV_3_planes.frag | 2 +- src/libcamera/shaders/YUV_packed.frag | 2 +- src/libcamera/shaders/bayer_1x_packed.frag | 2 +- src/libcamera/shaders/bayer_unpacked.frag | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/libcamera/shaders/RGB.frag b/src/libcamera/shaders/RGB.frag index 4c374ac98..724395894 100644 --- a/src/libcamera/shaders/RGB.frag +++ b/src/libcamera/shaders/RGB.frag @@ -6,7 +6,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif varying vec2 textureOut; diff --git a/src/libcamera/shaders/YUV_2_planes.frag b/src/libcamera/shaders/YUV_2_planes.frag index 1d5d12062..d286f1179 100644 --- a/src/libcamera/shaders/YUV_2_planes.frag +++ b/src/libcamera/shaders/YUV_2_planes.frag @@ -6,7 +6,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif varying vec2 textureOut; diff --git a/src/libcamera/shaders/YUV_3_planes.frag b/src/libcamera/shaders/YUV_3_planes.frag index 8f788e90a..8e3e0b4a5 100644 --- a/src/libcamera/shaders/YUV_3_planes.frag +++ b/src/libcamera/shaders/YUV_3_planes.frag @@ -6,7 +6,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif varying vec2 textureOut; diff --git a/src/libcamera/shaders/YUV_packed.frag b/src/libcamera/shaders/YUV_packed.frag index b9ef9d41b..3c9e3e397 100644 --- a/src/libcamera/shaders/YUV_packed.frag +++ b/src/libcamera/shaders/YUV_packed.frag @@ -6,7 +6,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif varying vec2 textureOut; diff --git a/src/libcamera/shaders/bayer_1x_packed.frag b/src/libcamera/shaders/bayer_1x_packed.frag index f53f55758..19b13ad08 100644 --- a/src/libcamera/shaders/bayer_1x_packed.frag +++ b/src/libcamera/shaders/bayer_1x_packed.frag @@ -20,7 +20,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif /* diff --git a/src/libcamera/shaders/bayer_unpacked.frag b/src/libcamera/shaders/bayer_unpacked.frag index 7e35ca88e..aa7a1b004 100644 --- a/src/libcamera/shaders/bayer_unpacked.frag +++ b/src/libcamera/shaders/bayer_unpacked.frag @@ -16,7 +16,7 @@ Copyright (C) 2021, Linaro //Pixel Shader #ifdef GL_ES -precision mediump float; +precision highp float; #endif /** Monochrome RGBA or GL_LUMINANCE Bayer encoded texture.*/