From patchwork Fri Dec 12 00:29:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 25541 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 397DEBD1F1 for ; Fri, 12 Dec 2025 00:34:46 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id E1D716191A; Fri, 12 Dec 2025 01:34:45 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="rrF9xmyR"; dkim-atps=neutral Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B53906191A for ; Fri, 12 Dec 2025 01:34:43 +0100 (CET) Received: by mail-pj1-x1033.google.com with SMTP id 98e67ed59e1d1-340c39ee02dso566198a91.1 for ; Thu, 11 Dec 2025 16:34:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765499682; x=1766104482; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Hi3XytMpe+nkrlzIOzSyi4eb7BfcFLWPKSiPZLNjUc0=; b=rrF9xmyRJpaYTojCjkrFlHUfRn3unJh3NRbZNe8CB6p90eIXmsJaqe808ayfip7aTY gFzlBRC3QMgwq5mqjwRKQ0vuZn8du96xFTlmpCpKmmaS2jTGIBtdeEoQlgqczmMgZOQm flwr5tAIW7sC6WEuLJl8QcuI27ouTzA8vaKFpMek/VTY+Mn0NSgoUTocHZGNy/TYxEse gy+Zu/IygsAyAcq/J4OyhkTXkspfFdZHj9243XilIng+mpPvEaltdEGe7eA02X1rBR2T kcqSGP0f4qmPEUGMCue+/0FApqu2gmpwXPy8nhrBFC7917m1tT0dKRt1xTBwMhEY/TSq 9//g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765499682; x=1766104482; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Hi3XytMpe+nkrlzIOzSyi4eb7BfcFLWPKSiPZLNjUc0=; b=e1+O7WIAxaTRcGLP/FqlDIyuf6kP+/Ey8f4z512I2kkVCs4rxrlWtvFHLOB5Qb0wzu mwa1Jv21ErQJJFUs1Ad7mKbNHxPlmgc8v9A1uArZ2Pr8jaUDtw2788XvWVBZc7ueiQjX ePNGRLdiRMrCgRoAivwf/DK1HQUIiZgvTwVj2iM1g9Xiicx48L0IPpx1g7cTjzPz68YM m3KnwspIdfP8gpK586LVKX4dmY1bOQZfKA8xe5qUg1ABC5LMfPdjdeEIBJRRhJEckEVC pWC6B5aHXH59UlDRhv0xQgaFd3YHfi1esvuu+kFREkyxuBhvKbZo+ZBqTQj4cUmSEeQE BiRQ== X-Gm-Message-State: AOJu0YxVBc4WjtSCwL7oFbe3F5g/VMSgFJLilqBFgH/hb2/bJy0Zewk3 foNFgUEBj2eKk7ZcINqptvagqBTM8/r4iZXquPGjPJVmKYgMOLHFZuwL7o0PEVz3horDEu+zmDV QS7nf X-Gm-Gg: AY/fxX5yJ09PfOUe3VYl9pDolGpRSHuz2zp6fbn4GVYWmYeUL/VSA3O3plujLSuNCSg a+0iPlOagtxFWdo4ERQwXfmXhyHwfDrIaywOGPfuD/0zNAky/Rci/0p9YfaMwPDTe6dhVk2N6rO ymKmRRdL65mRrY21Rse9L5RQTx4i3qP9GqJJlv5cOgWVrCpZYwZ6faunNoB0ypwyaCwcjyoer7y kA5uGLjZBkJT73DJhvNm21zwJAQkwt5+G0UcEu9ohf4t5GhK6bxEhUW+W2x9KsRS6lDoDCzdWbs /RwqtgGOYU0oB2/OAWwX5pYL2v+9Wk4AjgV8Zb1us37WpHKQnLWRLdRVuuxiiJfCNjoodl693B5 eglgSN9mZ5sZbORkXg4kLCoYOrCD3WwB0NcuYmedEvxhcuQpShRUoQOMl3XX8UVhR/qIwn6sDxh bS1TOiQ7H9/MXz6O+WilgWCyLmEKTK+CFI7D5bnz//N7QRlQnAMtWUVSaaXYw= X-Google-Smtp-Source: AGHT+IGp0lu5ISEAIWN0lq8iVQjVh7wDvdDBaoqv92xa7bFpjT9aDHNfUMOimWHheYdBeUAT04s5Kw== X-Received: by 2002:a17:90b:53c3:b0:34a:a16e:9fa8 with SMTP id 98e67ed59e1d1-34abd799168mr401688a91.33.1765499682022; Thu, 11 Dec 2025 16:34:42 -0800 (PST) Received: from inspiron14p-linux (p99250-ipoefx.ipoe.ocn.ne.jp. [153.246.134.249]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c0c26eb0f6bsm3317282a12.14.2025.12.11.16.34.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 16:34:41 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: pavel@ucw.cz, Bryan O'Donoghue , Kieran Bingham Subject: [PATCH v8 26/26] libcamera: software_isp: Add a gpuisp todo list Date: Fri, 12 Dec 2025 00:29:37 +0000 Message-ID: <20251212002937.3118-27-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251212002937.3118-1-bryan.odonoghue@linaro.org> References: <20251212002937.3118-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" List the series of things to do in GPU ISP in perceived order of difficulty. Acked-by: Kieran Bingham Signed-off-by: Bryan O'Donoghue --- src/libcamera/software_isp/gpuisp-todo.txt | 40 ++++++++++++++++++++++ 1 file changed, 40 insertions(+) create mode 100644 src/libcamera/software_isp/gpuisp-todo.txt diff --git a/src/libcamera/software_isp/gpuisp-todo.txt b/src/libcamera/software_isp/gpuisp-todo.txt new file mode 100644 index 000000000..e32d7dcf8 --- /dev/null +++ b/src/libcamera/software_isp/gpuisp-todo.txt @@ -0,0 +1,40 @@ +List the TODOs in perceived order of ease. + + +Denoising: + - WIP + +Dead pixel correction: + - WIP + +Lense shading correction: + - WIP + +Use dma-buf handle to generate upload texture: + - eglCreateImageKHR can be used to generate the upload texture i.e. + to feed the bayer data into the GPU. + +processFrame() to run in its own thread: + - processFrame() runs in the context of the Debayer::process() + thread. Robert Mader suggested and it seems like a good + suggestion too to run processFrame() in its own thread. + +Multi-pass shaders: + - This needs some rewiring the idea is to have a list + of algorithms as is done in cpuisp iterating through the + list in a for() loop. + - The logic managing the loop has an initial input buffer + and the final output buffer. + - The higher level logic must then inform each of the + algorithms either to generate an internal working buffer + or pass the final output buffer to the last shader + in the list + - This will allow for multi-pass shaders with the final + algorithm presenting data not to its internal buffer + but to the final output buffer + +24 bit output support: + - Need to impelment compute shader to do this. + +Lense flare correction: + - Not WIP still TBD