From patchwork Fri Dec 12 00:29:26 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 25530 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 28A21BD1F1 for ; Fri, 12 Dec 2025 00:34:13 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id CAA7B61895; Fri, 12 Dec 2025 01:34:12 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="kefycMXw"; dkim-atps=neutral Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9FB4361893 for ; Fri, 12 Dec 2025 01:34:11 +0100 (CET) Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-7b8bbf16b71so708990b3a.2 for ; Thu, 11 Dec 2025 16:34:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765499650; x=1766104450; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BO0mMIWhB901RhyMhEcHbc+LWlQiOyKCJvDrt0v6kXI=; b=kefycMXwwyy6vSv5z+Eaxx2I93RrSCBVESS4CwhovwopDTkTlF9cYsTPp0133PzQZW DCR4g9fv3zJ8XoRmp6k0qn46VHsQwdvKD/5Mai6iGnh/63s6DjhxGMAGoCfkMHIls5OY wPU66ZA62JSv4uaC1es5BCIG+roEzlW7GDKj34bpQlBYWMlji85V0FlCi6EpI9gnb4KA VIMomEFbcsrjKGBHz8tDDwdY0/rGHp/zyjJIQ7ZLhGVlP2d9HALKElkW83H8/NJOGtqm YZ5wew6Ah+HVXlhy8z+QQSsBnPF0UdHmTt0IagGathKw319l9MSxXmHPkV5+dPT5cHwQ qMqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765499650; x=1766104450; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BO0mMIWhB901RhyMhEcHbc+LWlQiOyKCJvDrt0v6kXI=; b=tQHM+Q9W43qvguCNZYoyQTanVtnHNpljuW9PbVUnM3t9yeiB1fR3QM/Bl/iU9HJMAD I85YwZiSf5QNAlWmxTEj3KMfiHeCz2ox4WMzq/zMlw2Dld/8Hz+g7i4zb5140GFupd0z /oQRBKl/kKaTqjCw4GKefkDdP1NQkpgK9b5Q7fTNxztWFXuz4sao9r5h7xzKtP11X+LR UBSTrk7yz6zVTpDzII4bWPs7bk03IM5+D0PWTpj4uvbdUKiHcy6AQCoA7x5mjttysdR5 sbgNxfIlTjDJMtOowgVU55HSIhFUERGrBfwVBC/RG4d2axTDQdoTdWXikxCeDNDlkZ1J 05Hw== X-Gm-Message-State: AOJu0Yym20mPxR6TkMjzWU2LX33b+Nw38Nqe2pC3Mn3G3saiRYcJjGpu zzQwi2/k4bGo9sHqPd5iIkwVIdhj2mdK7nEcg5946n3pyC6KE6EouEE4bMoIU9pUGZthPokiCD4 HL64d X-Gm-Gg: AY/fxX6tDO+BK36UkmJlTyAfV+xzEemoOYbOMjeILylp4xXW3Feiq58jkCO/j9AEYl6 xtHraEu3+mofYHXUA4ws7kQZhx/Q/BPhcZNTaR8DteGPeo5/IykfOYm+vNxSui190+Ei+/IAwGC p+cOdoYkdmKgfTTT9CrHOkv1qJzeSrme3LuEFPo+C7dvrjv8cFT7SsIp4gxBWs8n6b/xZdla9KK wXGyURJSO+pBjIJ+a0a3RDo3s2nC54CifLFF+qfJCkUCGa42OcPfd2BQ3yEjrHQR5cS9SM06lpn HUbZbuldB/3BQYffbYjGN/3E8NgubDKN1521CuQhGblZh88ekeIEiNeKmOAX9CJvUtCmlH9E49w WiLLI+WjHPxYhlLg1aRiYm39STJ6V8c4bK/5/g1YrGMgGY2PmPhvG8cf79SAjyxXPpa+lhSPZrq 7njRKDo8gnSRb5w0zKehKiFH97ZGO/Nu/5OJ/tdvx39XE7lQByI/rpc2nqZQ4xLM54XZJdeg== X-Google-Smtp-Source: AGHT+IGFVP2FsOQP694q5fUy5q61F6m/fkJa1QgQxpkygT+Jy0DKS3Q0omxk4n99ytA3oGdiFrWPUA== X-Received: by 2002:a05:6a20:9155:b0:35d:d477:a801 with SMTP id adf61e73a8af0-369b4335469mr254933637.13.1765499649948; Thu, 11 Dec 2025 16:34:09 -0800 (PST) Received: from inspiron14p-linux (p99250-ipoefx.ipoe.ocn.ne.jp. [153.246.134.249]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c0c26eb0f6bsm3317282a12.14.2025.12.11.16.34.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 16:34:09 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: pavel@ucw.cz, Bryan O'Donoghue , Kieran Bingham , Milan Zamazal Subject: [PATCH v8 15/26] libcamera: software_isp: debayer_cpu: Make getInputConfig and getOutputConfig static Date: Fri, 12 Dec 2025 00:29:26 +0000 Message-ID: <20251212002937.3118-16-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251212002937.3118-1-bryan.odonoghue@linaro.org> References: <20251212002937.3118-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Make getInputConfig and getOutputConfig static so as to allow for interrogation of the supported pixel formats prior to object instantiation. Do this so as to allow the higher level logic make an informed choice between CPU and GPU ISP based on which pixel formats are supported. Currently CPU ISP supports more diverse input and output schemes. Acked-by: Kieran Bingham Reviewed-by: Milan Zamazal Signed-off-by: Bryan O'Donoghue --- src/libcamera/software_isp/debayer_cpu.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libcamera/software_isp/debayer_cpu.h b/src/libcamera/software_isp/debayer_cpu.h index ecc4f9dd0..67df2b93a 100644 --- a/src/libcamera/software_isp/debayer_cpu.h +++ b/src/libcamera/software_isp/debayer_cpu.h @@ -97,8 +97,8 @@ private: template void debayer10P_RGRG_BGR888(uint8_t *dst, const uint8_t *src[]); - int getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config); - int getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config); + static int getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config); + static int getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config); int setupStandardBayerOrder(BayerFormat::Order order); int setDebayerFunctions(PixelFormat inputFormat, PixelFormat outputFormat,