From patchwork Fri Dec 12 00:29:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 25527 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 8A293BD1F1 for ; Fri, 12 Dec 2025 00:34:04 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 408056168E; Fri, 12 Dec 2025 01:34:04 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="tS2Sclc1"; dkim-atps=neutral Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 59D74616A1 for ; Fri, 12 Dec 2025 01:34:02 +0100 (CET) Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-7bb3092e4d7so736513b3a.0 for ; Thu, 11 Dec 2025 16:34:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765499641; x=1766104441; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Gq8OF1ZTHYJ405oahlUP/ID9xX8JXtEW/1dvjN5qFO0=; b=tS2Sclc175vHGHUF9PKqXZs6kX86O2IXeEta+13JIuW7agr+0Zj6oQn1eenl5uA1Yy pKP5vArUnQmeYLaSOZx51a+jO9GMad8V/YYZZaG9LU+bUo4NuJu1rUEpaOgrSM7K2iAM v3NkKVrCtWNL9UZtJ9z63sV1/M2ghdDxMLJW/eyczVy0ceFjh/2Qj/yIAEB4cUWGFc6E r1buaJknEYD2QYJZPwoUK6EA289145vjZbTENnJN+l9of1BS/pJqApQ/annfsgmuXSgJ alycR4NNJv7B1ueyBq1GTuzujJPBqFlkpxmLJQX5vMLdnFzxaX8eCa+ZnvYsXdIVeXmJ 9Dng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765499641; x=1766104441; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Gq8OF1ZTHYJ405oahlUP/ID9xX8JXtEW/1dvjN5qFO0=; b=utWBnCxpXh2Y5ohTokzyIHRVw/kOJ0UefDFLAN/ikpyqXZvw5NNyRXWCc9lJOpJpZ6 bdMCWj3oebnRi0lIyS3p6ZfbJOg8JgH26gjoJNZ11+GdS+Ph8Yqc9ceNsqKBYOm0be26 rHWTd8wrXvt/eyY68SDx+Gwj8GArvnb/UqoJKLxJOJ9nTkZE2NtQaKzyo+jLjd/zkq+L B3BR0qlOKVtZCapFm4QoQNRHEanrPcSbsdbuTp3DbzDvF3dAVzgGLlhi63rtwmLUx4A0 4tLYFPMZzvNCj0r3Wc3vZh5pnnhFKsJVsxNACXnyTEqZaFTiwQ8EjrrB08OoiSu5dGhi ZMqg== X-Gm-Message-State: AOJu0YzzVp3GmKRccNZ6cMLUQ4s0k1by6JQMg+cUPqIj/laHcULLgpKG ReAHZxfQZBxtfLrSPSZFvAbG4ZVLX7sRBVZzIBryRZVt9rwNOhyrX7+z6WOYeD/GNIc5buVBh0T E5/Hl X-Gm-Gg: AY/fxX7GT4sZwljeQRvkuw1ThO0PCqjsb+Vko6rv6cBar4F3g6ltaR+fMG1hy8LPN/9 XkPmu8KY2BgcDmGjHADQZoVcmtHZ1hBnhAtZ3vQKoaVnwFHhN1a+gM3GcU+bcAgKzkrS/TDk1W2 IvTgsiHWyaVzX+HGBVGi4muWBc4m7SvpIKfzmVsvPlK/09X7w6bA0+dPaN77gCRPYzXgAaJit/w HBSlBdahaL73Gn0UuFPy88COq33Z0DL6+GmfP7E7hguLTn/EIhwnkgmMaJpewrdbKrKKoA4SyjA QjNEMiNSd37zIqF6F0mbXkpB/ARCUncK8Zhmcd8QiPmhks0MoAUqD+TDq/817OBKV9b5zFjihG6 YWierXKxjSccFT7fgCe5vRjmQuUBkh2Vh5/H5kY3ZEunsrE8C5g/UJYuSRdRhoi9nNg8P3qp32k sivjj+e2E2BBK+PzNYbLyHELK/4NQwmqYTOOpJGFVsK92/10sm3dDo9+MGWx4= X-Google-Smtp-Source: AGHT+IGJw7ktuIRIhe011Q+dRTO1PrrcDwX/QttGohTh9LcfK/+2oAzm2Jfh1IUVvAPlvkjpzDh5sw== X-Received: by 2002:a05:6a00:2883:b0:7e8:450c:61cc with SMTP id d2e1a72fcca58-7f671f413b8mr260249b3a.60.1765499640694; Thu, 11 Dec 2025 16:34:00 -0800 (PST) Received: from inspiron14p-linux (p99250-ipoefx.ipoe.ocn.ne.jp. [153.246.134.249]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c0c26eb0f6bsm3317282a12.14.2025.12.11.16.33.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 16:34:00 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: pavel@ucw.cz, Bryan O'Donoghue , Milan Zamazal Subject: [PATCH v8 12/26] libcamera: software_isp: Add member variables to track selected input/output pixelFormat Date: Fri, 12 Dec 2025 00:29:23 +0000 Message-ID: <20251212002937.3118-13-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251212002937.3118-1-bryan.odonoghue@linaro.org> References: <20251212002937.3118-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" In order to have Debayer::start() tell the eGL shader compilation routine what the input and output pixel format is, we need to have a copy of the selected format available. Add variables to the inputConfig and outputConfig structures to allow tracking of this data for later use. Reviewed-by: Milan Zamazal Signed-off-by: Bryan O'Donoghue --- src/libcamera/software_isp/debayer.cpp | 10 ++++++++++ src/libcamera/software_isp/debayer.h | 2 ++ 2 files changed, 12 insertions(+) diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp index b5b99d390..4e6fa3d74 100644 --- a/src/libcamera/software_isp/debayer.cpp +++ b/src/libcamera/software_isp/debayer.cpp @@ -290,6 +290,16 @@ Debayer::~Debayer() * output image buffer. Set during stream configuration. */ +/** + * \var Debayer::inputPixelFormat_ + * \brief The incoming pixel format + */ + +/** + * \var Debayer::outputPixelFormat_ + * \brief The output pixel format + */ + /** * \var Debayer::red_ * \brief Lookup table for red channel gain and correction values. diff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h index 5c0cb3914..4a2ec3e53 100644 --- a/src/libcamera/software_isp/debayer.h +++ b/src/libcamera/software_isp/debayer.h @@ -75,6 +75,8 @@ public: DebayerInputConfig inputConfig_; DebayerOutputConfig outputConfig_; + PixelFormat inputPixelFormat_; + PixelFormat outputPixelFormat_; DebayerParams::LookupTable red_; DebayerParams::LookupTable green_; DebayerParams::LookupTable blue_;