From patchwork Fri Dec 12 00:29:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 25523 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 52D85C326B for ; Fri, 12 Dec 2025 00:33:51 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 1ADDF6166C; Fri, 12 Dec 2025 01:33:51 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="iKWpHqv/"; dkim-atps=neutral Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9880A61635 for ; Fri, 12 Dec 2025 01:33:48 +0100 (CET) Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-7b6dd81e2d4so696588b3a.0 for ; Thu, 11 Dec 2025 16:33:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765499627; x=1766104427; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5qjoeAop1GzrvnIG7vvLvJkbwSmYKtE+YPe2MFgINpo=; b=iKWpHqv/7DcRhOGlktoHAWFS/MYdjodoqwQOkYIiMqMezEQMWiHuq+gZvplcMKp6H8 G6uLiQn7JKdHBJXLhjLFCvw0F+KTCZx+Jc5VgeZvW1L7ZB8Rnhhc4Lt4KpiDpX2lcwn/ K2iwFnDkeiGfel3loAabfJjXQdWxI2vwH8QggbC2pRpAx+zFQEajSOMepIk//Rk+aWff eqqdsyeqfZEK9xP3aF6DNrjp8q88UBUnVx1fjjU9R7kF5RTPQrc442Ev0DikbGP6l1yk Is3hZWefBER075nxZNc5g2xNGUbY4eC+1u1ynAU4U0PaKUmeJmoQzV/x7zGWaaF2OpdX BHJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765499627; x=1766104427; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5qjoeAop1GzrvnIG7vvLvJkbwSmYKtE+YPe2MFgINpo=; b=ve7RyDyhI3rrMgYfXj6yc/7xGcwNmih7hYuRKPWIrki/uXkR3y73M9vok9MuScr+1D FgZ0cOf7yWgGxwcKQm+RfPQiOqHaJvc2iK6c4Q1373liUzw9ymPoTc5eI+wi6PH7wd3s tgUwavmAY0oQVpL25P/hjRVv5pw1oGzyFTppFIwBUCRv89/X7uiFcfLgq3AtHc902TBq Lcw8rb408r0yW4rkIfLGfOs6ZK4L4Yue6M8COltl6riQG01qqK7VPZ3EqwcudHZ01WXV aogxuYVpiuZTPqUxjsrITX9kz0ZMlvHShu/WcJgJnVIYi0p5NuHgJiLM8aRFkXl9t8hh SyQw== X-Gm-Message-State: AOJu0YxwnMiCubqrsb+ikVcmzhJwlYSpoXQPm5ZORAPYuu+JrA3UfgrH iI/0ebYk1d7vtp93+wN0/nuvbqdzmhKv/rkucjp//FXH+kaTt+gz75QNA/+7wsURcSH/oK0q6r1 42gV3 X-Gm-Gg: AY/fxX7w4ZOVyuG2giP8jwgzdFMJDlqE1EAsV6Uo+0hyIeuqFNKCBC5tqydD7ocxjed 97vJeKzRqi9OvPdZ5D3DBP420GDvF6jb7oEsjui0suEFt+kn7nr/TD5XkkV0COv0FZX1MzNFIOq /yuvNVuMkXXF2Ji4gOwXYg17KV5kYwqR5zlXA7dsC197dhw5YOkS3taAtOa7+OPTRB2tnfsWa+G 0nr5ZS0wbvH7KRpi6Xd+21TkzY1/jMHlEL7hs0UvoErrecAmu3XCR0PjtzIE0BBFPI/6BZ0Txz5 mTB2Q3vpbJvHvutiMhu3DFMZcuGvTI1pejF0MwCsmj5/ntPOUkoVlfAvo+mZMVeKx1F3OYCEKUt Wd9D3ATynU46n2FGxqeV4n2Z/r5JPENs7JXWFRGHe7sTINnVeeJekrWsKUuRNu7MrkLw89nVtfY Ffd8RenHqDdn7bd50Mhh69IDgimr8fOa87ANX83qsyhyK+cZNh7c+fC0dutZPQQd2YNC/7TQ== X-Google-Smtp-Source: AGHT+IHFdaAI1TlPzI5mnhQQqiVPYeiHHHbFB4r36z7dUCqQ5NUOE0dK6SJd0G9qHoQm9ReTdZ+mgw== X-Received: by 2002:a05:6a20:7344:b0:35e:7605:56bb with SMTP id adf61e73a8af0-369b00eaa8bmr331731637.59.1765499626932; Thu, 11 Dec 2025 16:33:46 -0800 (PST) Received: from inspiron14p-linux (p99250-ipoefx.ipoe.ocn.ne.jp. [153.246.134.249]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c0c26eb0f6bsm3317282a12.14.2025.12.11.16.33.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 16:33:46 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: pavel@ucw.cz, Bryan O'Donoghue , Milan Zamazal Subject: [PATCH v8 08/26] libcamera: shaders: Add support for black level compensation Date: Fri, 12 Dec 2025 00:29:19 +0000 Message-ID: <20251212002937.3118-9-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251212002937.3118-1-bryan.odonoghue@linaro.org> References: <20251212002937.3118-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Add the ability to apply a int blacklevel gain against the demosaiced data prior to application of colour correction data. Reviewed-by: Milan Zamazal Signed-off-by: Bryan O'Donoghue --- src/libcamera/shaders/bayer_1x_packed.frag | 3 +++ src/libcamera/shaders/bayer_unpacked.frag | 3 +++ 2 files changed, 6 insertions(+) diff --git a/src/libcamera/shaders/bayer_1x_packed.frag b/src/libcamera/shaders/bayer_1x_packed.frag index db8c2a0b3..7036fe278 100644 --- a/src/libcamera/shaders/bayer_1x_packed.frag +++ b/src/libcamera/shaders/bayer_1x_packed.frag @@ -66,6 +66,7 @@ uniform vec2 tex_bayer_first_red; uniform sampler2D tex_y; uniform mat3 ccm; +uniform vec3 blacklevel; void main(void) { @@ -213,6 +214,8 @@ void main(void) vec3(patterns.y, C, patterns.x) : vec3(patterns.wz, C)); + rgb = rgb - blacklevel; + /* * CCM is a 3x3 in the format * diff --git a/src/libcamera/shaders/bayer_unpacked.frag b/src/libcamera/shaders/bayer_unpacked.frag index 06d80f3dd..f0d8cd1e2 100644 --- a/src/libcamera/shaders/bayer_unpacked.frag +++ b/src/libcamera/shaders/bayer_unpacked.frag @@ -25,6 +25,7 @@ varying vec4 center; varying vec4 yCoord; varying vec4 xCoord; uniform mat3 ccm; +uniform vec3 blacklevel; void main(void) { vec3 rgb; @@ -108,6 +109,8 @@ void main(void) { vec3(PATTERN.w, C, PATTERN.z) : vec3(PATTERN.yx, C)); + rgb = rgb - blacklevel; + /* * CCM is a 3x3 in the format *