From patchwork Fri Dec 12 00:29:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 25520 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C6ACDBD1F1 for ; Fri, 12 Dec 2025 00:33:40 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7B7BC61668; Fri, 12 Dec 2025 01:33:40 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="Kd5A36sM"; dkim-atps=neutral Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 52DB161613 for ; Fri, 12 Dec 2025 01:33:39 +0100 (CET) Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-7b80fed1505so702460b3a.3 for ; Thu, 11 Dec 2025 16:33:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765499618; x=1766104418; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FdyTcK0Xun67yTvAExHcO9DNNAcWNw/aYg3LzuhT/Zc=; b=Kd5A36sM/n0QakJIRzCM2UpTm5YIhWpIZeAFU4VFMFnSpGcYETz2AQbLIqj+5C/SrP afHP2nYd4eb45CCd9YQdilqT2wVm+HHd1S2DAM1U3wqCHEVb33Pea7epW/4+UQixEHG4 XQ6yvOKSyBjbZVDz+20WIeh635KsFbL9dyPFWr0qKxG+GMqoYmH7TenTSXGd34d3NmGH 8V1Yhe8AzpuklU0l1akiHLiWzWa/AMhMzKNxbsM0AAi1ERpIW2p/cnyRTvakkyrOZXdp H5obWOf6jOdplrGg7n55h/tRjA/02sScIMJIlmbkKn8ljjDhfdtTr3KrWDx3O2prNZWF Q1Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765499618; x=1766104418; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FdyTcK0Xun67yTvAExHcO9DNNAcWNw/aYg3LzuhT/Zc=; b=Dx880Fi4KIH+rlPopJI1DDZ/eQ8JXAygrVdxwR48qEoFulS+ElaNotSdoVbRKsqHjP 8KUyGrBnmoKNwsgdqkpdM0RCIac26ojb8M5dNKOfCEi3+4PDUNaa32AGZDMwY0YME49O jSTr/ydTS6Xge84iH6uqtNPnRptR/MF86TSJO/pQPST86jYViAMp3I322E9N/o5Lgk+S l0hpk6Vqgd2/YQPhtUrOzfw9eLmK3r5sjOSQk51Y69818la808Q2Zpb4LDgGkHRoHZS6 vKkNsAZU8BsgxhKbXUVwG/eHirZXaBCLuarr+WzrrMt/uj9SHmJaY4dKuIrPrnjXEHUf GBUw== X-Gm-Message-State: AOJu0YwrpfncTC5T6Q3DfxHyWXBjKOnm+sqjo89PAIEQnJYJGMtXy0On fz2PNexiV8qJP1B2LGu4P8RkTiNSRJvDpmrC7xsAthUt4YVLcIIgDhd741PrpslQTgXfxkkCodf 2Vs8j X-Gm-Gg: AY/fxX46zMk1ORCLOU+wVcXvUHCb4iaoxFjQS0QvdXiYa5f9EkK7Qz1fFiFksrGmYP5 hm4G5m42k95BBvS9H1/NQfHk/J3Me97rcvdd+UGvdDFguGdBAlhrJa2NuWSEixn8MhkLHhO9QVk BYWMg07MnH+M39eW4ajQOcxdUwTkodsZGQKFnos4XaJ6BiOTci2oELvetuiWmaYCoSryOPQ666O eJTxpYP1+ZyJQ2m5Ts+kEtUSiDXLgop4fC1fc+ePcCpWvnohyYrHegWGwf/F+rX+JLsVNnD0uoG bcbNnLOxJGixJ/vgdUAoMIB5fyGgbXAjD7/8KCmSSIWWkEWrujqf+lCbroGkMwarT8rpAnqF89h YE8eDWSTy5uOnF3x8EDwCwlXR83tOwBztr3t7H0Kjtr8sXULCkgJofVshm8c8TQdIXwMbSv269z sls6eapYUi4uUktkVRr2jXWfNhdXWOGrGSJ1fLa+UUu7XammQag9uo1CsnJlU= X-Google-Smtp-Source: AGHT+IFneNeD0CzS7tRSKSHPz5TD+SUN8ZRmcHdKHiOYddMfUuBaRWjQM4pCTrtMs8qInAhNsXFTUg== X-Received: by 2002:a05:6a20:3d8b:b0:35e:11ff:45b4 with SMTP id adf61e73a8af0-369adfb3407mr290384637.21.1765499617627; Thu, 11 Dec 2025 16:33:37 -0800 (PST) Received: from inspiron14p-linux (p99250-ipoefx.ipoe.ocn.ne.jp. [153.246.134.249]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c0c26eb0f6bsm3317282a12.14.2025.12.11.16.33.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 16:33:37 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: pavel@ucw.cz, Bryan O'Donoghue , Kieran Bingham , Milan Zamazal Subject: [PATCH v8 05/26] libcamera: shaders: Use highp not mediump for float precision Date: Fri, 12 Dec 2025 00:29:16 +0000 Message-ID: <20251212002937.3118-6-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251212002937.3118-1-bryan.odonoghue@linaro.org> References: <20251212002937.3118-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" mediump gives 10 bits of mantissa as the resolution. At higher resolutions 10 bits of accuracy is insufficient - for example at a width of 1928 bytes we need log2(1928) = ~11 bit resolution. Switching to highp gives us 23 bits of mantissa giving a sample width precision of about 2^23 ~ 8,388,608. Acked-by: Kieran Bingham Reviewed-by: Milan Zamazal Signed-off-by: Bryan O'Donoghue --- src/libcamera/shaders/RGB.frag | 2 +- src/libcamera/shaders/YUV_2_planes.frag | 2 +- src/libcamera/shaders/YUV_3_planes.frag | 2 +- src/libcamera/shaders/YUV_packed.frag | 2 +- src/libcamera/shaders/bayer_1x_packed.frag | 2 +- src/libcamera/shaders/bayer_unpacked.frag | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/libcamera/shaders/RGB.frag b/src/libcamera/shaders/RGB.frag index 4c374ac98..724395894 100644 --- a/src/libcamera/shaders/RGB.frag +++ b/src/libcamera/shaders/RGB.frag @@ -6,7 +6,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif varying vec2 textureOut; diff --git a/src/libcamera/shaders/YUV_2_planes.frag b/src/libcamera/shaders/YUV_2_planes.frag index 1d5d12062..d286f1179 100644 --- a/src/libcamera/shaders/YUV_2_planes.frag +++ b/src/libcamera/shaders/YUV_2_planes.frag @@ -6,7 +6,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif varying vec2 textureOut; diff --git a/src/libcamera/shaders/YUV_3_planes.frag b/src/libcamera/shaders/YUV_3_planes.frag index 8f788e90a..8e3e0b4a5 100644 --- a/src/libcamera/shaders/YUV_3_planes.frag +++ b/src/libcamera/shaders/YUV_3_planes.frag @@ -6,7 +6,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif varying vec2 textureOut; diff --git a/src/libcamera/shaders/YUV_packed.frag b/src/libcamera/shaders/YUV_packed.frag index b9ef9d41b..3c9e3e397 100644 --- a/src/libcamera/shaders/YUV_packed.frag +++ b/src/libcamera/shaders/YUV_packed.frag @@ -6,7 +6,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif varying vec2 textureOut; diff --git a/src/libcamera/shaders/bayer_1x_packed.frag b/src/libcamera/shaders/bayer_1x_packed.frag index f53f55758..19b13ad08 100644 --- a/src/libcamera/shaders/bayer_1x_packed.frag +++ b/src/libcamera/shaders/bayer_1x_packed.frag @@ -20,7 +20,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif /* diff --git a/src/libcamera/shaders/bayer_unpacked.frag b/src/libcamera/shaders/bayer_unpacked.frag index 7e35ca88e..aa7a1b004 100644 --- a/src/libcamera/shaders/bayer_unpacked.frag +++ b/src/libcamera/shaders/bayer_unpacked.frag @@ -16,7 +16,7 @@ Copyright (C) 2021, Linaro //Pixel Shader #ifdef GL_ES -precision mediump float; +precision highp float; #endif /** Monochrome RGBA or GL_LUMINANCE Bayer encoded texture.*/