From patchwork Thu Dec 11 23:22:44 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 25513 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 4C685C3257 for ; Thu, 11 Dec 2025 23:24:18 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 02CB661698; Fri, 12 Dec 2025 00:24:18 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="gmVi/gSP"; dkim-atps=neutral Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id B222A61623 for ; Fri, 12 Dec 2025 00:24:16 +0100 (CET) Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-7b22ffa2a88so659098b3a.1 for ; Thu, 11 Dec 2025 15:24:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765495455; x=1766100255; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1/Ms2jejD2I8EStEsni5WUE0UOgduJv8CLqlNoVAcNM=; b=gmVi/gSPGUEnD5J3QO2z/YLI10yk3DJ8me6apPDa8i3ojz/5Mp5zQMORYiFl0tupYO OGG1DSMXsllTHzPuSbqoqzIWfgJrPrm57W5Gl/mZglaR4vR1RLRXuwUb5qgahbsU796X 84QSjv8SFhaogxPrBWgQuvd8LOTfnLoZv60rDjaSMtASAkNl3s2a3uP2lKNocafLf2fB /q2e9iB3N1v6IzV8b/ILLsJtHrItoKR4GyfrkF0ZUS6umB8Sa/nM1K98SKsn8w8jvhaq qPVMAqLMnwcQRgF3BOd4oXhglXMBXyqRrT75t/X/J6jeDVijgi4cC1zxGTA5vBdJV5q7 RAZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765495455; x=1766100255; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1/Ms2jejD2I8EStEsni5WUE0UOgduJv8CLqlNoVAcNM=; b=HgcGoJi68g1uOM0aoz8h9mvN2GjksG1g++6RD4Sgivo3ZNwwurxzu7x7IR16RdH9bU ENGYCGKLWtP/+LpDpIkiRucVFQqu+I4k2zAOV9AMl6DnEnH66vgm5BequkHd66K97SIA bh167ord7I6DsSB59FNRjfsl1ZfclIfoS1DViNubDmqab2coaByMGx1XR3bxL+Ibzqjk aNfl5pvi3RbdvHbn5GhwOpyFS+hpCovFCDl+BYsjI8jw3o1Cc2ysYbdQZevopScU04Nk tVqYpjEDDRYQsJrPN63lNrGvFsPdPkT15hDBhe8wbyfUvtv9/WxRQMVmCYnX4j3r/aW+ Vdgw== X-Gm-Message-State: AOJu0YxCLJ/o9emhRjE1ynY2Q4O7ca8dQbZqo2QXgkKy7yO2X9vpo0Rx RUxGg6EG4OPhSkHNjAm+wXSHUmgokBA3ARbAzjlNysXw4uGscQAwpKFtc4Zrj7FyX7sL1+h8ubB OURVW X-Gm-Gg: AY/fxX79GCR/Wym/O/ZXZP13QlYHWoNZACmA2RNPob37s2H0MrXF5JNjjSDyKIrM54z s2kwGfiBu4uCbwgLdZFJoR+XxrNT3/44ly7ZPxNR9wT3VYkcERV7e+h7HHW+KMssfVqrhHTx/qO f3HB39LB/PT/QqruagQLQsSU0B9D3ypyApP2hFyCHDqZdV4xu0/ZEOrde0WoomdMtBpml+yJ6hI XV1Lr9dralSpiKKbhcckn2uJ1ml/z4H3GdhQvNpI6FDDVq4BhAuX88p4cyonxLQBonpDl5ZpGxQ Y9rosPUi48de2JzQlFmmD8M6DXsLRgfX2M9SrrxeisqGcm2alKcg4Umd5UefW29wUGVqEKZDf2T GdikGFF4veDa+BbRcMo0Qv1jv54y/P4xYcLgWyYMj2Kzg8MW3VUkctSGv2YrcoB0UBusqWRkr5t Gf6ITB4WEA4Emj2X4g2uGw8KXM9SvYIONnLqkr9/Pf/2gRtSQj503BVQsI3edvK6dX+Hl0hFMx X-Google-Smtp-Source: AGHT+IEm1nYyD1B2mSKAmnwW2T8bDF7qTl6Px6NhFXL7cDsGKTNIapHQDhC+dE2Y6Fz5Y6oXGBRTwA== X-Received: by 2002:a05:6a00:b904:b0:7e8:4471:ae78 with SMTP id d2e1a72fcca58-7f66a07dac3mr165930b3a.68.1765495455073; Thu, 11 Dec 2025 15:24:15 -0800 (PST) Received: from inspiron14p-linux (M106185144161.v4.enabler.ne.jp. [106.185.144.161]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7f4c4ab52aasm3399933b3a.38.2025.12.11.15.24.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 15:24:14 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: pavel@ucw.cz, Bryan O'Donoghue , Milan Zamazal , Kieran Bingham Subject: [PATCH v5 19/20] libcamera: software_isp: lut: Make gamma from lut.cpp available in debayer params Date: Thu, 11 Dec 2025 23:22:44 +0000 Message-ID: <20251211232246.31330-20-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251211232246.31330-1-bryan.odonoghue@linaro.org> References: <20251211232246.31330-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Provide the gamma used in IPA to Bayer parameters. We will pass Gamma into the shader via a uniform and can then tweak that value from outside at will. Reviewed-by: Milan Zamazal Reviewed-by: Kieran Bingham Signed-off-by: Bryan O'Donoghue --- include/libcamera/internal/software_isp/debayer_params.h | 1 + src/ipa/simple/algorithms/lut.cpp | 2 ++ src/libcamera/software_isp/debayer.cpp | 5 +++++ 3 files changed, 8 insertions(+) diff --git a/include/libcamera/internal/software_isp/debayer_params.h b/include/libcamera/internal/software_isp/debayer_params.h index 5a0d9438f..d5dad1a98 100644 --- a/include/libcamera/internal/software_isp/debayer_params.h +++ b/include/libcamera/internal/software_isp/debayer_params.h @@ -58,6 +58,7 @@ struct DebayerParams { */ Matrix ccm; RGB blackLevel; + float gamma; }; } /* namespace libcamera */ diff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp index 49482d711..ea5a86b20 100644 --- a/src/ipa/simple/algorithms/lut.cpp +++ b/src/ipa/simple/algorithms/lut.cpp @@ -147,6 +147,8 @@ void Lut::prepare(IPAContext &context, params->gammaLut[i] = gammaTable[i / div]; } } + + params->gamma = context.configuration.gamma; } void Lut::process([[maybe_unused]] IPAContext &context, diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp index 7334ea197..b3615b32b 100644 --- a/src/libcamera/software_isp/debayer.cpp +++ b/src/libcamera/software_isp/debayer.cpp @@ -110,6 +110,11 @@ namespace libcamera { * \brief Blacklevel gains for the GPUISP */ +/** + * \var DebayerParams::gamma + * \brief Gamma value for the GPUISP + */ + /** * \class Debayer * \brief Base debayering class