From patchwork Thu Dec 11 23:22:29 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 25498 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id AA4A6C3257 for ; Thu, 11 Dec 2025 23:23:27 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5D7AC61637; Fri, 12 Dec 2025 00:23:27 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="GVcw8yVd"; dkim-atps=neutral Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E57DA6161D for ; Fri, 12 Dec 2025 00:23:24 +0100 (CET) Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-7b80fed1505so656035b3a.3 for ; Thu, 11 Dec 2025 15:23:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765495403; x=1766100203; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=e99H68rU1D/gDXlHtAR7K7/NWQaghQ9EtXGEFE+XesQ=; b=GVcw8yVdpohm8lfKJ5UDw4cK/zp8PtEPTsn6GUDeMuenqphorqYyyjMSVTxd978Z04 O1DvJRIOa5QND8/wHVg6wf/ZT8H1KfumuK0UnowbSQ63Fl1aEbB2MtuEnIyvh3ZzUeov InDEHotc1HhFtRfebIxzdk5aYiArjb15vU0L0juOmty3dGnHLGelsI6GuuX42IY4Bu4Q 0hmVo2/KXFFOf19mRiCSbG5o9X8wRhag9yE8fodLHSRAuy4MKBWnf781e3r0HewhOfbv GPKi7w+TmXPpyeq7nDjYrfnZOP8WTK85abhZsmEZ2M+WvTkBdM8ILd5oJGlg0yv9IP6Y jH7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765495403; x=1766100203; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=e99H68rU1D/gDXlHtAR7K7/NWQaghQ9EtXGEFE+XesQ=; b=UexgQoQU+IzKdc2R00GR5CO7fhUbdanCr2ezWQ2wgFR3UuSbryrwGZXn0ndYJj9uwZ vxXy/qxVHrv2OvvvHX5yqCxv53rAqFC6IV1qNHun4xnBM07uXzBuTKJY2pAiu6rTiJSD IwvWFoAWO6aSvDUrlbWYVcYyBhIDDJa2/hFKxZbARBG+vlUClPE1/shKZwZZk3pGklI3 9RZEyNX0qalTRDfNQA0MpMFoLwX2B942U/lDMHq6SgcOP/Dwy+bGovD+O/Y0vL8+sc02 sKlR56mPVmcYP18jsV7SJ8jj0jjt1oxy4veEMaCv6EFCuA602gc6tw5m0JBElzYoxSKe vxGA== X-Gm-Message-State: AOJu0YznCy0wRYxIBGOwhq1L5of7rvdPFmgBtqtXLPPbgoA9dKI97IYT beVPCHpw6MqWZt13iOVD+2yDXGShFPZKgT0uyxkpBY9xhqFJY48hizlgaAJ1qlK35oTBA1bmvVy j+tXX X-Gm-Gg: AY/fxX65pFLO27Q1e1RRth/S0rwx7Dwbp3IIFB+/uOroTeQmcF+R7njptu6SyojCu7c BeA0ZLUM8E8Si0iXcrzRfHm1RR2jIRr6Dse48tyBRGzbIZuuhXHK46VbHb8TS339/qDuyy+qOJ7 ntCvWzVxCzWynrwdDOh7TxIXiqImAkZeOQDyEZ4YO2gnabZYWL5uQb2DfOrLC+FbGk8YQdsTYFb LwhTJGXhzfCzRPO63bKBuZhJvOX1F8E7bPLkXr7hzknZMYkjDIAFh4WKN0sV1oyW3wmtI09I3UG A2H0hlRcTByX8Nq+irD8g4U1xelF36xIOLydpEEK2DE/QH30dsrqfNcuBnwX27MBdRM+TX5bhPm y6UKZhFXsVSx0nFoi3ZFLoH5mVCsPICuIRbex1BkTHy5/jFWBkjVvqMj3vzfLqfLE9AIbxeY7MT ChFPsdXtd9soc+eA3CSDQkNw9cbchTTUMQIQHajPDUdPk4zvj9wcD4cpdfyV81uA== X-Google-Smtp-Source: AGHT+IFiec5oEEvEfUj1RZUnJlTxKxDVikT7B3LBP4du6RHD9E1dha9fz+8wulg/8T3WheLS0DlSsg== X-Received: by 2002:a05:6a00:2c94:b0:7f0:5721:a41b with SMTP id d2e1a72fcca58-7f667d1feb9mr165536b3a.30.1765495403327; Thu, 11 Dec 2025 15:23:23 -0800 (PST) Received: from inspiron14p-linux (M106185144161.v4.enabler.ne.jp. [106.185.144.161]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7f4c4ab52aasm3399933b3a.38.2025.12.11.15.23.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Dec 2025 15:23:22 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: pavel@ucw.cz, Hans de Goede , Kieran Bingham , Milan Zamazal , Bryan O'Donoghue Subject: [PATCH v5 04/20] libcamera: swstats_cpu: Update statsProcessFn() / processLine0() documentation Date: Thu, 11 Dec 2025 23:22:29 +0000 Message-ID: <20251211232246.31330-5-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251211232246.31330-1-bryan.odonoghue@linaro.org> References: <20251211232246.31330-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Hans de Goede Update the documentation of the statsProcessFn() / processLine0() src[] pointer argument to take into account that swstats_cpu may also be used with planar input data or with non Bayer single plane input data. The statsProcessFn typedef is private, so no documentation is generated for it. Move the new updated src[] pointer argument documentation to processLine0() so that it gets included in the generated docs. Reviewed-by: Kieran Bingham Reviewed-by: Milan Zamazal Signed-off-by: Hans de Goede Signed-off-by: Bryan O'Donoghue --- src/libcamera/software_isp/swstats_cpu.cpp | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp index 4f7bdd231..9c03338a0 100644 --- a/src/libcamera/software_isp/swstats_cpu.cpp +++ b/src/libcamera/software_isp/swstats_cpu.cpp @@ -72,6 +72,19 @@ namespace libcamera { * patternSize height == 1. * It'll process line 0 and 1 for input formats with patternSize height >= 2. * This function may only be called after a successful setWindow() call. + * + * This function takes an array of src pointers each pointing to a line in + * the source image. + * + * Bayer input data requires (patternSize_.height + 1) src pointers, with + * the middle element of the array pointing to the actual line being processed. + * Earlier element(s) will point to the previous line(s) and later element(s) + * to the next line(s). See the DebayerCpu::debayerFn documentation for details. + * + * Planar input data requires a src pointer for each plane, with src[0] pointing + * to the line in plane 0, etc. + * + * For non Bayer single plane input data only a single src pointer is required. */ /**