From patchwork Wed Dec 10 14:39:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 25463 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C456FC326C for ; Wed, 10 Dec 2025 14:39:41 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 208BD61494; Wed, 10 Dec 2025 15:39:40 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="dyz1AhzO"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5F97D6149E for ; Wed, 10 Dec 2025 15:39:34 +0100 (CET) Received: from [192.168.1.106] (mob-5-90-55-146.net.vodafone.it [5.90.55.146]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E0B3A6DC; Wed, 10 Dec 2025 15:39:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1765377573; bh=WoGI79+nMuTORLewcim5V0njAoU+C2eBVttHuEH4EG0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=dyz1AhzOugqiHBeqbPh1HF04NzEGNZn8KZGD2K0qV0Y+945TerHrVpBcnuXeRbzKB xAp7bRCNyx1LoPZtKxubsOT83CvmEIdQa1N0hydLmjHOF3/QVHsmDwXlVsqjAH+CcQ +Z/8RkA1YqGkHjy4qp+kUgnlcPIO47uHJmO5hoNg= From: Jacopo Mondi Date: Wed, 10 Dec 2025 15:39:22 +0100 Subject: [PATCH v2 6/7] libcamera: mali-c55: Fix sensor size computation MIME-Version: 1.0 Message-Id: <20251210-mali-cru-v2-6-e26421de202b@ideasonboard.com> References: <20251210-mali-cru-v2-0-e26421de202b@ideasonboard.com> In-Reply-To: <20251210-mali-cru-v2-0-e26421de202b@ideasonboard.com> To: Daniel Scally , libcamera-devel@lists.libcamera.org Cc: Jacopo Mondi X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1118; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=WoGI79+nMuTORLewcim5V0njAoU+C2eBVttHuEH4EG0=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBpOYYjhOg7MYF+hyMeDSFRST0bp3YOrVqlSB6+O gXZshVX+7+JAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaTmGIwAKCRByNAaPFqFW PBqBD/95nAnDni1LmH8tfmGjLdGL3qb/phph27MLuZNazeC0BBvjW60hW0pyoEgE6tPDdLBzHNi P1jhqLOpQ9DGw9YIdrlnQi2Fxq8a0yhoErh/JKc4HX2IBwlWSgp/qF/ULPcGS43mlTFfJLtCy8f shBqMfIlV1YTPrQZ+8GQsyORoApBFvXnQH2Ji70YyhZskTb4k6Js0a5Cs7rER5jFafvY1373IMV NQg7mI8s1EleTeaxsT92EKhswtxPSNiQPu+ViV5uewb+vuyFjjLh+SdHy680SfUvHGfs3HyHlDY nfQda9P0i2rMqxGOdJS7P25NfUMY0ySbX0wmQaT+KeYsCDSt8mRv+degw3Ckb3YLWgE4+CUWbh6 53WnlSfj+cNDESr46jL/6tSHNKkQjqNL68f4oBdPKr0/Uu8ZkSIn4VKONoDuSs1n4xcpeoNGHUy ZstyQCuGKWIhHysS+/kCfUyUSeX1ncdsY108zd68acR362UxchHFCA5fdx8emg+6NhGQEv1B8lv iipDtc6anLZ8D0GrBVZ+WtgMmCW+6q63md0+C4/nON07oQD/73CJKmnRELx7bWPdgiOF8863WSd DW+wdKBFOePOqgPNgLCYNOgT2fKeZYjlGmY1utXeZJdfhFUdLB4hH4id+vWks0q4KkYToDCu/nM 2Hv/ZoLLrQ4FLoQ== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The sensor size computation routine doesn't work well. Even if a more appriate size for a sensor is available, the largest one is always selected. Fix the size computation procedure which has an inverted assignment. Signed-off-by: Jacopo Mondi Reviewed-by: Daniel Scally Tested-by: Daniel Scally --- src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp index 83cb10af5d3c0588b25e4a3190f561f09627d239..24369a341db567bc431a4bd2aecfd6865c676347 100644 --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp @@ -749,7 +749,7 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate() std::abs(static_cast(minSensorSize.height) - static_cast(size.height)); if (dist < distance) { - dist = distance; + distance = dist; bestSize = size; } }