From patchwork Wed Dec 10 14:39:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 25461 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 2CFEABD1F1 for ; Wed, 10 Dec 2025 14:39:40 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 4B571614A6; Wed, 10 Dec 2025 15:39:38 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="KTbiaYwI"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 75E4E61489 for ; Wed, 10 Dec 2025 15:39:33 +0100 (CET) Received: from [192.168.1.106] (mob-5-90-55-146.net.vodafone.it [5.90.55.146]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 162656DC; Wed, 10 Dec 2025 15:39:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1765377572; bh=lbZcUA7WzPjLCGZZ9wA2Hk/FxcQMuQFHgMl10GVovrI=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=KTbiaYwIIe07bxqR8d8rp6ORl912t6RLuJvs8qk/goliI0Mz4xStNRSuK6nqRcQSZ UPHM6CUKO8go/jH6PiAz9ZRmGVimghEqTp4RpNPCY2eE0E6J2Wuell903f5ux7nsb7 N6KhNsQZtKu9ek/3irM9o5lsue0DLMaVm/czcf34= From: Jacopo Mondi Date: Wed, 10 Dec 2025 15:39:20 +0100 Subject: [PATCH v2 4/7] libcamera: mali-c55: Configure camera in memory-to-memory MIME-Version: 1.0 Message-Id: <20251210-mali-cru-v2-4-e26421de202b@ideasonboard.com> References: <20251210-mali-cru-v2-0-e26421de202b@ideasonboard.com> In-Reply-To: <20251210-mali-cru-v2-0-e26421de202b@ideasonboard.com> To: Daniel Scally , libcamera-devel@lists.libcamera.org Cc: Jacopo Mondi X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1784; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=lbZcUA7WzPjLCGZZ9wA2Hk/FxcQMuQFHgMl10GVovrI=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBpOYYiPRo69EWop+IY9nrHGSJcy9jOlGZUI9kfN c77b4bElfaJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaTmGIgAKCRByNAaPFqFW PIOjEADCikhHIVINMoubyAnpylo9zD2hWZ1hGIQ6riw4+tu52y+BSvRaqurmtbeAdwu3KNwHMBN Do2b9eggp5AZhYhUTr33OKftHzCc0ZGKoAfsuSttyV28cwNMRaV9jgHdpLg1475nSnWF9bBiq/v rPj2bRNYqo/PhP7+2iHRnT8zewhRIX2BRPzZ5OW9qYcG4GF1cu70oFqRHwE/tsRTC9v+VOPWFMe jVc5Ekvp5kuTNIIb0YAfVeROfnarTu5piPKJBdZdx29cNPnaUAn32ln08O6CpHr70WNYYWH+eYA ZlI2MzRBCZRi1TkwdXbty3sDDXYBSsB0vCkGbejerA6jH66EbB5YWU04jW6tQwhlmExxPdNyv7+ zNRvuqja/lOqS8BXVNZNsvHe+WwdnGvm6/8KbM7OzGal7wcDU7LUq463EmYhHQ/tdmzCrk4L9Dv LRAhQKyrORzKYf6ZQuyNN/2RQJ72w+im5wlaEI5yrM9Ylz51hhRlVqIZDDPoX8m6nmrcc+yMZJv nwd1pwR5RBGp0We72pZktynq6LfHJXb2vOI+v2vI545CsooKtUopOrjfrdDMUugcixduZ+Valqs y21D4tWUUV+y+XUFdJjX37gKUxRZEvfcVOcBOt6uq+dgVXV0PgPnxK7Etj9vmVak4lB36xFAGjD LdqpDIoi/5vyt+A== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Add support for memory-to-memory Camera to the PipelineHandlerMaliC55::configure() function. Start by enabling the IVC links, then configure the CRU and propagate the format to the IVC. Signed-off-by: Jacopo Mondi Reviewed-by: Daniel Scally --- src/libcamera/pipeline/mali-c55/mali-c55.cpp | 27 +++++++++++++++++++++++++-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp index c0c14338ddb3f1d0075df3b3d3d154bc1b5d678a..8dcc51e27020c754004cd98cbdf73e771275b059 100644 --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp @@ -1104,9 +1104,12 @@ int PipelineHandlerMaliC55::configure(Camera *camera, ret = csi2Entity->getPadByIndex(1)->links()[0]->setEnabled(true); break; } - case MaliC55CameraData::Memory: + case MaliC55CameraData::Memory: { + const MediaEntity *ivcEntity = ivc_->entity(); + ret = ivcEntity->getPadByIndex(1)->links()[0]->setEnabled(true); break; } + } if (ret) return ret; @@ -1133,7 +1136,27 @@ int PipelineHandlerMaliC55::configure(Camera *camera, ret = data->csi2()->getFormat(1, &subdevFormat); break; - case MaliC55CameraData::Memory: + } + case MaliC55CameraData::Memory: { + V4L2DeviceFormat inputFormat; + + ret = data->cru()->configure(&subdevFormat, &inputFormat); + if (ret) + return ret; + + /* Propagate the CRU format to the IVC input. */ + ret = ivc_->setFormat(0, &subdevFormat); + if (ret) + return ret; + + ret = ivc_->getFormat(1, &subdevFormat); + if (ret) + return ret; + + ret = input_->setFormat(&inputFormat); + if (ret) + return ret; + break; } }