From patchwork Wed Dec 10 00:53:54 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 25443 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 7EC52C3257 for ; Wed, 10 Dec 2025 00:55:24 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 2C57A614AF; Wed, 10 Dec 2025 01:55:24 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="XjboH+zu"; dkim-atps=neutral Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A6E88614A0 for ; Wed, 10 Dec 2025 01:55:21 +0100 (CET) Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-7e2762ad850so6529116b3a.3 for ; Tue, 09 Dec 2025 16:55:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765328120; x=1765932920; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ajdHqIYvkWHsZzgWfrEnNcPGftSQ9L7WA4FF/krfdgY=; b=XjboH+zuECeF7OTpwbDjEvFqjW9sdWDtwCbhavyB3a5QQLyV+SrsAXoFgVE4acJp+F dX9F62LkpZFpqrMiU1oofbjsDNfOQgKHadiQjOnRPuH+o9FMwJHELx7myjQEMIt2YY7I C7Lgpgei+Kv/XE11cTiemkAXb3WIQVY4NgIJny/R5KTg5Q/IRyiSeO6FkGRPZID+uJwR tQq7iiLGLe2vprD0MUrUIdGI1Lpe10WPFv5e8QqSN/JvzMDbjDFXZ5uyGP1a6r3THuaP +TKKcIBBoTCggem50Xsdo7qFRGsXhH0Vdwt9urcOGzajbGeB0eOJgPaWFCQo698QsbnB vD1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765328120; x=1765932920; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ajdHqIYvkWHsZzgWfrEnNcPGftSQ9L7WA4FF/krfdgY=; b=XEOSXzpZGC2j4kfYL6X26LcIk4FOOADtoLRcLOpbW/Y6PrNGbthb0q8HdyB8lVvS+/ tPi8aJdiDyr92TVAuYuxwwdWEljsZUO3TYwYCz3zgbnMBzWZq/gAW8F8eJ1zxZFLK8vE yq9U4C11h4PnQHXKTx6YN/uk99FcVvgp/d399dJ/g3kMlWdB1S8GfzVcdWmcCvFGcLGa 1Cu+WJqAUTT624dGJ25O4ddCyJCrIUm3U0CmIHdojDxaG4FAcyxf9WrSGWMUvpT7C/15 FVKJHE2heTpZ88tkHTLLifZPQPHuBachCj8BuRb0l0f0fVvdMm5r27LQLOMZVwRXg+U9 1dPw== X-Gm-Message-State: AOJu0YynSgYAj+IVGB2JqoDd1exAMF04YGkHqiJ9cYgokmy8KzaXY29h 6lKL3ijWzL15/3feRUM3+8w16LPMDZfBWoxupumnCqfT8Siw489E11+SzKtn9EP3AWUH7Q7NQzB rkDeQ X-Gm-Gg: ASbGncujXTbxOM0yLD+KHQKMYYqbSHutX90yaTlH0gpWZhKWpVuyp0yLwFn/dzV5j9f TpKQxcA7l7xdpwoU4wKIIUOgTgrcEld1CRPqDm8lTVQMuhgxbTd2aWke5sybB8Rj2qxEUm1ucVq AYj2dI95AeFrzPmdSoKW9sKfibHaUOb5DJ1t8wn6tKte0gqXOw96xC+7UApTp/db/KE10Nymv05 KMOgT9R7I4UtfMz9bYDLbQrhrEifwupYbpWYvFo7HHb921wjnCV3VzML1Juz6Q1rb77gaerWVDu AkaG0XS81kpZl8RxjqDF3pK6YBiNe+uIX4bR5Uz+uzXQEl5cCJHet4Ig4ntqm4KZR54CU8wJuMf P52q9JXNNOdw6GzMfUqEEXpZrhyCRWTA4rXe8ZjY5Xy6aI4T2aw5IYGHJcrI7vPUdwjJjXRubFA b8Z2jU/ySBh/swf+PkSPHuzDnRKmsIjxKlhf6P74wY+XNCrF5hZCDYjgnHTZA7MzIj X-Google-Smtp-Source: AGHT+IF0umI0JI9WWFj1XJfHMnHGh8J6MRIMMowI15nR/2IsdQn4VoGCjya2uexQFNVr/IA/19pBYA== X-Received: by 2002:a05:6a20:3d95:b0:366:14ac:e1f5 with SMTP id adf61e73a8af0-366e2fc1b7amr509243637.71.1765328119996; Tue, 09 Dec 2025 16:55:19 -0800 (PST) Received: from inspiron14p-linux (p96936b06.osaknt01.ap.so-net.ne.jp. [150.147.107.6]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-bf6875cc8eesm16057762a12.16.2025.12.09.16.55.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Dec 2025 16:55:19 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: pavel@ucw.cz, Bryan O'Donoghue , Kieran Bingham Subject: [PATCH v7 26/26] libcamera: software_isp: Add a gpuisp todo list Date: Wed, 10 Dec 2025 00:53:54 +0000 Message-ID: <20251210005354.44726-27-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251210005354.44726-1-bryan.odonoghue@linaro.org> References: <20251210005354.44726-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" List the series of things to do in GPU ISP in perceived order of difficulty. Acked-by: Kieran Bingham Signed-off-by: Bryan O'Donoghue --- src/libcamera/software_isp/gpuisp-todo.txt | 40 ++++++++++++++++++++++ 1 file changed, 40 insertions(+) create mode 100644 src/libcamera/software_isp/gpuisp-todo.txt diff --git a/src/libcamera/software_isp/gpuisp-todo.txt b/src/libcamera/software_isp/gpuisp-todo.txt new file mode 100644 index 000000000..b9910d17d --- /dev/null +++ b/src/libcamera/software_isp/gpuisp-todo.txt @@ -0,0 +1,40 @@ +List the TODOs in perceived order of ease. + + +Denoising: + - WIP + +Dead pixel correction: + - WIP + +Lense shading correction: + - WIP + +Use dma-buf handle to generate upload texture: + - eglCreateImageKHR can be used to generate the upload texture i.e. + to feed the bayer data into the GPU. + +processFrame() to run in its own thread: + - processFrame() runs in the context of the Debayer::process() + thread. Robert Mader suggested and it seems like a good + suggestion too to run processFrame() in its own thread. + +Multi-pass shaders: + - This needs some rewriging the idea is to have a list + of algorithms as is done in cpuisp iterating through the + list in a for() loop. + - The logic manging the loop has an initial input buffer + and the final output buffer. + - The higher level logic must then inform each of the + algorithms either to generate an internal working buffer + or pass the final output buffer to the last shader + in the list + - This will allow for multi-pass shaders with the final + algorithm presenting data not to its internal buffer + but to the final output buffer + +24 bit output support: + - Need to implment compute shader to do this. + +Lense flare correction: + - Not WIP still TBD