From patchwork Wed Dec 10 00:53:43 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 25432 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C907CC3257 for ; Wed, 10 Dec 2025 00:54:56 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 82B7F61489; Wed, 10 Dec 2025 01:54:56 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="hj1neJiy"; dkim-atps=neutral Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 4B40561487 for ; Wed, 10 Dec 2025 01:54:54 +0100 (CET) Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-7bf0ad0cb87so7346426b3a.2 for ; Tue, 09 Dec 2025 16:54:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765328093; x=1765932893; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BO0mMIWhB901RhyMhEcHbc+LWlQiOyKCJvDrt0v6kXI=; b=hj1neJiyk0pki55u+lEY42wkfhmOw/qNFrzFOAecHeFye9WvBMJttlbs6dplJk63B6 sClRcbIvlVNEz7NCTVeNfQ4dix5NuuTzmYulrKK2iSHt7evV1IpHYBVMJT/IHoRcTVel /VhPjYTYavfTC/rRxA2SQWAKeGlhhUFR+UW5Uz2L3Yfd4o3h76cIGs7h7o0EOM2tStHF siSVoMyJcvK1xE1xkl4aDiibd4lq2sHgEffmvolIp5AMDkb4xC9Iafwa57To2allh+8B /iG5sSHfWI4ymkdFwqT1qvcfNtKcCFrO2DRWfvjsZdLI3LggoNuDBeE/MOqQ8S3CRFQW IxqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765328093; x=1765932893; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BO0mMIWhB901RhyMhEcHbc+LWlQiOyKCJvDrt0v6kXI=; b=SLi1vwJdpphw+fbA9xoj4+LWyz3bVcur+fQLTvjRt3x8Q8os5a4Fw2G2DcnnmFqB3L LUaJ9v9cRpBygj5h/ZGqbixT5K+C0PmjUPmXXipLNvVHB9gxf7yTQGP8aZhkZw4g/Xwt iVG6ZrZiHkV3K4aSHOIoYfRbQTsK5pO6belrYRReYzNtaPXq+kAA6HnjwHOhh4EtmpYY t6Psdj+9KEuicczM1Y+xVK1juOopKbwd+sp3wsmDS1x2524NsrcJA+zCkgbw/zqjHXOz zrzHsICjXEnvtDBiXqjU9fDSH/LBkHI8ckQF2mTcvlI3KQzy15IUBDGZl1B7Y/53/xw0 RptA== X-Gm-Message-State: AOJu0YziGqY4AfiYbG8W+l0E9rRNG09nm+QeCf21oSdzchB5k+0/z3tg V0oeVl890M5BjQDPXXelHA4W4XABRkEYErKf6Gj6bEo5y4H7Sd3mmFkIrZos0++ENE39v+4J/6k m7Ln6 X-Gm-Gg: ASbGnctIedH4fLBfMsQhp66T0jLEdz+/MOKjwMz36bhg/whxLJoKvDse+0VmgGLQfl0 nwtSzpjzXhCbT9uuiuxhVqCrag4d6Si0i3BZA3fv1JUPSO7IDKNXKXlGN0GI+dOduodHjrgYIgU QSsV4sWwMswjVX9WzfMEITIjGMIUTLRmXnUZ+aUkqKeLQ8Aqe6OCr3Pc6U6LBM31JUC/KPi0Hm6 m2OwAWzwaj2YlCuIWkoDVJ1zQEDLWY73gTo1mJJcPaRn7I1ALsYWWO9ZPew0eA1cB/ui8nEc190 tBUZ1vH+iSnggsby01prDjspgB1KoTUHR9c2p6NIMfVFT3DEU21PAp6gamJ72nCYurKq7jIQhqI ECMooBRoEoCohoz1+Sq4BjQ4uhVrGn9OiGlzZm2vMGIImjykiPdZoZjyGLgEYzVGWsYzEs5HJ8y 8Vci45XlWTa3ckUy5QsbCkBBhjPzuDU1T6j5ktkahHCRvZLH/KQS9DykqMCzyV4rL7 X-Google-Smtp-Source: AGHT+IFS3r0aXGeuQX+5WEaVxsWyUys5Lez0i9IFe8KIleC4zLzTDOfP3kkPk+c8hs8CgVq0w/xptQ== X-Received: by 2002:a05:6a20:548d:b0:366:14ac:e1e3 with SMTP id adf61e73a8af0-366e35c3d35mr428068637.73.1765328092596; Tue, 09 Dec 2025 16:54:52 -0800 (PST) Received: from inspiron14p-linux (p96936b06.osaknt01.ap.so-net.ne.jp. [150.147.107.6]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-bf6875cc8eesm16057762a12.16.2025.12.09.16.54.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Dec 2025 16:54:52 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: pavel@ucw.cz, Bryan O'Donoghue , Kieran Bingham , Milan Zamazal Subject: [PATCH v7 15/26] libcamera: software_isp: debayer_cpu: Make getInputConfig and getOutputConfig static Date: Wed, 10 Dec 2025 00:53:43 +0000 Message-ID: <20251210005354.44726-16-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251210005354.44726-1-bryan.odonoghue@linaro.org> References: <20251210005354.44726-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Make getInputConfig and getOutputConfig static so as to allow for interrogation of the supported pixel formats prior to object instantiation. Do this so as to allow the higher level logic make an informed choice between CPU and GPU ISP based on which pixel formats are supported. Currently CPU ISP supports more diverse input and output schemes. Acked-by: Kieran Bingham Reviewed-by: Milan Zamazal Signed-off-by: Bryan O'Donoghue --- src/libcamera/software_isp/debayer_cpu.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libcamera/software_isp/debayer_cpu.h b/src/libcamera/software_isp/debayer_cpu.h index ecc4f9dd0..67df2b93a 100644 --- a/src/libcamera/software_isp/debayer_cpu.h +++ b/src/libcamera/software_isp/debayer_cpu.h @@ -97,8 +97,8 @@ private: template void debayer10P_RGRG_BGR888(uint8_t *dst, const uint8_t *src[]); - int getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config); - int getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config); + static int getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config); + static int getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config); int setupStandardBayerOrder(BayerFormat::Order order); int setDebayerFunctions(PixelFormat inputFormat, PixelFormat outputFormat,