From patchwork Wed Dec 10 00:53:36 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 25425 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id AB43FC3257 for ; Wed, 10 Dec 2025 00:54:41 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 6A67361455; Wed, 10 Dec 2025 01:54:41 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="ZbWK0lwk"; dkim-atps=neutral Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 5059D61453 for ; Wed, 10 Dec 2025 01:54:39 +0100 (CET) Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-7acd9a03ba9so6766826b3a.1 for ; Tue, 09 Dec 2025 16:54:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765328078; x=1765932878; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5qjoeAop1GzrvnIG7vvLvJkbwSmYKtE+YPe2MFgINpo=; b=ZbWK0lwkizK94sUUasc4goydeS7Ke1V2j/3/T6t8HjjRekND5blYkHv2CM1BMxr0uD NCmNCjzPaSEPOjimpLUPOiOgmwhlf9t5Y7BBSpuZhpvTsu1uEyZS02oogMuSalY2Vz7d CvRMHTnVWQrk0cdiHPwXTL7CiGOcs0ad3B4Saq6m/bnQGiTP3EJbHgXg9kZSH7FNN5bw hxJEGE0NMseXVBxxiLzqzBhwv4CKJJqcK7PlRMKrnzlHTzIBrv1Cuj4ZnFFpStFzqZML 1WZgzWqm44ZjZrBFk91JeRGeTf244AtRWi4cGc8M6NPLRli2LlGSK9ZgQ5RRv5HTNoH4 QyDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765328078; x=1765932878; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5qjoeAop1GzrvnIG7vvLvJkbwSmYKtE+YPe2MFgINpo=; b=vB/jh4r+3GbCyS/sDXKFnWwEWKsIQu4iZeuAKgFXj+N52Wh7j4sJOIsDMOpLU3vdwt 7FZ9Ru0xsI7ZHXWHy434yU28Bfc1wALqUG7gT+J7XbrFjJqmL3LgMplqXMHHYbxeVFpi S1jFKpdaUcqJfXUS3V1yBbvIPhNH+ZjVJAYH1tSZSaxVcz1khI15qDwQJ/XYcrovJPmy ST3LqeXOXsD8tChAkSpPFca6fm0QQtpeYWXIRirxiKXkoXVDdqipVWJGjlaJG0fWxTwt KAMvUSqKyBHXJdUzQlqGORNvXhm5tEj/ojZU7sbMistuhKQQ/w5p3SmTQzXTBm9MSQPi o5Kw== X-Gm-Message-State: AOJu0YwSBWf2U/4Wuypq0w+u8XW5LvyBfb3A6jV+7MAgu0lBSzDpjeHs UP00JkQgPCzsbs1x2wlu0tI3XvPV1z2m7901nyERo/klSXqJW+Oaz5tUgogHRgW3/x9eyKDuBbS D5RlA X-Gm-Gg: ASbGncskO9wFVvaK/X10otKg6p/NvzGQvPeQZKq7dpUxImvSmCYu6zCrrTvHjnqh0NA c9OVkk7AmcTvsUEvA6qob4SImxO90H/EEwvHh5hx1rDuYUJ2f1G1Tql1D5qnqS9b/Wj6LLndIrs ePG+OGv40gVNVL1P/6oM3zuW1325hcbUOSJVqp+EVqKj9cgAe7bmDm4jLDYT5MCn6H6rZ4eq3P3 p6KsxwTxKfPi1EF5z4Q9aI/jhIrnWgCAwJ7YSKhlOzXAgrOD0kf9ii5kQtbqCgN9Gvg/yG1rpIk 5U4mTWXk0hf8eooqkgGciqMD69GD/sf/ebUbJPNfsfNriZZC7KlAo58jm676ecnHAnEJ7QBZjG1 GMjN7813wkgYcvM5RULJFII0M1wQocIKrwWPyZPCQkaCBOr619tyOqGMj3FBEl02syXJQtuAs7O PuBTTgHFtx4xMc/+8iOgD17BOzbAl6INJy+++gjc+ETPET+I6q4TlrzWAF8yblmYxC+WZY0vCrM Is= X-Google-Smtp-Source: AGHT+IEFGiHk62rOdCVtTC/0xCtxKO5OXIimajmsyfRCaStOd+1pCyujilFuNl+KrJeD+jA5U2gGrg== X-Received: by 2002:a05:6a20:72a7:b0:366:14af:9bbb with SMTP id adf61e73a8af0-366e35c7511mr610211637.69.1765328077657; Tue, 09 Dec 2025 16:54:37 -0800 (PST) Received: from inspiron14p-linux (p96936b06.osaknt01.ap.so-net.ne.jp. [150.147.107.6]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-bf6875cc8eesm16057762a12.16.2025.12.09.16.54.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Dec 2025 16:54:37 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: pavel@ucw.cz, Bryan O'Donoghue , Milan Zamazal Subject: [PATCH v7 08/26] libcamera: shaders: Add support for black level compensation Date: Wed, 10 Dec 2025 00:53:36 +0000 Message-ID: <20251210005354.44726-9-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251210005354.44726-1-bryan.odonoghue@linaro.org> References: <20251210005354.44726-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Add the ability to apply a int blacklevel gain against the demosaiced data prior to application of colour correction data. Reviewed-by: Milan Zamazal Signed-off-by: Bryan O'Donoghue --- src/libcamera/shaders/bayer_1x_packed.frag | 3 +++ src/libcamera/shaders/bayer_unpacked.frag | 3 +++ 2 files changed, 6 insertions(+) diff --git a/src/libcamera/shaders/bayer_1x_packed.frag b/src/libcamera/shaders/bayer_1x_packed.frag index db8c2a0b3..7036fe278 100644 --- a/src/libcamera/shaders/bayer_1x_packed.frag +++ b/src/libcamera/shaders/bayer_1x_packed.frag @@ -66,6 +66,7 @@ uniform vec2 tex_bayer_first_red; uniform sampler2D tex_y; uniform mat3 ccm; +uniform vec3 blacklevel; void main(void) { @@ -213,6 +214,8 @@ void main(void) vec3(patterns.y, C, patterns.x) : vec3(patterns.wz, C)); + rgb = rgb - blacklevel; + /* * CCM is a 3x3 in the format * diff --git a/src/libcamera/shaders/bayer_unpacked.frag b/src/libcamera/shaders/bayer_unpacked.frag index 06d80f3dd..f0d8cd1e2 100644 --- a/src/libcamera/shaders/bayer_unpacked.frag +++ b/src/libcamera/shaders/bayer_unpacked.frag @@ -25,6 +25,7 @@ varying vec4 center; varying vec4 yCoord; varying vec4 xCoord; uniform mat3 ccm; +uniform vec3 blacklevel; void main(void) { vec3 rgb; @@ -108,6 +109,8 @@ void main(void) { vec3(PATTERN.w, C, PATTERN.z) : vec3(PATTERN.yx, C)); + rgb = rgb - blacklevel; + /* * CCM is a 3x3 in the format *