From patchwork Wed Dec 10 00:53:33 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 25422 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A6AD6C3257 for ; Wed, 10 Dec 2025 00:54:34 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 6E17C61442; Wed, 10 Dec 2025 01:54:34 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="r/Ww6sbi"; dkim-atps=neutral Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id DAFA36142A for ; Wed, 10 Dec 2025 01:54:32 +0100 (CET) Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-7b9215e55e6so4135553b3a.2 for ; Tue, 09 Dec 2025 16:54:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765328071; x=1765932871; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FdyTcK0Xun67yTvAExHcO9DNNAcWNw/aYg3LzuhT/Zc=; b=r/Ww6sbiRIgoidaWP8XGknzoRKqgJI+pEL/2cM1E7EOP37GDbbImdSMQLAmG/9Snid mBCFwsqYWl5fhdOGq0vS5OWsKcwneHGfi+1/PIS7G+oUD+exDVASXU8haG8uf8i+zCVi TncVFvXfaSO3dBVKD+8Bbrmpq+9TLyzE6q1oRG5VGa9bmEz8Fpszg+NgH7KNy5FbcAix E33H2LnkIIrf1RpijrHFwdQYjHUlMwuNWT7gBvkHQtGQf42zslKjsLUsmmdx7XXN5dp5 Bd/VIUB5tFy5HBcWZlcQDLRMJDGnPkqwvVJDlpR6FdCqWTtXv4SHcOhfqWhqY7PjhIfo ePAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765328071; x=1765932871; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FdyTcK0Xun67yTvAExHcO9DNNAcWNw/aYg3LzuhT/Zc=; b=LBPkoXYEEClqi+yU70/C9Wfwq/uitpsnoNAS5SGC8ZAzPkRybIqODAVGnI84zjqZsd unUXYcR1kcpeD9bdirlm0LZGJj06Gj2Yfavp+QgNwYBA+DgvZJac3nr7zgEsFqYZz8M1 6VuDhNxPFNfFvDYcNZZnMimScTQf+sU/9gvLqUaSZvKdFzIVM5Bf9Eocf1IxVTM6wIaQ iUGFJhRMOmDiJurcVd0qp9U0m/7F7ejxxbkKUw/P45GnYUjHv95j9yLi9bQIcCHHMrmF /scQ4gqzNZH+4JplGUwsN/8hEHKAqWDq6qdNKoNeA+JHb/YHxd3yP9mdHhJj0ovLl47f 0Yyw== X-Gm-Message-State: AOJu0YzVDowwyxsW/UZ7qJ1RtSgkicHcXygI2vaFYYzhzm64i5uo3VJf NXx4ME7L/WKSsp6EF3tuvjls21G2USg9WaJQLubf8qLhV35EQO65ruLBYgkZmxOfIsBV66EvwNA VfI3V X-Gm-Gg: ASbGncvhChvSa3LclYfuvu0s2/96w5jKXaT09J0JfnzuM0zLoyHwqLcZRbHdLYXGWJz oKCkewNzAbcBrDxsVaz6gNV0aQLXYc9TBfxeZFh+R+GjraxrAkLHMl41wD9gwdl8l5kaVfK1atO qAGHit3x+JLdH4iy+yDohnXrwqAYiz0B1jRjxlQo8uyHeoM+NTWZTjEvGuV1TEgmtnRfPU5e5mV J29NjAva/i/H/sLPA/kVHCI8XjAnsLuc2Jq5QXm3SyrtyrIj/hWWBJAbklvX62BUjYwjlbnU2li vzvOdvK6/FtSOeubPEkyhBFMUvZ+ZC7gDyK2j+oa0x1wj4R6kChE6kY0zdmF6LQKETCy7J/86uP zJ9FtTkOlG3z3fSeWhYfPVwYXAH82QAGeRDIj8BRvoMP9d+rMshbppPxHfDv32UPNqVNpJ2M4zR DN7gqbVNv6hkPHTPfVhJTgTr2I+pPxAX40Smzt9wXSdLpIHDKlsHd925SXKFSvV7Tl X-Google-Smtp-Source: AGHT+IGe2E1ivJtJvkM4EQRKSHR77a9ZuPj+GN0vmrHFo8KwUR2bR9MQ+hcYnPIHhYuVcO/o3pd1ow== X-Received: by 2002:a05:6a20:3c90:b0:35d:8c8:8ab4 with SMTP id adf61e73a8af0-366e2999d7cmr538889637.44.1765328071123; Tue, 09 Dec 2025 16:54:31 -0800 (PST) Received: from inspiron14p-linux (p96936b06.osaknt01.ap.so-net.ne.jp. [150.147.107.6]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-bf6875cc8eesm16057762a12.16.2025.12.09.16.54.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Dec 2025 16:54:30 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: pavel@ucw.cz, Bryan O'Donoghue , Kieran Bingham , Milan Zamazal Subject: [PATCH v7 05/26] libcamera: shaders: Use highp not mediump for float precision Date: Wed, 10 Dec 2025 00:53:33 +0000 Message-ID: <20251210005354.44726-6-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251210005354.44726-1-bryan.odonoghue@linaro.org> References: <20251210005354.44726-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" mediump gives 10 bits of mantissa as the resolution. At higher resolutions 10 bits of accuracy is insufficient - for example at a width of 1928 bytes we need log2(1928) = ~11 bit resolution. Switching to highp gives us 23 bits of mantissa giving a sample width precision of about 2^23 ~ 8,388,608. Acked-by: Kieran Bingham Reviewed-by: Milan Zamazal Signed-off-by: Bryan O'Donoghue --- src/libcamera/shaders/RGB.frag | 2 +- src/libcamera/shaders/YUV_2_planes.frag | 2 +- src/libcamera/shaders/YUV_3_planes.frag | 2 +- src/libcamera/shaders/YUV_packed.frag | 2 +- src/libcamera/shaders/bayer_1x_packed.frag | 2 +- src/libcamera/shaders/bayer_unpacked.frag | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/libcamera/shaders/RGB.frag b/src/libcamera/shaders/RGB.frag index 4c374ac98..724395894 100644 --- a/src/libcamera/shaders/RGB.frag +++ b/src/libcamera/shaders/RGB.frag @@ -6,7 +6,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif varying vec2 textureOut; diff --git a/src/libcamera/shaders/YUV_2_planes.frag b/src/libcamera/shaders/YUV_2_planes.frag index 1d5d12062..d286f1179 100644 --- a/src/libcamera/shaders/YUV_2_planes.frag +++ b/src/libcamera/shaders/YUV_2_planes.frag @@ -6,7 +6,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif varying vec2 textureOut; diff --git a/src/libcamera/shaders/YUV_3_planes.frag b/src/libcamera/shaders/YUV_3_planes.frag index 8f788e90a..8e3e0b4a5 100644 --- a/src/libcamera/shaders/YUV_3_planes.frag +++ b/src/libcamera/shaders/YUV_3_planes.frag @@ -6,7 +6,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif varying vec2 textureOut; diff --git a/src/libcamera/shaders/YUV_packed.frag b/src/libcamera/shaders/YUV_packed.frag index b9ef9d41b..3c9e3e397 100644 --- a/src/libcamera/shaders/YUV_packed.frag +++ b/src/libcamera/shaders/YUV_packed.frag @@ -6,7 +6,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif varying vec2 textureOut; diff --git a/src/libcamera/shaders/bayer_1x_packed.frag b/src/libcamera/shaders/bayer_1x_packed.frag index f53f55758..19b13ad08 100644 --- a/src/libcamera/shaders/bayer_1x_packed.frag +++ b/src/libcamera/shaders/bayer_1x_packed.frag @@ -20,7 +20,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif /* diff --git a/src/libcamera/shaders/bayer_unpacked.frag b/src/libcamera/shaders/bayer_unpacked.frag index 7e35ca88e..aa7a1b004 100644 --- a/src/libcamera/shaders/bayer_unpacked.frag +++ b/src/libcamera/shaders/bayer_unpacked.frag @@ -16,7 +16,7 @@ Copyright (C) 2021, Linaro //Pixel Shader #ifdef GL_ES -precision mediump float; +precision highp float; #endif /** Monochrome RGBA or GL_LUMINANCE Bayer encoded texture.*/