From patchwork Wed Dec 10 00:31:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 25400 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C8F90BD1F1 for ; Wed, 10 Dec 2025 00:32:09 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 9083F6142A; Wed, 10 Dec 2025 01:32:09 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="qvUcFVZi"; dkim-atps=neutral Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 892F66141A for ; Wed, 10 Dec 2025 01:32:07 +0100 (CET) Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-7aab7623f42so7461339b3a.2 for ; Tue, 09 Dec 2025 16:32:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1765326726; x=1765931526; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=e99H68rU1D/gDXlHtAR7K7/NWQaghQ9EtXGEFE+XesQ=; b=qvUcFVZiePfLNqkdBo6i/PumFT54eAAoRWSHCsV5c39gf2yXBEOJ1UgW/cyYHWbJZf 6lm+jsmvITmmB+DGgyZEb31tHt32mmBTjlG0v9XN2/7UFyni78bDnw4oo2m3jOhT4moS 1jvZQgCacdZOYeUsxIWYG+47I1Xn9OfaeQ+myl/bk0MAaaE2b1btDIs8QP3o+CGnnOTE bWrimlPrMu7L3eLRWhnLunHRNAC/3B8zaBzBucj5kFjY7FHbM8DbmZcbouV1314B0Bdy 63CwlxyarkIMltBCq8D9pFBJ6yxn5JYusbG1Z1dv4vNLqMUrXlINdYTg7g7t08XzG3bm uSng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765326726; x=1765931526; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=e99H68rU1D/gDXlHtAR7K7/NWQaghQ9EtXGEFE+XesQ=; b=C8y7N+h2kpSd3jXfMXdATyX8PMayo5yVeT7PHVC2tdWA62FUvJfNW/gyv6yZ9pZXB/ IAYx0isSzMl489BYAsUfNQj5Gl/KX9lVchc2Iku2+ZE4fkb3PeP3JMpILb6iXhBtb/Iy kGdD+5ErAr9/AP+YAg3l5t8EhsN63q8zUfbNG9ZnLKOgkPIKTbo2hBgLvtPdbNmU+hal LBT3krmqhYhnhcAu0bZNubm7K5g/4sb05Do4RGfVgpQlVcHwZq6ILpB+1AMuseof1Qz/ Tg203Iv/iddso6yymhfwB0n2pA6hTTtndu6dHLEeAgA80I+zm0/WtZzYhGT5TMAiAXFj QnYg== X-Gm-Message-State: AOJu0Yw/NOBSBhONxAx6P2s57zPiLv0mXz9JgVWeWj4hO7fZTJsV3a9V V5w5TMutL+BC4iivl8ukQOMfiT1ujDRurCG+xKQnrUM7XZvD+4ZXyY3vBEU7Xu17D1mAKkzHb9f a2Lm2 X-Gm-Gg: ASbGncvW0gjnYrDBgHYo3SvzUD6eN5UQ3dM6Yl0nR42llZOJUt4cs7B1/tPGr3kQhXh AhtsBGqVU7OLJsrKmHZmy2YX5T+LNOMmujOUvrtnrFH39vzsgtB2lgH37yhP81hLzA2cc3I0FDF rhTR9Igg4k97i6qq49YMaSvqsVcKwKc8CcbJAwEzqhg7sZ+Xnu9IHJuGg2sHM7wLMsWQr7wtUOm BkM+RFsxun4vqdrOUnUKkieEj/X4lhGSwZei4i73wAtksPYMnMmn9xdzx4HwuhgOIh69FzyI/aB 4P3+qLALZi6kVEjbDG1Q+XJF2J2J+UL/muy+0474xf/xpXWShokHjQsPHQkGp5HAYYPnXUwyT4T DMcrCNoFH7kYOOz7PgWily13owm309Mn4wAues7qO6ywkuZ56xrKhujHWm7/ovClStL0SudePie avN38o0b483j+onDF0pcHA+boPSVq77UwyUEw75TC16icdd/vGdbUxizXd4r+fZMSb X-Google-Smtp-Source: AGHT+IHamcf1+KG0Au74QzpcXxJRzK0Co2CE7uzjTF67yN0XdR5gf+UZPQpdO74DV2d1yhqoO+1scA== X-Received: by 2002:a05:6a20:6a05:b0:351:9401:c2b0 with SMTP id adf61e73a8af0-366e0deaf38mr449374637.31.1765326725885; Tue, 09 Dec 2025 16:32:05 -0800 (PST) Received: from inspiron14p-linux (p96936b06.osaknt01.ap.so-net.ne.jp. [150.147.107.6]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34a70427ea6sm566580a91.3.2025.12.09.16.32.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Dec 2025 16:32:05 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: pavel@ucw.cz, Hans de Goede , Kieran Bingham , Milan Zamazal , Bryan O'Donoghue Subject: [PATCH v4 04/20] libcamera: swstats_cpu: Update statsProcessFn() / processLine0() documentation Date: Wed, 10 Dec 2025 00:31:21 +0000 Message-ID: <20251210003139.43606-5-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251210003139.43606-1-bryan.odonoghue@linaro.org> References: <20251210003139.43606-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Hans de Goede Update the documentation of the statsProcessFn() / processLine0() src[] pointer argument to take into account that swstats_cpu may also be used with planar input data or with non Bayer single plane input data. The statsProcessFn typedef is private, so no documentation is generated for it. Move the new updated src[] pointer argument documentation to processLine0() so that it gets included in the generated docs. Reviewed-by: Kieran Bingham Reviewed-by: Milan Zamazal Signed-off-by: Hans de Goede Signed-off-by: Bryan O'Donoghue --- src/libcamera/software_isp/swstats_cpu.cpp | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp index 4f7bdd231..9c03338a0 100644 --- a/src/libcamera/software_isp/swstats_cpu.cpp +++ b/src/libcamera/software_isp/swstats_cpu.cpp @@ -72,6 +72,19 @@ namespace libcamera { * patternSize height == 1. * It'll process line 0 and 1 for input formats with patternSize height >= 2. * This function may only be called after a successful setWindow() call. + * + * This function takes an array of src pointers each pointing to a line in + * the source image. + * + * Bayer input data requires (patternSize_.height + 1) src pointers, with + * the middle element of the array pointing to the actual line being processed. + * Earlier element(s) will point to the previous line(s) and later element(s) + * to the next line(s). See the DebayerCpu::debayerFn documentation for details. + * + * Planar input data requires a src pointer for each plane, with src[0] pointing + * to the line in plane 0, etc. + * + * For non Bayer single plane input data only a single src pointer is required. */ /**