From patchwork Fri Dec 5 14:52:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 25376 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 5F6B0C32DE for ; Fri, 5 Dec 2025 14:52:41 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 2766161400; Fri, 5 Dec 2025 15:52:38 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="umLkbG4T"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D6853613A4 for ; Fri, 5 Dec 2025 15:52:31 +0100 (CET) Received: from [192.168.1.4] (net-93-65-100-155.cust.vodafonedsl.it [93.65.100.155]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A7FCC558; Fri, 5 Dec 2025 15:50:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1764946215; bh=GaTpeR6Ev0sWnhJLRy/0ww3MNJ37XvE6rxX0o9HyIOY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=umLkbG4TfEBJrxfYQUKMB9alVYJ2M8CWGpMJ6yT99ZVSndj+SJ7NIni5KxS/HxRY2 /Jpg1n+cITViSTH9otNViBOmOlzsvtxMtSJs3yNJHylr2duvxiQhWc+cvfONsBMh+b yXr1aWhX5DhEiZUjwgmkKwnM8Luq0W6geTnxi2J4= From: Jacopo Mondi Date: Fri, 05 Dec 2025 15:52:12 +0100 Subject: [PATCH 6/7] libcamera: mali-c55: Fix sensor size computation MIME-Version: 1.0 Message-Id: <20251205-mali-cru-v1-6-d81bb5ffe73a@ideasonboard.com> References: <20251205-mali-cru-v1-0-d81bb5ffe73a@ideasonboard.com> In-Reply-To: <20251205-mali-cru-v1-0-d81bb5ffe73a@ideasonboard.com> To: Daniel Scally , libcamera-devel@lists.libcamera.org Cc: Jacopo Mondi X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1004; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=GaTpeR6Ev0sWnhJLRy/0ww3MNJ37XvE6rxX0o9HyIOY=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBpMvGt5rPmI8V3p0XhUrTKGPuJQkvN4bnBZg4GL 3mfcAN7jHKJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaTLxrQAKCRByNAaPFqFW PMNfEACMvcrhN0shAlAfxJ1CXvPVvW15Y2sfxOS7BOJjlzPWo1xDVgMhBYscO/Rtwwh2NkAHEsd xY6Z80Lfct0qCpMMfwqy+zl2o06AjpWnvKeNopXoaJi8iNEr+x7vgZ1Fgmh1evjyKIm6gpCrqab 09YcJdJbBnFQzwVuHmj62CktTKQS3dojqn3xjyBX41mEkInCCnGde9ejDEtGT3VoYAokubAFdPM EmJ1/cEjtE8Xtbrqx9ohTo1YWj4OPj3jRK6v3UhYTMPhAtIZ2sUt5CbZbefXKci8iVJ0F/qFSL/ 04zRQ/h/x9N/TUc2EEGPDqAjnQUL8qi4HMATtAtzGMXooptIi8zRUW+RxCkPD3e8Ib9QIhc6+sb MKrnozVGsGGbuo18RROVD3iy0ijPVkrfgt5BxkfGf5NsabVmqP55OcQ9lqx3vPRdRj+BSGwgopL 0HEr6thEUN+ugMLYV1uCx5mjPmoh5dckF8u+1mf93utknmixIaNaMQdbV4UsrXJW4u0IxorC0Af /Qqtfs7hBeVzQNEOwiJ4uSwbMzCotlV933BbzO0agdBBdYf04gNY/mIuBEIM0Ihc1bgy4Xt2Dft ix867cmGGck54KRxR9MzlvGtqg1nASvxhoqPElZkv8nQ50LHxMdr8PQI3h9mkhMA3B9D8oGBdnF vVn9Q1oZlkXQ2nA== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The sensor size computation routine doesn't work well. Even if a more appriate size for a sensor is available, the largest one is always selected. Fix the size computation procedure which has an inverted assignment. Signed-off-by: Jacopo Mondi --- src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp index 46ef5e7735a30a0d4ae9bb6f8d671bbd2dff3f51..a0a880f26281e5cd9ec176153970a2dd1d230496 100644 --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp @@ -666,7 +666,7 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate() std::abs(static_cast(minSensorSize.height) - static_cast(size.height)); if (dist < distance) { - dist = distance; + distance = dist; bestSize = size; } }