From patchwork Thu Dec 4 16:46:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Milan Zamazal X-Patchwork-Id: 25355 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id A317DBD80A for ; Thu, 4 Dec 2025 16:46:56 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id CEF4B61105; Thu, 4 Dec 2025 17:46:55 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="Iu6P6KuK"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9BD62609E0 for ; Thu, 4 Dec 2025 17:46:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764866812; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zRNPIyymKLSiBsS1o+Iu/SWU0ZSio6QanuZ3gIh97v8=; b=Iu6P6KuKTwY4y9JqxDMQ26R1I4ZqxEWGknjVskTFPN+3DCoEgnX3XX6PDOXjfauGAlgKoK 6sUic9KCCpqQnoII0Kw0b4lm2lVfvODxsKR/3hdm8CZsKIDrel3lOu/Xu7EZ/RocSZHm0K HQeJgaIzIj68LDouC4kDx5d/Feltwzo= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-595-Re2zo2iuNzG7AvEe8YqZNw-1; Thu, 04 Dec 2025 11:46:49 -0500 X-MC-Unique: Re2zo2iuNzG7AvEe8YqZNw-1 X-Mimecast-MFC-AGG-ID: Re2zo2iuNzG7AvEe8YqZNw_1764866808 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AC1851956054; Thu, 4 Dec 2025 16:46:47 +0000 (UTC) Received: from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.32.71]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C84C13011A3E; Thu, 4 Dec 2025 16:46:44 +0000 (UTC) From: Milan Zamazal To: libcamera-devel@lists.libcamera.org Cc: Milan Zamazal , =?utf-8?b?QmFybmFiw6FzIFDFkWN6?= =?utf-8?q?e?= , Kieran Bingham , Umang Jain Subject: [PATCH] libcamera: simple: Move colour space logging after adjustment Date: Thu, 4 Dec 2025 17:46:34 +0100 Message-ID: <20251204164634.82839-1-mzamazal@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 7mcMmhwnOBaqZj2foDBUPSU2pPIcBzXtSL64DZw6Tew_1764866808 X-Mimecast-Originator: redhat.com X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The log message about adjusting an unspecified colour space should log the value after, not before, the adjustment. Fixes: 5a33bc10e9d3bc ("libcamera: software_isp: Assign colour spaces in configurations") Reviewed-by: Barnabás Pőcze Reviewed-by: Umang Jain Signed-off-by: Milan Zamazal --- src/libcamera/pipeline/simple/simple.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp index a06a52926..ebbb04fb2 100644 --- a/src/libcamera/pipeline/simple/simple.cpp +++ b/src/libcamera/pipeline/simple/simple.cpp @@ -1249,9 +1249,6 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate() default: cfg.colorSpace = ColorSpace::Raw; } - LOG(SimplePipeline, Debug) - << "Unspecified color space set to " - << cfg.colorSpace.value().toString(); /* * Adjust the assigned color space to make sure everything is OK. * Since this is assigning an unspecified color space rather than @@ -1259,6 +1256,9 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate() * to Adjusted. */ cfg.colorSpace->adjust(pixelFormat); + LOG(SimplePipeline, Debug) + << "Unspecified color space set to " + << cfg.colorSpace.value().toString(); } else { if (cfg.colorSpace->adjust(pixelFormat)) { LOG(SimplePipeline, Debug)