From patchwork Tue Dec 2 14:49:26 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 25338 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id AD3C1BD80A for ; Tue, 2 Dec 2025 14:49:41 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id D992060D24; Tue, 2 Dec 2025 15:49:38 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="H4Yyw5d2"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 66FE960C8A for ; Tue, 2 Dec 2025 15:49:36 +0100 (CET) Received: from [192.168.1.104] (net-93-65-100-155.cust.vodafonedsl.it [93.65.100.155]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C97E7110; Tue, 2 Dec 2025 15:47:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1764686842; bh=IwWrCI6ckKMAC8VXcFGr+hdS1KUDbLOTw8EpSuR3A6I=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=H4Yyw5d2sko12ukc7CXMuXXRuQHQfjL5JHg9h8pcxO9cJ7nLNNKch2wfhAioslFW8 IuxirroQCoLLWWQT67RbE71Iom5gNHyZnlN+ldNK560o0fOeuzx97OU1YIfqcGyzHU CqJ0/92ddnejEvypeWOAIeR5BUTW+RjPkZ3eL9Cs= From: Jacopo Mondi Date: Tue, 02 Dec 2025 15:49:26 +0100 Subject: [PATCH v3 1/5] libcamera: request: Create control list with Camera info map MIME-Version: 1.0 Message-Id: <20251202-cam-control-override-v3-1-eacab052798d@ideasonboard.com> References: <20251202-cam-control-override-v3-0-eacab052798d@ideasonboard.com> In-Reply-To: <20251202-cam-control-override-v3-0-eacab052798d@ideasonboard.com> To: libcamera-devel@lists.libcamera.org Cc: Jacopo Mondi , Kieran Bingham , Paul Elder X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1617; i=jacopo.mondi@ideasonboard.com; h=from:subject:message-id; bh=IwWrCI6ckKMAC8VXcFGr+hdS1KUDbLOTw8EpSuR3A6I=; b=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBpLvx+WpWPoeeDqm/lEIAWoiN/XTOEdfEK5uCyC XTrbEbMBe6JAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaS78fgAKCRByNAaPFqFW POklD/wOUDCRCzyRxuG2lUyVBfH1wtJdtOr47kgN2t5A+mL8tZi/v+BnOHpVgA8xS3I8lC/srP6 JqIAEQV+GRALnV1Pm6i5EHvaJP3BfJbbTVPtv0H+NXGQ4ZsLBE2MZa2j9z+LDXrTA3kELu8z0ZY eGj3cnuBt3mvXW2TuWh23ocZNsPxjzSO19ofg73wAhHh1G79yMzAMCvsRfDCpsoC0nEuiigyMXI ajbxCbPHgy17fBPf0VCcRq17CelR2tjLVd2IL0yWIO5lXRN8XkpJNm/6lkHpROq+0U0UcXeThXR b+rqMbII8GYCY8LkgfOlQwvxhFhaOX5943Y+jxyhXppNrdE6niKq6iAvm+yrNI2WKgKSmS7/5A+ hhkKtaQuTOujBvcEGQEbuZWIZHQ5uNl71OD+7IuVQmd2UJuSPcypt/301YhtwthA2IVG+se2Sne 70k/Pyvx0Nwyo7m0QzdVXsKa23seZ9yq3+X4KaMB4ZMVOhBEJzwy5UoABQGEJgmeUkc6T5xuT04 /RGiGD/7zEJx4MCRMu7rLebLsr/6EfcYuuzzzSM6YvFDGMmle1m674y8xIwyYeAO+nwW2rHAfxL D0U9N8MNWOJ82cBgLZm+NGNqKS8D3Bi/Sp9mseJLpnZWZeiySA/CVs9k6cv+COISyHylnaZUpQi h3z2MhishnumtYA== X-Developer-Key: i=jacopo.mondi@ideasonboard.com; a=openpgp; fpr=72392EDC88144A65C701EA9BA5826A2587AD026B X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The control lists associated with a Request is created with the global libcamera::controls::controls id map. This is fine as the idmap/info map used to contruct a ControlList are not used for any control validation purposes by the libcamera code. However creating a ControlList with the camera ControlInfoMap has two advantages: 1) The idmap can be extracted from the info map, but not the other way around 2) The control list is constructed with a valid map of info to the controls it can actually supports, instead of the global map of libcamera controls Initialize the ControlList part of a Request with the Camera control info map, as the association between a Request and a Camera is permanent and valid for the whole lifetime of a Request. Signed-off-by: Jacopo Mondi Reviewed-by: Kieran Bingham Reviewed-by: Paul Elder --- src/libcamera/request.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp index 60565f5984971c7ab34e119a15b8141799f71071..2544a059f6984d930ec909c74e0b621c9fe82726 100644 --- a/src/libcamera/request.cpp +++ b/src/libcamera/request.cpp @@ -356,7 +356,7 @@ Request::Request(Camera *camera, uint64_t cookie) : Extensible(std::make_unique(camera)), cookie_(cookie), status_(RequestPending) { - controls_ = new ControlList(controls::controls, + controls_ = new ControlList(camera->controls(), camera->_d()->validator()); /**