From patchwork Tue Dec 2 13:45:33 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 25322 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 6BBB5C32F2 for ; Tue, 2 Dec 2025 13:46:19 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id B025B60D2F; Tue, 2 Dec 2025 14:46:18 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="KLUAQFlF"; dkim-atps=neutral Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 05F7460D15 for ; Tue, 2 Dec 2025 14:46:12 +0100 (CET) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-47790b080e4so29263975e9.3 for ; Tue, 02 Dec 2025 05:46:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764683171; x=1765287971; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vQVPOM12y5l41Oik4t/KhoAdrAnNrZonwF1zaIVHcZw=; b=KLUAQFlFrX05yTNve/JDhbfgfVP/rmhkBEiWw4Bno+W2uanGgOUpStcmT2KZEvaExX 4r3u7xsLbJFmrDT5BS8NdUIEo4btzMCAW7WxzROnZ/RGpbFUDkJtWMMI4dXx0JZAaYXs YqTwTV+2ops8FMU6b1LBKHA3Sr4lsqiow36jjdzofNlvuu70xxBBoJiUjaEI7QkUldrF bIRaLKos4txi/AWjj3fzsV/14tVE/dsfbhJN2S+XDN97Se0uuXRnmrIejbhyGUyRxYql S/pl/Nl7xLDQgYn+VnYcfqfayVNJcvpFtNCMh2qAr0JPC26eQM3IPVAC3IjUd4DpmQoH 7NOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764683171; x=1765287971; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=vQVPOM12y5l41Oik4t/KhoAdrAnNrZonwF1zaIVHcZw=; b=cqOlV5AgZDbgLKXrquuEGg5NCaj3tsr0KTwGgOKJAXLeeSV4RzBd2Z1WFRgr2JXMPa WMZLKiWOQHMZzMDW03PfbazEXW6XRiYtTm2A9BvIQ5mcck4TDbFljAnZgCV1ratEjixf vJZHytpA2jspeuuUv1CEceVixQY82ThpWnVC7EgZ/1QOWVTEVMVNbhoI3sjIyClajG84 H1rhJC/HJqFEQcnA22+lcLS1vgPTXG0yVDgyNsHb/iG9sq3g6ryJHF9YpqBJ7sefbVRp /BqUfdAIMQBKyunBP1EpGMCLIQftG60EzRlQtm5t2P17JYVZuobpx6IVb4F8j+d+j+EK KpWw== X-Gm-Message-State: AOJu0YxOgfCxc1jV7ybEHKTcojNjdNVlmSBcXMHWNLl0nJG7SFeX19PF THH3ZJZ8P5+620YXUK84kMESRzyHyUUQHhk9s1DA0ORDb8FnR3CCg/PgjZO/sCZz2SaU9LpRL0Y gynz5 X-Gm-Gg: ASbGncvA+SNnY3YiJjO9TP+gFPq7Na8d96ospnM2Cusmpe36Zi3iKalPlzYsq8WBcYX RULNwH4p3E91aSm+saAe2zeQZV3/MBvNreVnREk6KnuKv/neOry2WFgnk7IQay/w0ITxGvpxbxF 72Hy57RowioYUrw30MZyPpIpipL34Mr1fQqmsSeFX+T3Dcv+JaOORMnkLeID3vyTmVlSzfr7vcV +J8cN5JpPKK8HXzYLKXT/kSwHwdcl4hADsLYPy42UEjYJDVzs8g/WXvJUJCXzpoDWnLzUbZe3ik xuhJzLH4DsiCe4b56SHoQT1DNAnyWR4OHvJtupPdj5tKXncWIOfCuRri1yqlXP7EWRSdEpI5pkV U2j9lTILsaY2KzR8zutVa7tzUsZLCc3sjlKjQf3Ke4pgQxc0u0/L/ny474rQ5WHe3i9OvrJ25Ni a9v3rm2GUijh+tDTinDe+klbXI4IaQcc1RgkNxIvue4cx4kXTlz9jdvGd0Q1e783CMD+bR/PqRe IGbYg== X-Google-Smtp-Source: AGHT+IFLraZPQtKgszeCWuUGzes16e4eLH4wOa5eVdiDfZ3PToDvhq7g88a35ykZ1cgfwk4zEwX2mw== X-Received: by 2002:a05:600c:354d:b0:46e:49fb:4776 with SMTP id 5b1f17b1804b1-477c10d7003mr425799865e9.11.1764683171347; Tue, 02 Dec 2025 05:46:11 -0800 (PST) Received: from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47926f0ec69sm19383375e9.1.2025.12.02.05.46.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Dec 2025 05:46:10 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: pavel@ucw.cz, Bryan O'Donoghue , Kieran Bingham Subject: [PATCH v6 13/24] libcamera: software_isp: debayer_cpu: Make getInputConfig and getOutputConfig static Date: Tue, 2 Dec 2025 13:45:33 +0000 Message-ID: <20251202134544.662446-14-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251202134544.662446-1-bryan.odonoghue@linaro.org> References: <20251202134544.662446-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Make getInputConfig and getOutputConfig static so as to allow for interrogation of the supported pixel formats prior to object instantiation. Do this so as to allow the higher level logic make an informed choice between CPU and GPU ISP based on which pixel formats are supported. Currently CPU ISP supports more diverse input and output schemes. Acked-by: Kieran Bingham Signed-off-by: Bryan O'Donoghue --- src/libcamera/software_isp/debayer_cpu.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libcamera/software_isp/debayer_cpu.h b/src/libcamera/software_isp/debayer_cpu.h index ecc4f9dd0..67df2b93a 100644 --- a/src/libcamera/software_isp/debayer_cpu.h +++ b/src/libcamera/software_isp/debayer_cpu.h @@ -97,8 +97,8 @@ private: template void debayer10P_RGRG_BGR888(uint8_t *dst, const uint8_t *src[]); - int getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config); - int getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config); + static int getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config); + static int getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config); int setupStandardBayerOrder(BayerFormat::Order order); int setDebayerFunctions(PixelFormat inputFormat, PixelFormat outputFormat,