From patchwork Tue Dec 2 13:45:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 25314 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 63523C32DE for ; Tue, 2 Dec 2025 13:46:05 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id C5FE960D17; Tue, 2 Dec 2025 14:46:04 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="xGs2SImB"; dkim-atps=neutral Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A041E60C92 for ; Tue, 2 Dec 2025 14:45:59 +0100 (CET) Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-477b198f4bcso40705295e9.3 for ; Tue, 02 Dec 2025 05:45:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764683159; x=1765287959; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=W/s9mmdbl87zzKzmRKPs0PR9N0I+f2koWRf2p9p2M+w=; b=xGs2SImBMNZNY3bgVCwvLRDQFE9cSmvYpy93h9e/mtAQHFW1mC4VcKBCKOhnC31Cnz y/EqqTGA/c5f1dvX07KenpvVTskAJPuxX7LFIhnWnf2CRdoTvre418xR1cWb0zmM7MuB zE8G+ZLWfeeb0zetqTyTeBu5HUPi5M9+K+6VAfmj9FpEg3UXcnb+vl2v8RFGqkVVNDZw t1Rh9chHVgNco6UQ/Rp+KZdnOil9Xj7Dvlm4a9n2FwRtFkrl2KOkr6UhnEgvv2m44gFL UujNdmIMzLcBwemgq5n2lWyUDhtzbFprBurhDj6mTRdHbrhfzC3R8EUGlDXFQ+qM8JMU 7Nng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764683159; x=1765287959; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=W/s9mmdbl87zzKzmRKPs0PR9N0I+f2koWRf2p9p2M+w=; b=vHS+0orpDEfKcI4Mmw4KDEyzKij7D5WaSYZ3hB8JaWsDPjHIvEGj6o24Hz5Pra8Ywi 4Zv4AFFkyGzJGn+mQm5yxiTw5XJIbQd3KvrmtmitCRbX0t9ujoR+DrzNvZKpBqVQ2QMF MbZwwmpNdiD6vj2UCYQkuFfXHh0KboDgugqWJxKsHmPLO5TebbP9+0Rg55FpHF60AOi/ hs1723SRyGf8Kv6Vj4C7V76dC0Z2OhyB5JvtznP7O/YiigOm3n2YJ6AIMJgMQPDB8FTn DEEtQtTYxacIRNIuS29Ekw84t7rEkAGZGa+pUuzMF7ysP84XwgsomObr41yEIFzsLa9J g3jA== X-Gm-Message-State: AOJu0YwhPNqqACHNMTdvYO2lxMJ8MS3X+pHImm447xmNJ/URUeQQN4Gx yN/y0BhducxfqQN/tkdOCx1vYUaZrXhRQCSOadaHmmD7aJK+WUg404rfNHOQbxCkGif/UBM9G2d +XgYL X-Gm-Gg: ASbGncvnU0EifQdZwLV3r+CWVzlIBXdeVjOlYFHV8mC16Bzgt8EH4Tal/cNvu3Hd95J J4LSCYBnt2ptqsQEuH4iKFLF0RrJJLTPRog4nuS8Uj72/fD3pfq4/7UZekWq3+0Cpi6Lu9udzXT ihEPpAxlEXIepawC4sHrjivuR+p8OxEMvwGnXRHSPO9HCroWTs9XKkF85ZRfxNWZGxH7OT2qrXA K7Jfj7uHtaVyEK8HJjMQb0RvEMkL+Z/rN/BrgJ1QZYrZf8yFvO+I+kEAE0TzGyyPauX5Sx4BdC+ 9UCPHYankBp2RyMpQcVBcNzyXIYyAOK1PNCVMyASTVNhSIZfAdgNLZvw4/rzo/jQ1b++G/r+k0S Phr8WfdgWqXLthJPCIVVohO5YLpNmcUltiIV3QdNXpqR+Wi6YVOjhdbbvyxDlavDrBr6+C4VmB9 83pWSvBR5trsQ9Q9Zgav81n7NvqSAS/5Tp7hKRWGanGQef/BqP0r/sGc/60qYKDBXLnCU= X-Google-Smtp-Source: AGHT+IHoFvCrxxewE0J4bGcOHNU5dUGu6ccyxKVs6Jo6GnqbmLGYKPsOjqdtSFPyeOJzqX98TKxiOg== X-Received: by 2002:a05:600c:474b:b0:477:9dc1:b706 with SMTP id 5b1f17b1804b1-477c01b494fmr443451105e9.19.1764683158899; Tue, 02 Dec 2025 05:45:58 -0800 (PST) Received: from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47926f0ec69sm19383375e9.1.2025.12.02.05.45.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Dec 2025 05:45:58 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: pavel@ucw.cz, Bryan O'Donoghue , Kieran Bingham Subject: [PATCH v6 05/24] libcamera: shaders: Use highp not mediump for float precision Date: Tue, 2 Dec 2025 13:45:25 +0000 Message-ID: <20251202134544.662446-6-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251202134544.662446-1-bryan.odonoghue@linaro.org> References: <20251202134544.662446-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" mediump gives 10 bits of mantissa as the resolution. At higher resolutions 10 bits of accuracy is insufficient - for example at a width of 1928 bytes we need log2(1928) = ~11 bit resolution. Switching to highp gives us 23 bits of mantissa giving a sample width precision of about 2^23 ~ 8,388,608. Acked-by: Kieran Bingham Signed-off-by: Bryan O'Donoghue --- src/libcamera/shaders/RGB.frag | 2 +- src/libcamera/shaders/YUV_2_planes.frag | 2 +- src/libcamera/shaders/YUV_3_planes.frag | 2 +- src/libcamera/shaders/YUV_packed.frag | 2 +- src/libcamera/shaders/bayer_1x_packed.frag | 2 +- src/libcamera/shaders/bayer_unpacked.frag | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/libcamera/shaders/RGB.frag b/src/libcamera/shaders/RGB.frag index 4c374ac98..724395894 100644 --- a/src/libcamera/shaders/RGB.frag +++ b/src/libcamera/shaders/RGB.frag @@ -6,7 +6,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif varying vec2 textureOut; diff --git a/src/libcamera/shaders/YUV_2_planes.frag b/src/libcamera/shaders/YUV_2_planes.frag index 1d5d12062..d286f1179 100644 --- a/src/libcamera/shaders/YUV_2_planes.frag +++ b/src/libcamera/shaders/YUV_2_planes.frag @@ -6,7 +6,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif varying vec2 textureOut; diff --git a/src/libcamera/shaders/YUV_3_planes.frag b/src/libcamera/shaders/YUV_3_planes.frag index 8f788e90a..8e3e0b4a5 100644 --- a/src/libcamera/shaders/YUV_3_planes.frag +++ b/src/libcamera/shaders/YUV_3_planes.frag @@ -6,7 +6,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif varying vec2 textureOut; diff --git a/src/libcamera/shaders/YUV_packed.frag b/src/libcamera/shaders/YUV_packed.frag index b9ef9d41b..3c9e3e397 100644 --- a/src/libcamera/shaders/YUV_packed.frag +++ b/src/libcamera/shaders/YUV_packed.frag @@ -6,7 +6,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif varying vec2 textureOut; diff --git a/src/libcamera/shaders/bayer_1x_packed.frag b/src/libcamera/shaders/bayer_1x_packed.frag index f53f55758..19b13ad08 100644 --- a/src/libcamera/shaders/bayer_1x_packed.frag +++ b/src/libcamera/shaders/bayer_1x_packed.frag @@ -20,7 +20,7 @@ */ #ifdef GL_ES -precision mediump float; +precision highp float; #endif /* diff --git a/src/libcamera/shaders/bayer_unpacked.frag b/src/libcamera/shaders/bayer_unpacked.frag index 7e35ca88e..aa7a1b004 100644 --- a/src/libcamera/shaders/bayer_unpacked.frag +++ b/src/libcamera/shaders/bayer_unpacked.frag @@ -16,7 +16,7 @@ Copyright (C) 2021, Linaro //Pixel Shader #ifdef GL_ES -precision mediump float; +precision highp float; #endif /** Monochrome RGBA or GL_LUMINANCE Bayer encoded texture.*/