From patchwork Tue Dec 2 13:31:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 25308 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 13743C32F8 for ; Tue, 2 Dec 2025 13:32:40 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 9975160D39; Tue, 2 Dec 2025 14:32:39 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="OJGikJs3"; dkim-atps=neutral Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 8505E60D16 for ; Tue, 2 Dec 2025 14:32:26 +0100 (CET) Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-42e2e5da5fcso1769808f8f.0 for ; Tue, 02 Dec 2025 05:32:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764682346; x=1765287146; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DqgHxVMLlIhOh7RzizVaQec40pqf/UIahAJyMSasrCI=; b=OJGikJs3NoAK/89kG74fD+fqQaxQgzUK1z0cus5biG7f9HvK/qpi1a08049oPzvV57 iofWlzXnjE23/ZNvybT9y0UEjCcsPGSX9frGjc3w4Upex5Q0ClHtXjzdkXaW/ZM2v5YJ MGPCwxyHOeky+z7+lWV4pUuLjcIFeBTtbadjI+p24cQ7aGm9v84BeadJkTzYzQ8SpzxG 423Hajmc1lqWXHmE4+nZYLyVZv/cpq57/tyfv4iIWdYINYxhTmh0BqVxAn+rajb35t7W nnAhPzv1s52lxXSUBc1OTyiCmMDOhiR/5Gk9GsBIwhwtsZGwMMbxZcaVmasxbUpYjW07 mNtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764682346; x=1765287146; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DqgHxVMLlIhOh7RzizVaQec40pqf/UIahAJyMSasrCI=; b=uSkSrI4aQ5FxWaavsLWkTtwsv2UEDT0Hop170l+3EX4oo6Zyu+qBzTBRGns5w5b6WF obL31Qck4TknGmmIQwI5d063G0WLSkin0NAIQvBWCetivgAC/v1XcXKuyOyrmKxVd7wT dooCUQyGXIVbFSGSQfRCnDeYdZM47CY4l7RI1yWSn9TgoT/RKMsTzGv7AeCeaMOoUqKV o6AKRDrnBSdjHA57lWXDIFGsF3jhP1vRAaBAGqhQsh72ZvGSo3CgDu3zQ+dOxG1qYoYj qx2UrxeyVdWHYboqEcCBIR/S0+RSa/IGAt23ghbuT84JA7xP9WY45S3K4Cfavjc/ovAk 65dQ== X-Gm-Message-State: AOJu0YwBw+4iM8vd9hTUHRsU8/FdT1SdzgsADLrj17vockzg1RHU5NOt AjxKfTFZbM93qQ/wkiQWmowBWytltSQC4KxRrevC5AY6IslkdZPd5xDc4ZhjXB7ZgNi3ULr+tzq wF8bK X-Gm-Gg: ASbGncs9m3mn4MpqOwE+HKxrsT2gCg/qP5D4AWK8R2YDtEqdJzo+DZaLondbmJQIJ+n BwqhzzyXw5mg1saWWdpBfuVp0rytESKc1TRgErgRmxNeGD1B95DCccFOFpPcDcKLBFeoKnSJQC4 Ln0D0TawUTBsysvNUS+dGeOnKI/k3w/ZGf+enwDoLJFoSL299CUO/WnIzbAeuExjowf+fnk3Hdo TXVYaaw9Q4oz2vkkS4O3UW9Uac7JUHh9NsYcn1MeQmgWMWOpEzZEnF5DtLkJavcGb6QLrD2eHZh ZK30zTnLE1rn6zv5lCXhDz5Y1nhfnCyMXrdTMIMcspjnM7UvBeBkciBqwDY4/Yrom4a0RCp1pIs Tz/MgShWVGvC8t0/na0sXRzM32im7ahFRGYgNthFsv03tAojR3lK/tHkCS/Qsmi2V6TLhy/kwDB cZe61tEI0X/UY6Ht8K6l/YZ2dLto0p/zOQHnYUmSggTjfUGDZRLfsFRKV4sfLAVuixPGk= X-Google-Smtp-Source: AGHT+IFoulvQ3V34aUHRmh4I93l3uV3LSA4Kn0rjfu31G4n4zsesyV4EW+OP7/p6yciL7Js3k7sX1A== X-Received: by 2002:a5d:4251:0:b0:42c:b8fd:21b3 with SMTP id ffacd0b85a97d-42e0f362440mr23905039f8f.57.1764682345706; Tue, 02 Dec 2025 05:32:25 -0800 (PST) Received: from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42e1c5c30c4sm33363322f8f.9.2025.12.02.05.32.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Dec 2025 05:32:25 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: pavel@ucw.cz, Bryan O'Donoghue , Milan Zamazal , Kieran Bingham Subject: [PATCH v3 22/22] libcamera: software_isp: lut: Make contrast available in debayer params Date: Tue, 2 Dec 2025 13:31:53 +0000 Message-ID: <20251202133157.661407-23-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251202133157.661407-1-bryan.odonoghue@linaro.org> References: <20251202133157.661407-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Provide the contrast used in IPA to Bayer parameters. Similar to the calculated Gamma value we will pass this value into the debayer fragment shader for further consumption. Reviewed-by: Milan Zamazal Reviewed-by: Kieran Bingham Signed-off-by: Bryan O'Donoghue --- include/libcamera/internal/software_isp/debayer_params.h | 1 + src/ipa/simple/algorithms/lut.cpp | 1 + src/libcamera/software_isp/debayer.cpp | 5 +++++ 3 files changed, 7 insertions(+) diff --git a/include/libcamera/internal/software_isp/debayer_params.h b/include/libcamera/internal/software_isp/debayer_params.h index d5dad1a98..8033f7d5b 100644 --- a/include/libcamera/internal/software_isp/debayer_params.h +++ b/include/libcamera/internal/software_isp/debayer_params.h @@ -59,6 +59,7 @@ struct DebayerParams { Matrix ccm; RGB blackLevel; float gamma; + float contrast; }; } /* namespace libcamera */ diff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp index ea5a86b20..9aaab54f1 100644 --- a/src/ipa/simple/algorithms/lut.cpp +++ b/src/ipa/simple/algorithms/lut.cpp @@ -149,6 +149,7 @@ void Lut::prepare(IPAContext &context, } params->gamma = context.configuration.gamma; + params->contrast = context.activeState.gamma.contrast; } void Lut::process([[maybe_unused]] IPAContext &context, diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp index 7e8d81c09..e01358720 100644 --- a/src/libcamera/software_isp/debayer.cpp +++ b/src/libcamera/software_isp/debayer.cpp @@ -115,6 +115,11 @@ namespace libcamera { * \brief Gamma value for the GPUISP */ +/** + * \var DebayerParams::contrast + * \brief Contrast value for GPUISP + */ + /** * \class Debayer * \brief Base debayering class