From patchwork Tue Dec 2 13:31:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 25307 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id E7FB4C32DE for ; Tue, 2 Dec 2025 13:32:38 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 7ED7460D38; Tue, 2 Dec 2025 14:32:38 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="PmhJ0PlQ"; dkim-atps=neutral Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 61AF160D2F for ; Tue, 2 Dec 2025 14:32:25 +0100 (CET) Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-42e2d44c727so1351477f8f.0 for ; Tue, 02 Dec 2025 05:32:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764682345; x=1765287145; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HoRMsGpYrPRY+icAUgHJVJD1/UYHwY8MVQgFeGlpOV4=; b=PmhJ0PlQ0bBC5qwRRNQnueqhkDbMk0Esb74TGsLlRl4hRsKHskgV87qX5KaWLxuCW1 p8UtwUPIGnV0Tb70gq0Ty7yPcleicw05K27iWUIFvo1r4QOM5SLZi3Un3ImiPgC8GGw6 kuLCNaCYoPYu/1JqUYHU8aQjqxZ2xkRLqCRLsdDKwCRdLz6bIcUmoJKobwg4vIoUcRJG LBBEY0dIYShZZfX7PtlDfKVZnD+bpQ3W275ND8Gfu3fuJNNKGAFifKG8en5HyLTIWzCm w74jUpvY30vWd6pBm9fujlZkdklSvFMSbozh2sKgvQdaXbQoMlvaeArRWy795Avn0S4T QhRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764682345; x=1765287145; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HoRMsGpYrPRY+icAUgHJVJD1/UYHwY8MVQgFeGlpOV4=; b=mlGNuvhFJZ2YRT286ihpg0Y3/SA4X/iNgHO+oxp6fXPrPN3DkX8PjNJ+OmoLoUYpNL 5vAoGQSte/XKkMmrzBqnd149gnwrhzwNigoOPgy/o+3ipZWDC3nrylgH8gUYqw5SGl8j LY65SYqgbdswgcoAR2rnp4fIzrS6Nx54kaKTa6JvYBv9FxW1YfKMhdfGhg8/PP/5QfJP d2viYPskFOiYWmQnpHnNIZTVIhaNl6x9YskYceNhql5Tnay/1qyUrXwHs3987G54OtTT r1qTBpxJH6zIqUN8ybAQQHogEWW0p7W7RXTTXLCAPotNy4hTo0i7QaMJ1oVbTPoaJA/c z+IA== X-Gm-Message-State: AOJu0Yxt82MbTZT8pgR/Upx7VP8NAPWHCMf8onpnH6zD2nyrdQOI5ThM 2/pzbHT08YHFGURkhVDY4UReycsJnFaP+RA+Q1hh9r2V3VGeWeQYBbyVDKbKv+dIigYPDSleqic nBvln X-Gm-Gg: ASbGncssO0DXqf8pJyxlixZdbcGvzsaIsqUZu+Xe6QLFvB34WqJK9ZT3/xcQY7h7xo/ XFVhVrBh+XAVm+qSKWqCwocwszMmdMw6nWj8D8JCBPAtIPMPXfJ9cDLSpf9O4gZW9MBYbLmnb26 E9bcLV7k6fLeUjI9o5UZJNpv1EQHZGaGKLN5a8y3NIE5y8A8SPtaGw6Rf3BMJt8mKNn9mSkwx9A vtSBdml/fUuhzF33E3bYxtxYJ+2Di3hs/WQqj8OMcpdh7BmM8SsPsGRK9oaOFRhr00iEwCWjrbj r8JANsQvrlnoEzyE7yqHavze0DE+8ggoQrdoj6NAINQwpcDDzf0Ue6/bk1bIzXNdj2/7mkucdAB mKO081KSsuxlGxWvS0HagbXeUINpe8QMXERS0O6hJZrFyps55Rs5o3nHQHVcLnAtmgDNYSRib2z Qfy8lvEtRrGEOR1H0oKuU85O1U6j+oicegmDx94Fn1XGlb6VpAtGdbXmmqkZ1Oq2A2H7A= X-Google-Smtp-Source: AGHT+IFtMjFGiNlPil8Yuq/yFjoaejOkbWhCH5ynd0ZXcP+6ALGDnkVGJ0AC8iVv0jB3Y4j00+SD8A== X-Received: by 2002:a5d:5d10:0:b0:42b:496e:517c with SMTP id ffacd0b85a97d-42cc1ac9146mr44289434f8f.13.1764682344687; Tue, 02 Dec 2025 05:32:24 -0800 (PST) Received: from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42e1c5c30c4sm33363322f8f.9.2025.12.02.05.32.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Dec 2025 05:32:24 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: pavel@ucw.cz, Bryan O'Donoghue , Milan Zamazal , Kieran Bingham Subject: [PATCH v3 21/22] libcamera: software_isp: lut: Make gamma from lut.cpp available in debayer params Date: Tue, 2 Dec 2025 13:31:52 +0000 Message-ID: <20251202133157.661407-22-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251202133157.661407-1-bryan.odonoghue@linaro.org> References: <20251202133157.661407-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Provide the gamma used in IPA to Bayer parameters. We will pass Gamma into the shader via a uniform and can then tweak that value from outside at will. Reviewed-by: Milan Zamazal Reviewed-by: Kieran Bingham Signed-off-by: Bryan O'Donoghue --- include/libcamera/internal/software_isp/debayer_params.h | 1 + src/ipa/simple/algorithms/lut.cpp | 2 ++ src/libcamera/software_isp/debayer.cpp | 5 +++++ 3 files changed, 8 insertions(+) diff --git a/include/libcamera/internal/software_isp/debayer_params.h b/include/libcamera/internal/software_isp/debayer_params.h index 5a0d9438f..d5dad1a98 100644 --- a/include/libcamera/internal/software_isp/debayer_params.h +++ b/include/libcamera/internal/software_isp/debayer_params.h @@ -58,6 +58,7 @@ struct DebayerParams { */ Matrix ccm; RGB blackLevel; + float gamma; }; } /* namespace libcamera */ diff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp index 49482d711..ea5a86b20 100644 --- a/src/ipa/simple/algorithms/lut.cpp +++ b/src/ipa/simple/algorithms/lut.cpp @@ -147,6 +147,8 @@ void Lut::prepare(IPAContext &context, params->gammaLut[i] = gammaTable[i / div]; } } + + params->gamma = context.configuration.gamma; } void Lut::process([[maybe_unused]] IPAContext &context, diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp index 16bf7a218..7e8d81c09 100644 --- a/src/libcamera/software_isp/debayer.cpp +++ b/src/libcamera/software_isp/debayer.cpp @@ -110,6 +110,11 @@ namespace libcamera { * \brief Blacklevel gains for the GPUISP */ +/** + * \var DebayerParams::gamma + * \brief Gamma value for the GPUISP + */ + /** * \class Debayer * \brief Base debayering class