From patchwork Tue Dec 2 13:31:35 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 25290 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 18334C32AF for ; Tue, 2 Dec 2025 13:32:13 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id A395E60C93; Tue, 2 Dec 2025 14:32:11 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="ZeNuPkcJ"; dkim-atps=neutral Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 08E5660C79 for ; Tue, 2 Dec 2025 14:32:06 +0100 (CET) Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-42e2e3c0dccso1470057f8f.2 for ; Tue, 02 Dec 2025 05:32:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764682325; x=1765287125; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=e99H68rU1D/gDXlHtAR7K7/NWQaghQ9EtXGEFE+XesQ=; b=ZeNuPkcJOPHQvJDPkai/5+T4/8cIOTp0dGQE9jORe7Heon+CQE0tHDd/U/gQfSkLv8 mL/gTDypYZR+E0d3qvfxMmKnI7bFIrpi3caDEgmh6HhfE8JRxr+MbsuBmBQ6nnputuJt fexf6fjA06szAZQ1PHc8+awcI1Sfo1D2qPRf8D2YnziefdGoHWojqRnWF2SiY8oP86Gs IksZ+w2BkpA5bBVA4K5Md6WV6kH9Z9KLvrubTJsGpUOBHJv3Ldj0VLSbHixe+Lt5qund N2+EcVBbQBHrFFSgM5bY1Dr0oeeJVeZrH0JF3j0x3RwqOwuKZJmmogQC67AFRg09K6dD 9S1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764682325; x=1765287125; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=e99H68rU1D/gDXlHtAR7K7/NWQaghQ9EtXGEFE+XesQ=; b=VDEfqZX4uqtZJuIv3DaTRu9+YynE567DKVxFW9edtGEVDqXtCgTZFTGhvNVAVtasC6 KhI9RdqnsYQeqm+3nT/wiFUPAZsZui/Fo42suEnxF43InchsfxgQS2iRIJcYnZtSoZxW tCh6Xcp4ez4hKMH0Y+OSUvn/zZCNIh1jbuYnf/1EdcUyEueYqLMAPGZpDrF/OIBfUxeX WfC9Zd8LkIJMHwEXT7g+ek5HJv5AI+1bZUkzSEShoqwVEryFeoEby0pDd90BVXh4+Fxg 31p2Okvo15KHFckbs/pJ45t9BYCLmLGuW1cLOj8AdNW5YCWePH+Ox0EBx+M4hLNUf5kW jBdg== X-Gm-Message-State: AOJu0YyuJgQmOhKOOLFaa3w2y1m9QgjgCdrkt7GwlwoAc7tnEQtKf1aa chEqwNvJtC3wyri98zg8Esa+XrgChnjAafy2WagGbpiKk3FOp7N4icXgGphRCOo0bhNvpWZxM+B Xy8xU X-Gm-Gg: ASbGncvBZ0r5KwDrKA0lDkQgcapmB7OeT/PGkI539PYFFf2sn5UaxsJfwzhtZ5wFGq0 5KlRX77P5ONOTT6zgvyk1YqILTNIQQaqAzdcRTICbsfM6iZpXeaNAIMm/ihrhI4G66vUDJ8h61R JGsx96iRKYzsgZlSbBnkAaD1EbeupH/ol9+3H2KnOKy8mp7pNsmZqq9Xq1Jd/DJavdM2yNF4juV kkjqAGixILfYNVeEG85Em81sJ9eEY3PlbIo+OXbrvBRsV/PHz4pyCrZXsMmHLI3+cfON/sEnfmX o16IZ/FRBhf71ipKiu/rHdQjexKHHRtGEsPpii1PM6xFl6nk8PLuB4n2myE8qUiNZA2YRb6wzEp NRZW1hX46OYMzU6K3j7kj23SRMQ7f/kQRw8pXjeb48JfATDj2nMiqc7bcAggUPuc3A+laTF5zh2 HjI5thmeMhC4L6ipmTI63rhnKa0vi777cERGmf+vmZRBypLXoxk/KSx2EWjv1QW1Tu864= X-Google-Smtp-Source: AGHT+IGMacyA+TUDfLoWxXSigq8DGn2x9Y+viPaIkwbcH34wQTwpwwBHp2ohGoj0CJsFA8/5RWjDOQ== X-Received: by 2002:a5d:4d4f:0:b0:42e:a70e:cad4 with SMTP id ffacd0b85a97d-42ea70ecf3fmr2782040f8f.55.1764682325259; Tue, 02 Dec 2025 05:32:05 -0800 (PST) Received: from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42e1c5c30c4sm33363322f8f.9.2025.12.02.05.32.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Dec 2025 05:32:04 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: pavel@ucw.cz, Hans de Goede , Kieran Bingham , Milan Zamazal , Bryan O'Donoghue Subject: [PATCH v3 04/22] libcamera: swstats_cpu: Update statsProcessFn() / processLine0() documentation Date: Tue, 2 Dec 2025 13:31:35 +0000 Message-ID: <20251202133157.661407-5-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20251202133157.661407-1-bryan.odonoghue@linaro.org> References: <20251202133157.661407-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Hans de Goede Update the documentation of the statsProcessFn() / processLine0() src[] pointer argument to take into account that swstats_cpu may also be used with planar input data or with non Bayer single plane input data. The statsProcessFn typedef is private, so no documentation is generated for it. Move the new updated src[] pointer argument documentation to processLine0() so that it gets included in the generated docs. Reviewed-by: Kieran Bingham Reviewed-by: Milan Zamazal Signed-off-by: Hans de Goede Signed-off-by: Bryan O'Donoghue --- src/libcamera/software_isp/swstats_cpu.cpp | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp index 4f7bdd231..9c03338a0 100644 --- a/src/libcamera/software_isp/swstats_cpu.cpp +++ b/src/libcamera/software_isp/swstats_cpu.cpp @@ -72,6 +72,19 @@ namespace libcamera { * patternSize height == 1. * It'll process line 0 and 1 for input formats with patternSize height >= 2. * This function may only be called after a successful setWindow() call. + * + * This function takes an array of src pointers each pointing to a line in + * the source image. + * + * Bayer input data requires (patternSize_.height + 1) src pointers, with + * the middle element of the array pointing to the actual line being processed. + * Earlier element(s) will point to the previous line(s) and later element(s) + * to the next line(s). See the DebayerCpu::debayerFn documentation for details. + * + * Planar input data requires a src pointer for each plane, with src[0] pointing + * to the line in plane 0, etc. + * + * For non Bayer single plane input data only a single src pointer is required. */ /**