From patchwork Sat Nov 29 22:01:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rui Wang X-Patchwork-Id: 25276 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 13CEBC3257 for ; Sat, 29 Nov 2025 22:01:20 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id CBE7A60A85; Sat, 29 Nov 2025 23:01:18 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="pgWAnG2g"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 4CB7C60805 for ; Sat, 29 Nov 2025 23:01:17 +0100 (CET) Received: from rui-Precision-7560.local (unknown [209.216.103.65]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5575A42B; Sat, 29 Nov 2025 22:59:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1764453544; bh=vmUChq+NUWys4oSASCIvZLhjIOmRnSQ9t2eLNaGea18=; h=From:To:Cc:Subject:Date:From; b=pgWAnG2gnYc5FV43CDlIGJAYlF6hoLeR1Ky8rUc4qjFYFhq//bgCX8Ycto3i24QJZ kM+YqpngYLuFuyo5HHGzUiimjIvchSoTBM8JkIedLCcP+YPwXmDFIzpzC3uHJMMene Q38mRBM4zYenK5J5N2uici3a8slQLHSs5sV1Vm/c= From: Rui Wang To: libcamera-devel@lists.libcamera.org Cc: Rui Wang Subject: [PATCH v2] media: rkisp1: Fix filter mode register configuration Date: Sat, 29 Nov 2025 17:01:00 -0500 Message-ID: <20251129220100.2685228-1-rui.wang@ideasonboard.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The current implementation in rkisp1_flt_config() treats the arg->mode field as a boolean for enabling DNR mode, which doesn't properly separate the filter enable bit from the DNR mode bit in the RKISP1_CIF_ISP_FILT_MODE register. - Bit 0 of arg->mode controls the filter enable (RKISP1_CIF_ISP_FLT_ENA) - Bit 1 of arg->mode controls the DNR mode (RKISP1_CIF_ISP_FLT_MODE_DNR) This ensures that the filter enable and DNR mode can be configured independently through the mode field. Signed-off-by: Rui Wang --- drivers/media/platform/rockchip/rkisp1/rkisp1-params.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c index c9f88635224c..979a22a5d04d 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c @@ -412,6 +412,7 @@ static void rkisp1_flt_config(struct rkisp1_params *params, arg->lum_weight); rkisp1_write(params->rkisp1, RKISP1_CIF_ISP_FILT_MODE, + (arg->mode & RKISP1_CIF_ISP_FLT_ENA) | (arg->mode ? RKISP1_CIF_ISP_FLT_MODE_DNR : 0) | RKISP1_CIF_ISP_FLT_CHROMA_V_MODE(arg->chr_v_mode) | RKISP1_CIF_ISP_FLT_CHROMA_H_MODE(arg->chr_h_mode) |