From patchwork Thu Nov 27 21:19:29 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Milan Zamazal X-Patchwork-Id: 25272 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C9C30C3260 for ; Thu, 27 Nov 2025 21:20:14 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 1FC3D60A9E; Thu, 27 Nov 2025 22:20:14 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="ZZFMjDgs"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id DA0F3609DE for ; Thu, 27 Nov 2025 22:20:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764278410; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tA3FvcMGKlKLFd7ZIG/lffo3qpOGGb9svNtHOKpTi4U=; b=ZZFMjDgsUbjHV6Qt38N0v3W/xKy2XCzeytf2nEo2n/fapjP9T81dTpHUD5bRmlb5p7YZz0 T7K+msniNJlkkg32YdRCXUtNl8y9AOCtZe3ah1ZB9xecWuEO3ugGts/jgpLaq1kv9u4zau 75LULwFP57m2agxDSkcqhmnDXQQFMKE= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-80-l1zWlIGcNaGbUjdHABa4-A-1; Thu, 27 Nov 2025 16:20:09 -0500 X-MC-Unique: l1zWlIGcNaGbUjdHABa4-A-1 X-Mimecast-MFC-AGG-ID: l1zWlIGcNaGbUjdHABa4-A_1764278408 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2C3D419560AD; Thu, 27 Nov 2025 21:20:08 +0000 (UTC) Received: from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.45.224.67]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 75A0D19560B0; Thu, 27 Nov 2025 21:20:05 +0000 (UTC) From: Milan Zamazal To: libcamera-devel@lists.libcamera.org Cc: Milan Zamazal , Laurent Pinchart , Kieran Bingham , =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= , Paul Elder , Umang Jain Subject: [PATCH v16 8/9] libcamera: simple: Move colour space logging after adjustment Date: Thu, 27 Nov 2025 22:19:29 +0100 Message-ID: <20251127211932.122463-9-mzamazal@redhat.com> In-Reply-To: <20251127211932.122463-1-mzamazal@redhat.com> References: <20251127211932.122463-1-mzamazal@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: q9BnkPKqSGtM84-RVEWKGj08infKsHzXdQwz5mQTwzk_1764278408 X-Mimecast-Originator: redhat.com content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The log message about adjusting an unspecified colour space should log the value after, not before, the adjustment. Signed-off-by: Milan Zamazal --- src/libcamera/pipeline/simple/simple.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp index cbfc06fb6..2820d1254 100644 --- a/src/libcamera/pipeline/simple/simple.cpp +++ b/src/libcamera/pipeline/simple/simple.cpp @@ -1305,9 +1305,6 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate() default: cfg.colorSpace = ColorSpace::Raw; } - LOG(SimplePipeline, Debug) - << "Unspecified color space set to " - << cfg.colorSpace.value().toString(); /* * Adjust the assigned color space to make sure everything is OK. * Since this is assigning an unspecified color space rather than @@ -1315,6 +1312,9 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate() * to Adjusted. */ cfg.colorSpace->adjust(cfg.pixelFormat); + LOG(SimplePipeline, Debug) + << "Unspecified color space set to " + << cfg.colorSpace.value().toString(); } else { if (cfg.colorSpace->adjust(cfg.pixelFormat)) { LOG(SimplePipeline, Debug)