From patchwork Thu Nov 27 02:37:30 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 25252 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 16D8AC32DE for ; Thu, 27 Nov 2025 02:38:22 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8654660BDD; Thu, 27 Nov 2025 03:38:21 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="uXNVdpdQ"; dkim-atps=neutral Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C672B60AB8 for ; Thu, 27 Nov 2025 03:38:16 +0100 (CET) Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-4779adb38d3so1790405e9.2 for ; Wed, 26 Nov 2025 18:38:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764211096; x=1764815896; darn=lists.libcamera.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=U4gZBzqGbQfvRAdn9kIktQq170/k2VAqruGy17o40mc=; b=uXNVdpdQTop3ZHzevS5H6HFSdAqoX76vVnPm7tuBO6hhHACKMhwPSO86LzGD9TeBdm nAgWCAUeP6Iw5fTh9MR7MGHaPmIP6Rd3+zxsnqOJIp9ba2kScbPo6EKHuRryeH2VN8uD Cx7JxWZsouWZNwwpcwX7UyY7B4FRdIssiGcPEoTo1zuKQThaLIbzaoF3owSj9igrY0Rl XUass56gSnENzhaomyT/b3L4QgZyXwEBltvCSWGeSyoot0bFwI5gULJ3Yakf4xiSHSNv n2B1T9en9fm8oVI0dBEs/hyN7l2WdZ5L2k746Y7fMVE7U2ouCAYF5yM2jd723QHSIvzG MgXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764211096; x=1764815896; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=U4gZBzqGbQfvRAdn9kIktQq170/k2VAqruGy17o40mc=; b=RmmZxrKTCLjWVj6bpdk8P1YS7sTB+lpu06lX1nWMf/LizTANNwQL7B6s9uh1glI9dI Kr7tkyKISM7AdTrbuAdUdBnl7FThM1H9ikbjN9ffqqf9HsBnjFHxQeGM4pyQwvps63Pa 35g4hZf3j4YeZRGEjoCKzpCp0H+vSj9AkX+N12J/s8C68IJ4QG2r0WgMM+8vGLX2y23C KOfxfrfjGMDJiMck5MROKx2h6Fr/v/GM3rACH06C6gswZxosj7k6uGZtkWZ0NsfQQLNF XwCYSpgDWEIJSFjXDLj/aBAM+838JEZuH41kDVHgIgDkdFRVlTsr8r+JOPllPTTfheTt QCJw== X-Gm-Message-State: AOJu0YxDaO9RF4Es5AkRjDk9cOr67+bltXecHbrGQG7Sr1HGaRHoxg4b S2kNxL22SsM5w64LgUKR/0R9TvHoRLQP2vaa7YhhMovNi2FCMs8LUHL8E0GAckqK1DtBf21V7E2 GCYu/Ljw= X-Gm-Gg: ASbGncsQXNLJjUwOZZstx+nu5wGx4RTRPF3l8GipFwAGuXCj5SwxyP+tMsLHpB/xYxz rX3kHqdgAyDds8Wcj+zgwutpS7J3CLFNMF6FVgbtsNDu+U9jCZZfJRKA2uCgntQiqDckVd2yWqJ lPxb7z5HvZ/wSzpO4SAIqPn5x6WPXuPike5oH4OX+lHA1r9NtdYWvKHsTYYka8y8ckO0mcZDuiF 6UHxcSpeOgrhtc6ZoBFuFuqFm3ro7bNhjf0yfTZ2Fm/R89RtNDFJCn9hg/48tfSS+QSGlglphfD rIcDPGkv22QFc5yUNKqANqhks76GzPvTjZLx5K5fwM0S7YYCPyEnhaoT1iJmsfmwJkFGjTmn7bj jKcACTkR1hf44ZoPnAc6sGa0CnJyLzjU9LCMo28jBa7KCGIBpX4hnr24xm//Sd1YsBS/1PTygg3 4o2bpXQbyhO4bXxcHfZlEY0lK8b/kCGz0SvPqDIXs0L60ZLkyqU+vYVErZyqQd4LIMIXQ= X-Google-Smtp-Source: AGHT+IHwO5gJ0kdRSW3C7w3wM/FzY5P/yuC26EOEV4IO2FkM82nS1kSz1CbBCVhzjZTGbWFJ875qAg== X-Received: by 2002:a05:600c:460a:b0:471:700:f281 with SMTP id 5b1f17b1804b1-47904b1b2dfmr51046175e9.25.1764211096073; Wed, 26 Nov 2025 18:38:16 -0800 (PST) Received: from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4790552c3c9sm58186345e9.0.2025.11.26.18.38.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Nov 2025 18:38:14 -0800 (PST) From: Bryan O'Donoghue To: libcamera-devel@lists.libcamera.org Cc: pavel@ucw.cz, Bryan O'Donoghue , Kieran Bingham Subject: [PATCH v5 15/24] libcamera: software_isp: debayer_cpu: Make getInputConfig and getOutputConfig static Date: Thu, 27 Nov 2025 02:37:30 +0000 Message-ID: <20251127023739.179652-16-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20251127023739.179652-1-bryan.odonoghue@linaro.org> References: <20251127023739.179652-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Make getInputConfig and getOutputConfig static so as to allow for interrogation of the supported pixel formats prior to object instantiation. Do this so as to allow the higher level logic make an informed choice between CPU and GPU ISP based on which pixel formats are supported. Currently CPU ISP supports more diverse input and output schemes. Acked-by: Kieran Bingham Signed-off-by: Bryan O'Donoghue --- src/libcamera/software_isp/debayer_cpu.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libcamera/software_isp/debayer_cpu.h b/src/libcamera/software_isp/debayer_cpu.h index 2d385cf01..a395fc97c 100644 --- a/src/libcamera/software_isp/debayer_cpu.h +++ b/src/libcamera/software_isp/debayer_cpu.h @@ -98,8 +98,8 @@ private: template void debayer10P_RGRG_BGR888(uint8_t *dst, const uint8_t *src[]); - int getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config); - int getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config); + static int getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config); + static int getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config); int setupStandardBayerOrder(BayerFormat::Order order); int setDebayerFunctions(PixelFormat inputFormat, PixelFormat outputFormat,